← Back to issue list

plugins: update qmake to use get_build_properties and get_pull_properties()

View original Github issue

Metadata

Project
snapcraft
Number
#993
Type
pull request
State
merged
Author
ZenHarbinger
Labels
Created
Updated
Closed

Current evaluation

Updated qmake plugin to use get_build_properties and get_pull_properties, resolving Launchpad bug #1650553. Merged after approval and passing CI, with updated tests and minor coverage gain.

Suggested action:

No scores available.

Issue body

https://bugs.launchpad.net/snapcraft/+bug/1650553 Also updated unit tests

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Updated qmake plugin to use get_build_properties and get_pull_properties, resolving Launchpad bug #1650553. Merged after approval and passing CI, with updated tests and minor coverage gain.
qwen3.6-35b-a3b-mtp-q6 Merged into master. Updated qmake plugin to use get_build_properties and get_pull_properties, resolving Launchpad bug #1650553. Unit tests updated, maintaining coverage above 96%.
qwen3.6-35b-a3b-mtp-q6 Merged into master. Updated the qmake plugin to use get_build_properties and get_pull_properties(), resolving Launchpad bug #1650553. Unit tests were updated, with code coverage increasing by less than 0.01%.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#992 plugins: update make plugin to use get_build_properties() snapcraft merged Merged into master. Updated the make plugin to use get_build_properties() and added corresponding tests. Approved by a reviewer, passed CI checks, and resolved Launchpad bug 1650548.
86%
#1650553 Update qmake plugin to use get_build_properties snapcraft (launchpad) closed Updated the qmake plugin to use get_build_properties() and get_pull_properties() instead of schema modifications, with new tests added. The associated pull request was merged, closing the issue.
82%
#1022 plugins: update copy plugin to use get_build_properties(). snapcraft merged Merged into master. Updates the copy plugin to use get_build_properties(), replacing deprecated properties and completing Launchpad bug #1647899. The change spans two files with a +17/-4 line diff and achieved 100% diff coverage.
80%
#995 plugins: update kernel plugin to use get_build_properties() snapcraft merged Merged update to the kernel plugin switching it to get_build_properties(), resolving Launchpad bug #1650597. Approved by one reviewer, passed CI, and modified four files with a net coverage increase.
79%
#978 Updated cmake plugin to use get_build_properties() snapcraft merged Merged after reviewer approval and passing CI checks. Updated the cmake plugin to use get_build_properties(), modifying two files and slightly increasing overall test coverage.
77%
#463 plugins: qmake craft-parts merged Merged qmake plugin support. Maintainer assisted with ruff linting fixes and test configuration. Contributor resolved local test failures, PR received two approvals, and was successfully merged.
76%
#1001 plugins: update catkin plugin to use get_pull_properties() snapcraft merged Merged changes update the catkin plugin to use get_pull_properties() and add corresponding unit tests. Approved by one reviewer, passed CI checks, and improved overall code coverage. The merge modified two files with a net addition of four lines.
76%
#1002 plugins: update python plugin to support get_pull_properties() snapcraft merged Merged update to the Python plugin adding support for get_pull_properties(). Includes new unit and schema tests. Approved, passed CI, and increased coverage by less than 0.01%. A test method rename was addressed before merge.
74%
#997 plugins: update go plugin to use get_build_properties() snapcraft merged Merged after approval and passing CI. Updates the Go plugin to use get_build_properties(), adjusts the schema test, and adds unit tests for get_pull_properties() and get_build_properties(). Changes successfully integrated.
72%
#998 plugins: update gulp plugin to use get_build_properties() and get_pull_properties() snapcraft merged Merged into master. Updates the gulp plugin to use get_build_properties() and get_pull_properties(), adds unit tests, and updates schema tests. Approved and passed CI checks.
72%