plugins: update qmake to use get_build_properties and get_pull_properties()
Metadata
Current evaluation
Merged PR #993 in commit 2171f6367, updating qmake to use get_build_properties()/get_pull_properties() and revising tests to fix Launchpad bug #1650553.
Resolution: closed resolved
Reason: PR #993 was merged as commit 2171f6367. It updated the qmake plugin to use the plugin property APIs and adjusted unit tests.
Evaluated by: mr-cal-bot
No scores available.
Issue body
https://bugs.launchpad.net/snapcraft/+bug/1650553
Also updated unit tests
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #993 in commit 2171f6367, updating qmake to use get_build_properties()/get_pull_properties() and revising tests to fix Launchpad bug #1650553. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #993 in commit 2171f6367, updating qmake to use get_build_properties() and get_pull_properties(), with unit tests refreshed for Launchpad bug #1650553. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #993, updating qmake to use get_build_properties()/get_pull_properties() and refreshing unit tests; landed as commit 2171f6367. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #993 in commit 2171f6367, switching qmake to get_build_properties() and get_pull_properties() and updating unit tests to resolve Launchpad #1650553. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #993 as commit 2171f6367, updating the qmake plugin and unit tests to use get_build_properties and get_pull_properties; it addresses Launchpad bug #1650553. | |
| qwen/qwen3.6-35b-a3b | — | — | Updated qmake plugin to use get_build_properties and get_pull_properties, resolving Launchpad bug #1650553. Merged after approval and passing CI, with updated tests and minor coverage gain. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Updated qmake plugin to use get_build_properties and get_pull_properties, resolving Launchpad bug #1650553. Unit tests updated, maintaining coverage above 96%. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1650553 Update qmake plugin to use get_build_properties | snapcraft (launchpad) | closed | Merged in snapcore/snapcraft PR #993 (commit 2171f6367), updating qmake to use get_build_properties() and get_pull_properties() and adding tests. | |
| #992 plugins: update make plugin to use get_build_properties() | snapcraft | merged | Merged #992, updating the make plugin and its tests to use get_build_properties(); landed as commit 65a1dd09c. | |
| #978 Updated cmake plugin to use get_build_properties() | snapcraft | merged | Merged PR #978 updated the CMake plugin to implement get_build_properties(), addressing Launchpad bug #1650078 in commit 989177ee3. | |
| #999 Updated autotools plugin to use get_build_properties() | snapcraft | merged | Merged as commit 026fcfdf6: autotools plugin migrated to get_build_properties(), with schema unit test and get_pull_properties() tests updated. Resolves Launchpad bug #1650608. | |
| #998 plugins: update gulp plugin to use get_build_properties() and get_pull_properties() | snapcraft | merged | Merged as acf95e174, updating the Gulp plugin to use build/pull property hooks and adding schema and unit tests for Launchpad bug #1650603. | |
| #1001 plugins: update catkin plugin to use get_pull_properties() | snapcraft | merged | Merged as commit 561a04341: updated the catkin plugin to use get_pull_properties(), refreshed schema tests, and added unit tests for Launchpad bug #1650628. | |
| #1002 plugins: update python plugin to support get_pull_properties() | snapcraft | merged | Merged as commit dc26a14b2: python plugin gained get_pull_properties() support, with updated schema/unit tests, addressing Launchpad bug #1650626. | |
| #1650548 Update make plugin to use get_build_properties | snapcraft (launchpad) | closed | Fixed by merged PR snapcore/snapcraft#992 (commit 65a1dd09c, 'plugins: update make plugin to use get_build_properties()'): the make plugin no longer mutates schema values and instead returns them via get_build_properties(), with new unit tests. | |
| #1022 plugins: update copy plugin to use get_build_properties(). | snapcraft | merged | Merged as commit e9e05f959: copy plugin migrated from deprecated properties to get_build_properties(), the final plugin in the LP #1647899 migration series. | |
| #995 plugins: update kernel plugin to use get_build_properties() | snapcraft | merged | Merged as commit fbd8887ac: kernel plugin migrated from directly setting source/target/arch properties to returning them via get_build_properties(), fixing Launchpad bug #1650597. |