style: ignore legacy folder
Metadata
Current evaluation
Merged a one-line config update to correctly ignore the legacy folder in linting rules. This prevents false positive ruff errors on legacy code. Approved by two reviewers and merged after passing CI checks.
Suggested action: —
No scores available.
Issue body
- [ ] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint`?
- [ ] Have you successfully run `make test`?
---
The legacy folder wasn't being ignored correctly. When testing with `make lint`, this didn't really matter, but any well-meaning individual running `ruff check` would be presented with lint errors from the legacy codebase that didn't actually matter.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a one-line config update to correctly ignore the legacy folder in linting rules. This prevents false positive ruff errors on legacy code. Approved by two reviewers and merged after passing CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged configuration update to ignore the legacy folder, eliminating false positive lint errors from legacy code during ruff checks. Resolved by maintainer bepri. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a configuration update to add the legacy folder to the linting ignore list. This resolves false positive ruff errors from outdated code during style checks. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #20 style: fix linting issues | craft-artifacts | merged | Merged after passing all CI checks and receiving approval from two reviewers. The change resolves linting issues across four files with a +11/-5 line diff, updating code style compliance. | |
| #242 style: fix ty linting error | craft-platforms | merged | Merged a single-file change fixing a ty linting error. Approved by one reviewer and passed CI checks. The one-line modification resolves the style violation. | |
| #239 style(lint): autoformat | starbase | merged | Merged after approval. Applied automated linting to a single file, adjusting one line. The maintainer requested the merge post-review, completed without CI checks or unresolved comments. | |
| #2222 style: fix linting issues | charmcraft | merged | Merged following approval by two reviewers. Resolved linting issues across three files with minor style adjustments (+8/-9 lines). No review comments or CI checks were required. | |
| #33 Linting | imagecraft | merged | Merged a one-line linting fix from a maintainer. The change modified a single file with one addition and one deletion, requiring no reviews or CI checks before integration. | |
| #5 style(lint): fix linting issues | starflow | merged | Merged after approval. Resolved linting issues by modifying one file with three additions and three deletions. No unresolved comments or CI checks were present. | |
| #3865 lint: lint legacy code with black | snapcraft | merged | Merged updates to the test-black lint command to include legacy code, aligning it with autoformat-black. Approved by a maintainer, passed CI checks, and merged without affecting code coverage. | |
| #3852 lint: lint legacy code with isort | snapcraft | merged | Merged to re-enable isort linting for legacy code. Approved by a maintainer, passed all checks, and integrated into main without coverage changes. | |
| #1323 style: fix new ruff warnings | rockcraft | merged | Merged after approval by two reviewers. Resolves new ruff linting warnings by manually adjusting code across three files. CI checks passed prior to integration. | |
| #77 lint: fix linting issues with up-to-date linters | craft-store | merged | Merged a maintainer-submitted pull request resolving linting errors from updated linter versions. Approved by one reviewer, passed CI, and modified 11 files (+40/-24 lines). |