← Back to issue list

style: Resolve remaining ty warnings

View original Github issue

Metadata

Project
snapcraft
Number
#6027
Type
pull request
State
merged
Author
PraaneshSelvaraj
Labels
—
Created
Updated
Closed

Current evaluation

Merged in canonical/snapcraft#6027 (commit 47bda5515), resolving remaining ty warnings through YAML-test unmarshalling, Project.marshal, and targeted service-test suppressions; #5970's warning cleanup is complete.

Resolution: closed resolved

Reason: PR #6027 was merged as commit 47bda5515 after a maintainer-approved force-merge despite an unrelated lint/files failure. Repository metadata identifies #6015 (a36429c18) and #6027 (47bda5515) as the fixes resolving the warnings tracked by #5970 and making lint-ty pass.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This PR addresses remaining `ty` diagnostics uncovered while working on #5970. Changes include: - Updating YAML-based tests to use `Project.unmarshal()` - Fixing a `ty` unresolved-attribute warning in `Project.marshal` - Silencing unavoidable `invalid-argument-type` warnings in service tests Related to #5970. --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#6027 (commit 47bda5515), resolving remaining ty warnings through YAML-test unmarshalling, Project.marshal, and targeted service-test suppressions; #5970's warning cleanup is complete.
stealth/space-bunny-alpha — closed resolved Merged PR #6027 as commit 47bda5515, updating YAML tests and Project marshalling to resolve the remaining ty warnings tracked in #5970.
qwen/qwen3.6-35b-a3b — — Force-merged despite an unrelated lint failure. Resolves remaining ty static analysis warnings, updates YAML test marshaling to use Project.unmarshal(), and fixes an unresolved attribute warning in Project.marshal.
qwen3.6-35b-a3b-mtp-q6 — — Merged after resolving remaining ty type-checking warnings, updating YAML tests, and fixing Project.marshal. Force-merged by a reviewer despite an unrelated lint failure once the missing uv.lock commit was added.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#5970 (confidence 100%)

    Parent tracking issue for the remaining ty diagnostics; #6027 completes the work after #6015.

  • Related To: canonical/snapcraft#6015 (confidence 100%)

    Preceding merged PR, commit a36429c18, addressed additional ty warnings tracked by #5970.

Related issues

Issue Project State Summary Similarity
#5993 style: configure ty snapcraft merged Merged in canonical/snapcraft#5993 (commit c220b3f74), configuring ty exclusions and suppressing unused-ignore warnings without behavioral changes.
79%
#6015 style: fix additional ty warnings snapcraft merged Merged in canonical/snapcraft#6015 via commit a36429c18, fixing additional ty unsupported-operator and not-subscriptable warnings as part of the #5970 cleanup.
78%
#5970 Fix `ty` warnings snapcraft closed Resolved all ty warnings via merged PRs #6015 (a36429c18) and #6027 (47bda5515); make lint-ty now runs cleanly.
72%
#1698 style: ty craft-parts merged Merged PR #1698 as commit 6b4db96f, enabling ty as a lint target and fixing its warnings across 37 files.
72%
#938 style: ty craft-providers merged Merged PR #938 as commit 44bcd1a, adding targeted ty suppressions across 8 files to ignore warnings introduced by the latest ty version.
71%