← Back to issue list

style: fix additional ty warnings

View original Github issue

Metadata

Project
snapcraft
Number
#6015
Type
pull request
State
merged
Author
PraaneshSelvaraj
Labels
—
Created
Updated
Closed

Current evaluation

Merged in canonical/snapcraft#6015 via commit a36429c18, fixing additional ty unsupported-operator and not-subscriptable warnings as part of the #5970 cleanup.

Resolution: closed resolved

Reason: PR #6015 was approved and merged as commit a36429c18. PR #6027 subsequently resolved the remaining warnings tracked by #5970.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This PR fixes a small number of additional ty warnings, including `unsupported-operator` and `not-subscriptable`. Related to #5970. --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#6015 via commit a36429c18, fixing additional ty unsupported-operator and not-subscriptable warnings as part of the #5970 cleanup.
stealth/space-bunny-alpha — closed resolved Merged PR #6015 (commit a36429c18) fixing extra `ty` lint warnings (unsupported-operator, not-subscriptable) across 2 files, +6/-4 lines; part of the #5970 ty cleanup, with the remainder handled in #6027.
stealth/space-bunny-alpha — closed resolved Merged as snapcraft#6015 in commit a36429c18, correcting additional ty unsupported-operator and not-subscriptable warnings as part of #5970.
qwen/qwen3.6-35b-a3b — — Merged pull request resolving additional ty linter warnings for unsupported operators and non-subscriptable types. Approved by two reviewers, passed CI checks, and implemented a minimal two-file fix related to #5970.
qwen3.6-35b-a3b-mtp-q6 — — Merged changes fixing additional ty lint warnings for unsupported-operator and not-subscriptable errors. Addresses related issue #5970. All lint and test checks passed prior to integration.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#5970 (confidence 100%)

    This PR addressed part of the broader ty warning cleanup tracked by #5970.

  • Related To: canonical/snapcraft#6027 (confidence 98%)

    Merged as commit 47bda5515 and resolved the remaining ty warnings from #5970.

Related issues

Issue Project State Summary Similarity
#5993 style: configure ty snapcraft merged Merged in canonical/snapcraft#5993 (commit c220b3f74), configuring ty exclusions and suppressing unused-ignore warnings without behavioral changes.
78%
#6027 style: Resolve remaining ty warnings snapcraft merged Merged in canonical/snapcraft#6027 (commit 47bda5515), resolving remaining ty warnings through YAML-test unmarshalling, Project.marshal, and targeted service-test suppressions; #5970's warning cleanup is complete.
78%
#5970 Fix `ty` warnings snapcraft closed Resolved all ty warnings via merged PRs #6015 (a36429c18) and #6027 (47bda5515); make lint-ty now runs cleanly.
71%
#421 style: ty craft-cli merged Merged PR #421 as 5c6d127, updating ty to unblock snapcraft#5673; it opened #420 to remove mypy and pyright, later resolved by #479.
71%
#1698 style: ty craft-parts merged Merged PR #1698 as commit 6b4db96f, enabling ty as a lint target and fixing its warnings across 37 files.
71%
#242 style: fix ty linting error craft-platforms merged Merged PR #242 with a one-line fix for the ty linting error; the change landed as commit e8b89ce.
71%
#139 style(type): fix typing issues found by ty craft-platforms merged Merged as commit 1a30eec, fixing type-checking edge cases found by ty; the remaining diagnostic was an upstream false positive tracked in astral-sh/ty#553.
70%