← Back to issue list

style: fix additional ty warnings

View original Github issue

Metadata

Project
snapcraft
Number
#6015
Type
pull request
State
merged
Author
PraaneshSelvaraj
Labels
Created
Updated
Closed

Current evaluation

Merged pull request resolving additional ty linter warnings for unsupported operators and non-subscriptable types. Approved by two reviewers, passed CI checks, and implemented a minimal two-file fix related to #5970.

Suggested action:

No scores available.

Issue body

This PR fixes a small number of additional ty warnings, including `unsupported-operator` and `not-subscriptable`. Related to #5970. --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged pull request resolving additional ty linter warnings for unsupported operators and non-subscriptable types. Approved by two reviewers, passed CI checks, and implemented a minimal two-file fix related to #5970.
qwen3.6-35b-a3b-mtp-q6 Merged changes fixing additional ty lint warnings for unsupported-operator and not-subscriptable errors. Addresses related issue #5970. All lint and test checks passed prior to integration.
qwen3.6-35b-a3b-mtp-q6 Merged external changes fixing additional ty lint warnings, including unsupported-operator and not-subscriptable errors. All lint and test checks passed, addressing related issue #5970.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#242 style: fix ty linting error craft-platforms merged Merged a single-file change fixing a ty linting error. Approved by one reviewer and passed CI checks. The one-line modification resolves the style violation.
80%
#2726 style: switch type checking to ty charmcraft merged Merged after switching type checking to the ty tool. Resolves existing ty issues, approved by two reviewers, passed CI checks, and modified 40 files.
78%
#407 style(types): enable type checking with ty craft-cli merged Merged pull request enabling type checking with ty. Approved by two reviewers with all CI checks passing. Changes add 21 lines and remove 3 across three files, successfully implementing the requested type checking improvements.
77%
#446 style(lint): fix typing for ty update craft-cli merged Merged a maintainer pull request fixing typing for the ty linter update. Approved by one reviewer, the change adjusted three files with minor style modifications. CI checks passed and the branch was successfully integrated.
77%
#6247 style: go all-in on ty snapcraft merged Merged after approval by two reviewers. The change adopts the ty linter for comprehensive typo detection, resolving issue #6007. It updated 47 files, reducing 370 lines and adding 139.
77%
#1698 style: ty craft-parts merged Enables ty as a lint target and fixes its warnings across 37 files (+69/-65). Fresh maintainer-authored PR, CI passing with some slow-test jobs pending, awaiting first review.
76%
#335 fix(lint): suppress ty imagecraft merged Merged after two approvals and passing CI checks. Fixes a lint failure by suppressing the ty rule across two files, modifying three lines of code.
75%
#434 style: silence ty warnings craft-cli merged Merged to silence ty linter warnings, aligning with existing linter configurations. Approved by two reviewers and passed CI checks. The change modifies two files with five additions and five deletions.
74%
#421 style: ty craft-cli merged Merged to update the ty tool, unblocking work on snapcraft issue #5673. Approved by two reviewers with all CI checks passing. Changes affect two files (+10/-5 lines) and create follow-up issue #420.
74%
#2222 style: fix linting issues charmcraft merged Merged following approval by two reviewers. Resolved linting issues across three files with minor style adjustments (+8/-9 lines). No review comments or CI checks were required.
74%