← Back to issue list

style: configure ty

View original Github issue

Metadata

Project
snapcraft
Number
#5993
Type
pull request
State
merged
Author
PraaneshSelvaraj
Labels
—
Created
Updated
Closed

Current evaluation

Merged in canonical/snapcraft#5993 (commit c220b3f74), configuring ty exclusions and suppressing unused-ignore warnings without behavioral changes.

Resolution: closed resolved

Reason: PR #5993 was approved and merged as commit c220b3f74. It added the agreed ty configuration and deferred remaining warning cleanup to follow-up work tracked in #5970.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This PR works through `ty` checking and applies the same exclusions discussed in the issue #5970. Current state: - ty configured to ignore `snapcraft_legacy`, `tests/legacy`, `tests/spread`, `build`, `tools`, `venv` similar to mypy The goal is to align with the existing starbase setup without introducing behavioral changes. Further commits will reduce the remaining warnings incrementally. --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#5993 (commit c220b3f74), configuring ty exclusions and suppressing unused-ignore warnings without behavioral changes.
stealth/space-bunny-alpha — closed resolved Merged PR #5993 (commit c220b3f74) configured ty with agreed exclusions and suppressed unused-ignore-comment warnings; remaining warnings were deferred to follow-up PRs.
qwen/qwen3.6-35b-a3b — — Merged PR configuring the ty type checker with directory exclusions and suppressing unused-ignore-comment warnings in pyproject.toml. Follow-up PRs will address remaining warnings.
qwen3.6-35b-a3b-mtp-q6 — — Merged ty linter configuration, applying mypy-style directory exclusions and suppressing unused-ignore-comment warnings in pyproject.toml. Linked a follow-up issue for mypy/pyright removal. Remaining ty warnings will be handled in separate PRs.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#6027 style: Resolve remaining ty warnings snapcraft merged Merged in canonical/snapcraft#6027 (commit 47bda5515), resolving remaining ty warnings through YAML-test unmarshalling, Project.marshal, and targeted service-test suppressions; #5970's warning cleanup is complete.
79%
#6015 style: fix additional ty warnings snapcraft merged Merged in canonical/snapcraft#6015 via commit a36429c18, fixing additional ty unsupported-operator and not-subscriptable warnings as part of the #5970 cleanup.
78%
#938 style: ty craft-providers merged Merged PR #938 as commit 44bcd1a, adding targeted ty suppressions across 8 files to ignore warnings introduced by the latest ty version.
76%
#1698 style: ty craft-parts merged Merged PR #1698 as commit 6b4db96f, enabling ty as a lint target and fixing its warnings across 37 files.
72%
#421 style: ty craft-cli merged Merged PR #421 as 5c6d127, updating ty to unblock snapcraft#5673; it opened #420 to remove mypy and pyright, later resolved by #479.
71%
#6045 fix(type): update ty config for unused-ignore-comment snapcraft merged Merged PR #6045 as commit 23e78c21e, renaming the ty setting to unused-type-ignore-comment for compatibility with ty 0.0.15 and newer.
71%