← Back to issue list

style: ty

View original Github issue

Metadata

Project
craft-parts
Number
#1698
Type
pull request
State
merged
Author
mr-cal
Labels
PR: Squash
Created
Updated
Closed

Current evaluation

Merged PR #1698 as commit 6b4db96f, enabling ty as a lint target and fixing its warnings across 37 files.

Resolution: closed resolved

Reason: The change was squash-merged as commit 6b4db96f and added ty linting while resolving its warnings.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? --- Enables `ty` as a lint target and fixes its warnings. Commits are ordered from least to most controversial.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1698 as commit 6b4db96f, enabling ty as a lint target and fixing its warnings across 37 files.
stealth/space-bunny-alpha — closed resolved PR #1698 was squash-merged as 6b4db96f, adding ty as a lint target and fixing its warnings across 37 files.
stealth/space-bunny-alpha — closed resolved PR #1698 was squash-merged as commit 6b4db96f, enabling ty as a lint target and fixing its warnings across 37 files.
qwen/qwen3.6-35b-a3b — — Squash merged after two approvals. Enables the ty linter target and fixes all associated warnings across 37 files. CI passed except for one slow test failure.
qwen/qwen3.8-27b
Impact: 25
Quick Win: 16
Staleness: 0
Complexity: 35
Confidence: 72
needs review Enables ty as a lint target and fixes its warnings across 37 files (+69/-65). Fresh maintainer-authored PR, CI passing with some slow-test jobs pending, awaiting first review.
qwen/qwen3.8-27b
Impact: 25
Quick Win: 16
Staleness: 5
Complexity: 35
Confidence: 70
needs review Enables ty as a lint target in the Makefile and fixes its warnings across 36 files. Fresh PR by maintainer, 0 days old, no review yet. CI lint/files job is failing; changelog checkbox unchecked.
qwen/qwen3.8-27b
Impact: 20
Quick Win: 13
Staleness: 2
Complexity: 35
Confidence: 85
needs review Enables Astral ty as a default lint target (added to the Makefile lint chain) and fixes its warnings across 32 files (+62/-58). Fresh maintainer PR, 0 days old, CI passing with slow tests pending, no review yet.

Update history

Date Change
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
created

Related issues

Issue Project State Summary Similarity
#938 style: ty craft-providers merged Merged PR #938 as commit 44bcd1a, adding targeted ty suppressions across 8 files to ignore warnings introduced by the latest ty version.
88%
#5970 Fix `ty` warnings snapcraft closed Resolved all ty warnings via merged PRs #6015 (a36429c18) and #6027 (47bda5515); make lint-ty now runs cleanly.
85%
#242 style: fix ty linting error craft-platforms merged Merged PR #242 with a one-line fix for the ty linting error; the change landed as commit e8b89ce.
84%
#885 style: enable type checking with ty craft-providers merged Merged as commit 28ccfe5, PR #885 enabled ty type checking and fixed resulting errors across 8 files; all CI checks passed.
82%
#434 style: silence ty warnings craft-cli merged Merged PR #434 as commit ef91a65, adding targeted ty suppressions matching existing suppressions for other linters across two files.
80%
#446 style(lint): fix typing for ty update craft-cli merged Merged PR #446 as commit 75ec620, updating typing for the ty linter and applying minor style fixes across three files.
80%
#335 fix(lint): suppress ty imagecraft merged Merged in PR #335 as c270f0a, adding targeted ty suppressions in two files so lint passes; all CI checks passed.
80%
#6280 style: ty 0.0.44 snapcraft merged Merged PR #6280 in commit 8b45efc80, applying ty 0.0.44 style updates after two approvals; unrelated CI failures did not block the merge.
78%
#910 style: fix ty error craft-providers merged Merged in #910 via commit 30fc806, adding a targeted suppression for a ty false positive; all listed CI checks passed.
77%
#1716 test: fix ty 0.0.79 issues craft-parts merged Merged PR #1716 as commit 4ef1b34c, fixing ty 0.0.79 findings in unit tests across five files.
77%