← Back to issue list

style: ty

View original Github issue

Metadata

Project
craft-parts
Number
#1698
Type
pull request
State
merged
Author
mr-cal
Labels
PR: Squash
Created
Updated
Closed

Current evaluation

⚠️ This summary may be outdated — the issue content or evaluation prompts have changed since this evaluation was made.

Enables ty as a lint target and fixes its warnings across 37 files (+69/-65). Fresh maintainer-authored PR, CI passing with some slow-test jobs pending, awaiting first review.

Suggested action: needs review

Reason: The PR is brand new (0 days old, last activity 0 days ago) with review status pending and 0 reviewers, so it needs a maintainer review. CI is fully passing with no failing checks (only slow-test jobs pending), and the author notes commits are 'ordered from least to most controversial', suggesting some of the 37 touched files warrant careful review. Confidence is moderate because repository inspection tools were unavailable (no pinned SHA), so the diff content itself could not be verified.

Impact: 25 Quick Win: 16.25 Staleness: 0 Complexity: 35 Confidence: 72

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? --- Enables `ty` as a lint target and fixes its warnings. Commits are ordered from least to most controversial.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.8-27b
Impact: 25
Quick Win: 16.25
Staleness: 0
Complexity: 35
Confidence: 72
needs review Enables ty as a lint target and fixes its warnings across 37 files (+69/-65). Fresh maintainer-authored PR, CI passing with some slow-test jobs pending, awaiting first review.
qwen/qwen3.8-27b
Impact: 25
Quick Win: 16.25
Staleness: 5
Complexity: 35
Confidence: 70
needs review Enables ty as a lint target in the Makefile and fixes its warnings across 36 files. Fresh PR by maintainer, 0 days old, no review yet. CI lint/files job is failing; changelog checkbox unchecked.
qwen/qwen3.8-27b
Impact: 20
Quick Win: 13.0
Staleness: 2
Complexity: 35
Confidence: 85
needs review Enables Astral ty as a default lint target (added to the Makefile lint chain) and fixes its warnings across 32 files (+62/-58). Fresh maintainer PR, 0 days old, CI passing with slow tests pending, no review yet.

Update history

Date Change
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
created

Related issues

Issue Project State Summary Similarity
#421 style: ty craft-cli merged Merged to update the ty tool, unblocking work on snapcraft issue #5673. Approved by two reviewers with all CI checks passing. Changes affect two files (+10/-5 lines) and create follow-up issue #420.
79%
#6247 style: go all-in on ty snapcraft merged Merged after approval by two reviewers. The change adopts the ty linter for comprehensive typo detection, resolving issue #6007. It updated 47 files, reducing 370 lines and adding 139.
78%
#6280 style: ty 0.0.44 snapcraft merged Merged update to ty version 0.0.44. Approved by two reviewers and passed core CI checks. Unrelated lint failures and integration timeouts did not block the merge.
78%
#446 style(lint): fix typing for ty update craft-cli merged Merged a maintainer pull request fixing typing for the ty linter update. Approved by one reviewer, the change adjusted three files with minor style modifications. CI checks passed and the branch was successfully integrated.
78%
#242 style: fix ty linting error craft-platforms merged Merged a single-file change fixing a ty linting error. Approved by one reviewer and passed CI checks. The one-line modification resolves the style violation.
77%
#6015 style: fix additional ty warnings snapcraft merged Merged pull request resolving additional ty linter warnings for unsupported operators and non-subscriptable types. Approved by two reviewers, passed CI checks, and implemented a minimal two-file fix related to #5970.
76%
#2726 style: switch type checking to ty charmcraft merged Merged after switching type checking to the ty tool. Resolves existing ty issues, approved by two reviewers, passed CI checks, and modified 40 files.
76%
#335 fix(lint): suppress ty imagecraft merged Merged after two approvals and passing CI checks. Fixes a lint failure by suppressing the ty rule across two files, modifying three lines of code.
75%
#434 style: silence ty warnings craft-cli merged Merged to silence ty linter warnings, aligning with existing linter configurations. Approved by two reviewers and passed CI checks. The change modifies two files with five additions and five deletions.
75%
#1207 style: replace mypy and pyright with ty rockcraft merged Merged changes replacing mypy and pyright linting tools with ty. Approved by three reviewers and passed CI checks. Updates 43 files to streamline linting configuration and prepare for Starbase integration.
75%