Fix `ty` warnings
Metadata
Current evaluation
Resolved all ty warnings via merged PRs #6015 (a36429c18) and #6027 (47bda5515); make lint-ty now runs cleanly.
Resolution: closed resolved
Reason: PR #6015 fixed additional warnings, and PR #6027 resolved the remaining warnings. Both changes were merged, and the maintainer-confirmed lint run completed without warnings or errors.
Evaluated by: mr-cal-bot
No scores available.
Issue body
### Check existing issues
- [x] I've verified that this request isn't described by any existing issues.
### Request
1. Bring in changes from https://github.com/canonical/starbase/pull/472
2. Run `make lint-ty`
3. Fix or ignore the 650 warnings
### The problem it solves
- To enable `ty` checking for snapcraft
- Unblocks merging starbase into main
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Resolved all ty warnings via merged PRs #6015 (a36429c18) and #6027 (47bda5515); make lint-ty now runs cleanly. | |
| stealth/space-bunny-alpha | — | closed resolved | All ty warnings were resolved through merged PRs #6015 (a36429c18) and #6027 (47bda5515), allowing make lint-ty to pass cleanly. | |
| qwen/qwen3.6-35b-a3b | — | — | Fixed all 650 ty warnings, allowing make lint-ty to run cleanly. The issue was closed after maintainer verification, enabling type checking for snapcraft. | |
| qwen/qwen3.6-35b-a3b | — | — | The issue was successfully resolved. The contributor fixed all 650 ty warnings without behavioral changes, enabling type checking and unblocking the starbase merge. make lint-ty now runs cleanly, and the issue is closed. | |
| qwen/qwen3.6-35b-a3b | — | — | All 650 ty warnings were fixed, making make lint-ty run cleanly. The issue is closed, enabling type checking for snapcraft and unblocking the starbase merge. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Resolved all 650 ty warnings to enable type checking for snapcraft. make lint-ty now runs clean locally, fulfilling the cleanup request and closing the issue. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/snapcraft#6015
(confidence 100%)
Merged as commit a36429c18, fixing additional ty warnings.
-
Likely Fixed By:
canonical/snapcraft#6027
(confidence 100%)
Merged as commit 47bda5515, resolving the remaining ty warnings.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1698 style: ty | craft-parts | merged | Merged PR #1698 as commit 6b4db96f, enabling ty as a lint target and fixing its warnings across 37 files. | |
| #335 fix(lint): suppress ty | imagecraft | merged | Merged in PR #335 as c270f0a, adding targeted ty suppressions in two files so lint passes; all CI checks passed. | |
| #242 style: fix ty linting error | craft-platforms | merged | Merged PR #242 with a one-line fix for the ty linting error; the change landed as commit e8b89ce. | |
| #938 style: ty | craft-providers | merged | Merged PR #938 as commit 44bcd1a, adding targeted ty suppressions across 8 files to ignore warnings introduced by the latest ty version. | |
| #446 style(lint): fix typing for ty update | craft-cli | merged | Merged PR #446 as commit 75ec620, updating typing for the ty linter and applying minor style fixes across three files. | |
| #2957 style: suppress ty diagnostics that block CI | charmcraft | closed | Merged PR #2957 to fix CI `lint-ty` failures by suppressing 22 diagnostics and fixing a redundant cast. | |
| #885 style: enable type checking with ty | craft-providers | merged | Merged as commit 28ccfe5, PR #885 enabled ty type checking and fixed resulting errors across 8 files; all CI checks passed. | |
| #2961 style: suppress ty diagnostics that block CI | charmcraft | merged | Merged PR #2961 adds ty-specific lint ignores to match existing pyright/mypy configurations and removes a redundant cast in _expand_base, resolving CI blocks. | |
| #1716 test: fix ty 0.0.79 issues | craft-parts | merged | Merged PR #1716 as commit 4ef1b34c, fixing ty 0.0.79 findings in unit tests across five files. | |
| #6027 style: Resolve remaining ty warnings | snapcraft | merged | Merged in canonical/snapcraft#6027 (commit 47bda5515), resolving remaining ty warnings through YAML-test unmarshalling, Project.marshal, and targeted service-test suppressions; #5970's warning cleanup is complete. |