← Back to issue list

style: fix ty errors

View original Github issue

Metadata

Project
craft-application
Number
#1126
Type
pull request
State
merged
Author
bepri
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1126 (commit 9f5e0e76): small +8/-10 style fix taking advantage of ty's new Pydantic support, clearing remaining type-checker errors.

Resolution: closed resolved

Reason: PR #1126 was merged into the main branch as commit 9f5e0e76 after approval by 2 reviewers with 0 unresolved review comments; all lint and test CI jobs passed. The change adopted ty's newly added Pydantic support to resolve outstanding type-check errors following the earlier mypy/pyright-to-ty migration in #1084.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? --- Apparently ty supports Pydantic now!

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1126 (commit 9f5e0e76): small +8/-10 style fix taking advantage of ty's new Pydantic support, clearing remaining type-checker errors.
stealth/space-bunny-alpha — closed resolved Merged PR #1126: adopted ty's Pydantic support to fix type-checking errors in a small style update; approved by two reviewers with no unresolved comments.
qwen/qwen3.6-35b-a3b — — Merged a style update to replace pydantic with ty for type checking, leveraging ty's new Pydantic support. Approved by reviewers, passed CI checks, and integrated into the codebase.
qwen3.6-35b-a3b-mtp-q6
Staleness: 5
Complexity: 5
Confidence: 85
needs review Fixes style typos using the ty tool, which now supports Pydantic. The PR is newly opened and awaiting initial maintainer review and CI checks.

Update history

No update history recorded yet.

Related work

  • Related To: craft-application#1084 (confidence 88%)

    Commit 345bd5d9 'style: replace mypy and pyright with ty' introduced the ty type checker that this PR fixed errors for.

  • Related To: craft-application#1182 (confidence 70%)

    Commit cbd30309 'style: fix ty type confusion' is later follow-up ty-cleanup work in the same series.

Related issues

Issue Project State Summary Similarity
#242 style: fix ty linting error craft-platforms merged Merged PR #242 with a one-line fix for the ty linting error; the change landed as commit e8b89ce.
78%
#6247 style: go all-in on ty snapcraft merged Merged PR #6247 (commit 534d7dce7) replaced mypy and pyright with ty, removed obsolete suppressions, and resolved #6007.
77%
#885 style: enable type checking with ty craft-providers merged Merged as commit 28ccfe5, PR #885 enabled ty type checking and fixed resulting errors across 8 files; all CI checks passed.
76%
#1698 style: ty craft-parts merged Merged PR #1698 as commit 6b4db96f, enabling ty as a lint target and fixing its warnings across 37 files.
76%
#446 style(lint): fix typing for ty update craft-cli merged Merged PR #446 as commit 75ec620, updating typing for the ty linter and applying minor style fixes across three files.
76%
#479 style: drop mypy, pyright craft-cli merged Merged PR #479 (commit 0e49c01) dropped the mypy and pyright type checkers in favour of ty, removing ~340 lines of type-checker config and ignore directives across 8 files; all CI checks passed.
75%
#139 style(type): fix typing issues found by ty craft-platforms merged Merged as commit 1a30eec, fixing type-checking edge cases found by ty; the remaining diagnostic was an upstream false positive tracked in astral-sh/ty#553.
75%
#6280 style: ty 0.0.44 snapcraft merged Merged PR #6280 in commit 8b45efc80, applying ty 0.0.44 style updates after two approvals; unrelated CI failures did not block the merge.
75%
#1207 style: replace mypy and pyright with ty rockcraft merged Merged PR #1207 (commit 5d9356c1), replacing mypy and pyright type checking with Astral ty and updating lint configuration across 43 files.
74%
#485 style: ty 0.0.79 craft-cli closed Merged into main: a +2/-2 line one-file style fix for the new error reported by the ty 0.0.79 type checker, by maintainer mr-cal; review approved, all 25 CI checks green. Ty was later bumped to 0.0.82 in craft-parts#1727.
74%