chore: remove unused errors
Metadata
Current evaluation
PR removing unused SnapcraftError subclasses was closed unmerged; superseded by reworking the branch layout and pushing directly to canonical/snapcraft.
Resolution: closed superseded
Reason: Author closed it with comment 'Superseded: reworking the branch layout to work/refactor/* and pushing directly to canonical/snapcraft.' No replacement PR number was linked.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Removes three `SnapcraftError` subclasses that are never raised anywhere in the codebase:
- `InvalidArchitecture`
- `ArchAllInvalid`
- `ProjectMissing`
This also drops a stale comment in `snapcraft/services/init.py` that referred to `ProjectMissing`. That `except` clause was replaced with `craft_application.errors.ProjectFileError` in ddbf2a6f8, and the `ProjectFileError` branch already logs what it does, so the comment was redundant.
No behaviour change.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| ~deepseek/deepseek-pro-latest | — | closed superseded | PR removing unused SnapcraftError subclasses was closed unmerged; superseded by reworking the branch layout and pushing directly to canonical/snapcraft. |
Update history
| Date | Change |
|---|---|
| created |
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #6474 chore: remove unused errors | snapcraft | merged | Merged PR removing three unused SnapcraftError subclasses (InvalidArchitecture, ArchAllInvalid, ProjectMissing) and a stale comment in services/init.py; no behavior change. | |
| #6469 chore: remove unused _read_config | snapcraft | closed | Closed without merging; superseded by a reworked branch pushed directly to canonical/snapcraft under work/refactor/*. | |
| #6472 chore: remove unused set_legacy_env | snapcraft | closed | Closed unmerged; author superseded it by reworking branch layout to work/refactor/* and pushing directly to canonical/snapcraft. | |
| #6241 chore: remove snapcraft_legacy | snapcraft | merged | Merged #6241 via commits ffb164b7a and 995f0a3bc, deleting snapcraft_legacy, obsolete specs, and legacy-only dependencies after its entry points were removed. | |
| #6035 chore!: remove deprecated commands | snapcraft | merged | Merged as 3623601d7, removing deprecated Snapcraft commands and options and resolving #5674 (SNAPCRAFT-1196). | |
| #1078 chore!: remove deprecated APIs | craft-application | merged | Merged PR #1078 as 3334f13e, removing eight deprecated APIs and fixing #1063. All CI checks passed, with local Snapcraft verification. | |
| #6079 chore: delete unused file | snapcraft | merged | Merged PR #6079 as commit 75686f3da, deleting a three-line file unused since Snapcraft moved to a pyproject-based setup. | |
| #5994 chore!: remove legacy remote builder | snapcraft | merged | Merged PR #5994 as b08f1a66e, removing the legacy remote builder and closing #5676 for Snapcraft 9.0. | |
| #68 chore: update to snapcraft 8.9.2 (core22-8) | snapcraft-rocks | closed | Snapcraft 8.9.2 core22-8 update passed CI but was closed unmerged; merged PR #84 superseded it with Snapcraft 8.10.1. | |
| #6074 chore!: remove default command | snapcraft | merged | PR #6074 merged as db7c53f21, removing bare snapcraft packing for #5673; #6178 later reverted the change in e5aaf0683. |