feat: format files with tombi
Metadata
Current evaluation
Merged Tombi formatting via canonical/snapcraft#6459 (commit d76b42262), cherry-picking canonical/starcraft#597 and formatting 15 files.
Resolution: closed resolved
Reason: PR canonical/snapcraft#6459 was approved and merged as commit d76b42262. Reported Spread failures were attributed to unavailable OpenStack infrastructure, not the formatting change.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The first commit cherry-picks https://github.com/canonical/starcraft/pull/597 and the second applies `make format-tombi`.
(SNAPCRAFT-1384)
---
- [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md).
- [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [x] I've successfully run `make lint && make test`.
- [ ] I've added or updated any relevant documentation.
- [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing.
- [ ] I've updated the relevant release notes.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged Tombi formatting via canonical/snapcraft#6459 (commit d76b42262), cherry-picking canonical/starcraft#597 and formatting 15 files. | |
| qwen/qwen3.8-27b | — | closed resolved | Merged formatting PR that cherry-picks canonical/starcraft#597 and applies `make format-tombi` across 15 files (+369/-341), tracked under SNAPCRAFT-1384. Approved by one reviewer; spread-test failures were attributed to OpenStack infra, not the change. | |
| qwen/qwen3.8-27b |
Impact:
15
Quick Win:
10
Complexity:
15
Confidence:
85
Actionability:
75
|
needs review | Cherry-picks starbase#597 (tombi TOML formatter setup) and applies make format-tombi across 15 files (+369/-341). Approved, all unit/lint CI green; 4 spread integration jobs failing on OpenStack infra, author to re-verify before landing. | |
| stealth/space-bunny-alpha |
Impact:
25
Quick Win:
16
Complexity:
20
Confidence:
80
Actionability:
80
|
needs review | Maintainer mr-cal ports starcraft#597 into snapcraft: adds tombi TOML formatting (make format-tombi, config) and reformats 15 TOML files (+369/-341). CI green except openstack spread tests. |
Update history
| Date | Change |
|---|---|
| merged | |
| updated | |
| updated | |
| created |
Related work
-
Related To:
starcraft#597
(confidence 100%)
Its Tombi formatting change was cherry-picked into snapcraft.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #451 style: format TOML files with tombi | imagecraft | closed | Merged TOML formatting with tombi in squash commit 705d996, updating pyproject.toml and osv-scanner.toml ahead of the Starbase merge. | |
| #597 feat: format toml files with tombi | starbase | closed | Merged as commit 79fa93c, adding tombi-based TOML formatting and [tool.tombi] configuration in pyproject.toml; closes #437. | |
| #1213 style: format pyproject.toml with tombi | craft-application | merged | Merged PR applying tombi formatting to pyproject.toml (2-space indent, canonical key ordering), decoupling the mechanical diff from the upcoming Starbase sync. | |
| #277 style: format pyproject.toml with tombi | craft-platforms | closed | Merged as commit 14d9828, mechanically formatting pyproject.toml with tombi; the change was also folded into the Starbase update in #270. |