← Back to issue list

style: format TOML files with tombi

View original Github issue

Metadata

Project
imagecraft
Number
#451
Type
pull request
State
closed
Author
jahn-junior
Labels
—
Created
Updated
Closed

Current evaluation

Merged TOML formatting with tombi in squash commit 705d996, updating pyproject.toml and osv-scanner.toml ahead of the Starbase merge.

Resolution: closed resolved

Reason: The changes landed in main as commit 705d996, titled "style: format TOML files with tombi (#451)." Its closed state reflects the completed merge.

Evaluated by: mr-cal-bot

No scores available.

Issue body

## Context This is a **preparation PR** split out ahead of the Starbase merge PR (#449), per the `update-starbase` skill's preparation-PR rules. Starbase's merge adopts `tombi` as its default TOML formatter (`format-tombi`/`lint-tombi` in `common.mk`), and applying it produces a large mechanical reformat of `pyproject.toml` (~465 lines) dominated by whitespace/quote/ordering changes. Splitting it out keeps the merge diff limited to genuine dependency/content changes. ## Changes - Ran `tombi format` against the current `pyproject.toml` and `osv-scanner.toml` on `main`: 2-space indentation, alphabetically sorted arrays, and quote-style normalization. - No content changes: verified the reformatted `pyproject.toml` parses to the exact same data as before (only list ordering/whitespace/quoting differ). Starbase's own tombi adoption: [canonical/starbase#597](https://github.com/canonical/starbase/pull/597). 🤖 [BEEP BOOP, A BOT WROTE THIS COMMENT - Claude Sonnet 4.5, GitHub Copilot Chat]

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged TOML formatting with tombi in squash commit 705d996, updating pyproject.toml and osv-scanner.toml ahead of the Starbase merge.
stealth/space-bunny-alpha — closed stale Tombi TOML formatting PR was closed without a reported merge; completed checks passed, while snap-builds and build checks were still pending.
stealth/space-bunny-alpha
Impact: 10
Quick Win: 6
Complexity: 22
Confidence: 91
Actionability: 78
needs review Preparatory tombi reformat of two TOML files, described as semantic-preserving; no reviews yet, all completed checks pass, and three build checks remain pending.

Update history

Date Change
closed
created

Related work

  • Related To: canonical/imagecraft#449 (confidence 100%)

    The mechanical TOML reformat was split out as preparation for the Starbase update, which subsequently merged in commit 545f51a.

Related issues

Issue Project State Summary Similarity
#277 style: format pyproject.toml with tombi craft-platforms closed Merged as commit 14d9828, mechanically formatting pyproject.toml with tombi; the change was also folded into the Starbase update in #270.
87%
#200 style: format pyproject.toml with tombi debcraft merged Merged a mechanical reformat of pyproject.toml using tombi for indentation, quoting, and key ordering, preparing for the Starbase sync.
86%
#1213 style: format pyproject.toml with tombi craft-application merged Merged PR applying tombi formatting to pyproject.toml (2-space indent, canonical key ordering), decoupling the mechanical diff from the upcoming Starbase sync.
86%
#506 style: format pyproject.toml with tombi craft-cli merged Merged PR #506 mechanically reformats pyproject.toml with tombi to align with Starbase build tooling, containing no functional changes.
86%
#597 feat: format toml files with tombi starbase closed Merged as commit 79fa93c, adding tombi-based TOML formatting and [tool.tombi] configuration in pyproject.toml; closes #437.
85%
#218 style: format pyproject.toml with tombi craft-grammar merged Merged PR formatting pyproject.toml with tombi to align with Starbase make format and make lint rules. Purely mechanical style changes.
84%
#437 Auto-format TOML files starbase closed TOML auto-formatting was implemented with tombi via PR #597, merged as commit 79fa93c, and added to formatting and lint targets.
80%
#435 chore: format pyproject.toml with tombi craft-store merged Merged PR formatting pyproject.toml with tombi for consistent TOML formatting ahead of starbasification.
78%
#2894 chore: format pyproject.toml with tombi ahead of Starbase merge charmcraft closed Superseded by #2898, which reapplied the tombi formatting and merged as f1af0486 ahead of the Starbase update in #2899.
76%
#6459 feat: format files with tombi snapcraft merged Merged Tombi formatting via canonical/snapcraft#6459 (commit d76b42262), cherry-picking canonical/starcraft#597 and formatting 15 files.
74%