← Back to issue list

feat: format toml files with tombi

View original Github issue

Metadata

Project
starbase
Number
#597
Type
pull request
State
closed
Author
bepri
Labels
Created
Updated
Closed

Current evaluation

Merged to format TOML files using tombi, resolving issue #437. Approved by two reviewers with passing CI checks. The change replaces prior formatter options and enables configuration directly in pyproject.toml across four files.

Suggested action:

No scores available.

Issue body

The TOML formatters to choose from were taplo (in some sort of maybe-maintained-maybe-not limbo), even-better-toml which seems to just be a wrapper on taplo anyways, and tombi. Notably, tombi has the nice feature of being configurable via `[tool.tombi]` in `pyproject.toml` so we don't even need to add a fiftieth config file! Closes #437. --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/starbase/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged to format TOML files using tombi, resolving issue #437. Approved by two reviewers with passing CI checks. The change replaces prior formatter options and enables configuration directly in pyproject.toml across four files.
qwen/qwen3.6-35b-a3b
Impact: 20
Quick Win: 16.0
Staleness: 0
Complexity: 20
Confidence: 75
needs review Formats TOML files with tombi, closing issue #437. Has 2 approvals, CI passing, 2 unresolved review comments.
qwen/qwen3.6-35b-a3b
Impact: 45
Quick Win: 31.5
Staleness: 10
Complexity: 30
Confidence: 75
needs review Adds tombi TOML formatter to replace taplo/even-better-toml, configurable via pyproject.toml. Approved by 2 reviewers, all CI passing, 2 unresolved review comments.
qwen/qwen3.6-35b-a3b
Impact: 30
Quick Win: 24.0
Staleness: 0
Complexity: 20
Confidence: 75
needs review Adds tombi TOML formatter to auto-format TOML files, addressing issue #437. Approved by 1 reviewer with 1 unresolved comment; all CI passing.
qwen/qwen3.6-35b-a3b
Impact: 20
Quick Win: 17.0
Staleness: 0
Complexity: 15
Confidence: 80
needs review Adds tombi TOML formatter with pyproject.toml config, replacing manual formatting. All CI passing, awaiting first review.

Update history

Date Change
closed
updated
updated
updated
created

Related issues

Issue Project State Summary Similarity
#1363 build(lint): add tombi TOML formatting support rockcraft open Adds tombi TOML formatting support to rockcraft, porting changes from starbase. Has 1 approval with reviewer-requested changes recently addressed. CI passing.
74%