← Back to issue list

feat: format toml files with tombi

View original Github issue

Metadata

Project
starbase
Number
#597
Type
pull request
State
closed
Author
bepri
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit 79fa93c, adding tombi-based TOML formatting and [tool.tombi] configuration in pyproject.toml; closes #437.

Resolution: closed resolved

Reason: PR #597 was approved and merged as commit 79fa93c. It added TOML formatting with tombi and resolved the auto-formatting request tracked by #437.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The TOML formatters to choose from were taplo (in some sort of maybe-maintained-maybe-not limbo), even-better-toml which seems to just be a wrapper on taplo anyways, and tombi. Notably, tombi has the nice feature of being configurable via `[tool.tombi]` in `pyproject.toml` so we don't even need to add a fiftieth config file! Closes #437. --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/starbase/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit 79fa93c, adding tombi-based TOML formatting and [tool.tombi] configuration in pyproject.toml; closes #437.
stealth/space-bunny-alpha — closed resolved PR #597 from maintainer bepri was approved and merged into starbase as commit 79fa93c, replacing taplo/even-better-toml with tombi for TOML formatting (configurable via [tool.tombi] in pyproject.toml). Closes issue #437.
stealth/space-bunny-alpha — closed resolved Merged PR #597 as commit 79fa93c, adding TOML formatting with tombi and [tool.tombi] configuration in pyproject.toml; closes #437.
qwen/qwen3.6-35b-a3b — — Merged to format TOML files using tombi, resolving issue #437. Approved by two reviewers with passing CI checks. The change replaces prior formatter options and enables configuration directly in pyproject.toml across four files.
qwen/qwen3.6-35b-a3b
Impact: 20
Quick Win: 16
Staleness: 0
Complexity: 20
Confidence: 75
needs review Formats TOML files with tombi, closing issue #437. Has 2 approvals, CI passing, 2 unresolved review comments.
qwen/qwen3.6-35b-a3b
Impact: 45
Quick Win: 32
Staleness: 10
Complexity: 30
Confidence: 75
needs review Adds tombi TOML formatter to replace taplo/even-better-toml, configurable via pyproject.toml. Approved by 2 reviewers, all CI passing, 2 unresolved review comments.
qwen/qwen3.6-35b-a3b
Impact: 30
Quick Win: 24
Staleness: 0
Complexity: 20
Confidence: 75
needs review Adds tombi TOML formatter to auto-format TOML files, addressing issue #437. Approved by 1 reviewer with 1 unresolved comment; all CI passing.
qwen/qwen3.6-35b-a3b
Impact: 20
Quick Win: 17
Staleness: 0
Complexity: 15
Confidence: 80
needs review Adds tombi TOML formatter with pyproject.toml config, replacing manual formatting. All CI passing, awaiting first review.

Update history

Date Change
closed
updated
updated
updated
created

Related work

  • Related To: canonical/starbase#437 (confidence 100%)

    The PR explicitly closes this TOML auto-formatting issue.

Related issues

Issue Project State Summary Similarity
#451 style: format TOML files with tombi imagecraft closed Merged TOML formatting with tombi in squash commit 705d996, updating pyproject.toml and osv-scanner.toml ahead of the Starbase merge.
85%
#277 style: format pyproject.toml with tombi craft-platforms closed Merged as commit 14d9828, mechanically formatting pyproject.toml with tombi; the change was also folded into the Starbase update in #270.
82%
#506 style: format pyproject.toml with tombi craft-cli merged Merged PR #506 mechanically reformats pyproject.toml with tombi to align with Starbase build tooling, containing no functional changes.
82%
#437 Auto-format TOML files starbase closed TOML auto-formatting was implemented with tombi via PR #597, merged as commit 79fa93c, and added to formatting and lint targets.
81%
#1213 style: format pyproject.toml with tombi craft-application merged Merged PR applying tombi formatting to pyproject.toml (2-space indent, canonical key ordering), decoupling the mechanical diff from the upcoming Starbase sync.
80%
#200 style: format pyproject.toml with tombi debcraft merged Merged a mechanical reformat of pyproject.toml using tombi for indentation, quoting, and key ordering, preparing for the Starbase sync.
79%
#218 style: format pyproject.toml with tombi craft-grammar merged Merged PR formatting pyproject.toml with tombi to align with Starbase make format and make lint rules. Purely mechanical style changes.
77%
#435 chore: format pyproject.toml with tombi craft-store merged Merged PR formatting pyproject.toml with tombi for consistent TOML formatting ahead of starbasification.
77%
#1363 build(lint): add tombi TOML formatting support rockcraft closed Merged PR adding tombi TOML formatting/linting support to rockcraft's build workflow, pinning formatter version and reformatting repository TOML files.
76%
#436 chore: format pyproject.toml with tombi craft-store closed PR #436 was superseded by merged PR #435 (commit fe67242) which applied the same tombi formatting to pyproject.toml.
75%