← Back to issue list

sources: convert to package.

View original Github issue

Metadata

Project
snapcraft
Number
#955
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged conversion of snapcraft/internal/sources.py into a package. Approved by one reviewer and passed CI. This refactoring enables extracting individual source handlers into separate modules in follow-up updates.

Suggested action: —

No scores available.

Issue body

This PR makes progress on LP: [#1648906](https://bugs.launchpad.net/snapcraft/+bug/1648906) by moving `snapcraft/internal/sources.py` into its own package. Subsequent PRs will further refactor this by extracting each source into its own module.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged conversion of snapcraft/internal/sources.py into a package. Approved by one reviewer and passed CI. This refactoring enables extracting individual source handlers into separate modules in follow-up updates.
qwen3.6-35b-a3b-mtp-q6 — — Merged by kyrofa, this pull request converts sources.py into a dedicated package to advance LP #1648906. Codecov noted a 1.18% coverage decrease upon merge. Subsequent changes will extract individual sources into separate modules.
qwen3.6-35b-a3b-mtp-q6 — — Merged by maintainer kyrofa, snapcraft/internal/sources.py was converted into a package to advance Launchpad bug #1648906. Subsequent PRs will extract individual sources. Codecov reports 100% diff coverage.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#61 sources: add snap source handler craft-parts merged Merged. Added a snap source handler to download and extract snap package files, ported from Snapcraft. Approved by three reviewers, passed CI, and added 314 lines across eight files.
76%
#38 sources: add the local source handler craft-parts merged Merged the local source handler for pull and update operations on host filesystem sources. Ported from snapcraft, the change was approved by two reviewers, passed CI, and added 522 lines across three files.
70%