← Back to issue list

style: ruff 0.16

View original Github issue

Metadata

Project
snapcraft
Number
#6378
Type
pull request
State
merged
Author
mr-cal
Labels
PR: Rebase
Created
Updated
Closed

Current evaluation

Housekeeping PR merged to main: ignore new ruff 0.16 rule PLR0917, bump cryptography for a CVE, and drop an outdated maturin constraint. Approved by 2 reviewers.

Resolution: closed resolved

Reason: PR #6378 was merged into snapcraft's main branch after approval by two reviewers, with all lint, unit, and policy checks passing (only integration-spread-tests-store failed). The ruff 0.16 per-file ignore mirrors the upstream canonical/starbase#582 change also merged by the same author.

Evaluated by: mr-cal-bot

No scores available.

Issue body

A few housekeeping fixes: - Ignores a new ruff 0.16 rule (https://github.com/canonical/starbase/pull/582). - Updates cryptography for a CVE - Drops a old constraint for maturin --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Housekeeping PR merged to main: ignore new ruff 0.16 rule PLR0917, bump cryptography for a CVE, and drop an outdated maturin constraint. Approved by 2 reviewers.
stealth/space-bunny-alpha — closed resolved Merged PR #6378 with Ruff 0.16 lint configuration, a cryptography CVE update, and removal of an outdated maturin constraint.
qwen/qwen3.6-35b-a3b — — Merged housekeeping updates: ruff 0.16 configuration, cryptography CVE fix, and removal of an outdated maturin constraint. Approved by two reviewers and passed CI checks prior to merge.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 15
Confidence: 90
needs review Updates ruff to 0.16, bumps cryptography for a CVE, and drops an outdated maturin constraint. Approved by two reviewers with one unresolved comment and several CI checks still pending.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 10
Confidence: 85
needs review Updates ruff to 0.16, bumps cryptography for a CVE, and drops an old maturin constraint. Approved by two reviewers with one unresolved comment. CI integration tests are failing.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 15
Confidence: 90
needs review Updates ruff to 0.16, addresses a new lint rule, updates cryptography for a CVE, and drops an outdated maturin constraint. Approved by two reviewers, CI passing, awaiting final publish/build steps.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 15
Confidence: 85
needs review Updates ruff to 0.16, bumps cryptography for a CVE, and drops an old maturin constraint. Approved by one reviewer with one unresolved comment. CI shows two failing integration tests.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 5
Confidence: 90
needs review Updates cryptography to address a CVE and adjusts linting configuration for ruff 0.16. Currently pending maintainer review with CI passing and one unresolved comment.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 10
Confidence: 85
needs review Bumps cryptography to address a CVE and updates ruff 0.16 configuration to ignore a new rule. Currently pending maintainer review with most CI checks passing, though two self-hosted publish jobs are failing.
qwen/qwen3.6-35b-a3b
Staleness: 0
Complexity: 10
Confidence: 95
needs review Updates cryptography dependency to address a CVE and adds a ruff 0.16 rule ignore. Currently awaiting review and CI completion, with a failing PR title format check.

Update history

Date Change
updated
updated
updated
updated
updated
updated
updated
created

Related work

  • Related To: canonical/starbase#582 (confidence 90%)

    Cited in the PR description as the upstream starbase change adding the new ruff 0.16 rule to the ignore list; that PR was also merged.

Related issues

Issue Project State Summary Similarity
#415 style: fix ruff 0.16 warning craft-store merged Merged PR #415 as commit b24d684, adding a directive to ignore Ruff 0.16's new warning; all CI checks passed.
77%
#5574 style: ruff 0.12 snapcraft merged Merged Ruff 0.12 compatibility and style updates in commit 94a594fd3 after approval by two reviewers.
77%
#199 Update ruff to 0.6 craft-store merged Merged PR #199 updated Ruff to 0.6 across 13 files (+44/-44) after approval by two reviewers.
75%
#1323 style: fix new ruff warnings rockcraft merged PR #1323 merged to main: hand-fixed minor new Ruff warnings in 3 files (+30/-20). Lint and all test suites passed; only source-spread-tests failed (unrelated to style change).
74%
#20 style: fix ruff issue craft-platforms merged Merged PR #20 fixed a Ruff linting issue in one file (+1/-3); resolution is commit 71a165d.
74%
#1288 style: fix ruff PTH211 errors craft-parts merged Merged as commit 13382674: PR #1288 fixed Ruff 0.13 PTH211 errors across eight files (+29/-30), with all CI checks passing.
74%
#409 style(ruff): disable PLW1641 starbase merged Merged PR #409 as commit 095cb0a, disabling Ruff rule PLW1641 (eq-without-hash); all CI checks passed.
73%
#582 style: ruff 0.16 starbase merged Merged starbase#582 ("style: ruff 0.16", +1/-0) by maintainer mr-cal, adding PLR0917 (too many positional arguments) to the per-file Ruff ignores for tests.
73%
#41 build(deps): update to ruff 0.6.1 craft-grammar merged Renovate-style dependency bump PR updating the Ruff build dependency to 0.6.1 across three files (+4/-4). Approved by 2 reviewers with no unresolved comments and merged into main as commit 2f07089.
73%
#2074 style: update to ruff 0.9.0 formatting charmcraft merged Merged PR #2074 in commit af377cd8, updating formatting for Ruff 0.9.0 to address new lint failures.
73%