← Back to issue list

style: ruff 0.16

View original Github issue

Metadata

Project
snapcraft
Number
#6378
Type
pull request
State
merged
Author
mr-cal
Labels
PR: Rebase
Created
Updated
Closed

Current evaluation

Merged housekeeping updates: ruff 0.16 configuration, cryptography CVE fix, and removal of an outdated maturin constraint. Approved by two reviewers and passed CI checks prior to merge.

Suggested action:

No scores available.

Issue body

A few housekeeping fixes: - Ignores a new ruff 0.16 rule (https://github.com/canonical/starbase/pull/582). - Updates cryptography for a CVE - Drops a old constraint for maturin --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged housekeeping updates: ruff 0.16 configuration, cryptography CVE fix, and removal of an outdated maturin constraint. Approved by two reviewers and passed CI checks prior to merge.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 15
Confidence: 90
needs review Updates ruff to 0.16, bumps cryptography for a CVE, and drops an outdated maturin constraint. Approved by two reviewers with one unresolved comment and several CI checks still pending.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 10
Confidence: 85
needs review Updates ruff to 0.16, bumps cryptography for a CVE, and drops an old maturin constraint. Approved by two reviewers with one unresolved comment. CI integration tests are failing.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 15
Confidence: 90
needs review Updates ruff to 0.16, addresses a new lint rule, updates cryptography for a CVE, and drops an outdated maturin constraint. Approved by two reviewers, CI passing, awaiting final publish/build steps.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 15
Confidence: 85
needs review Updates ruff to 0.16, bumps cryptography for a CVE, and drops an old maturin constraint. Approved by one reviewer with one unresolved comment. CI shows two failing integration tests.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 5
Confidence: 90
needs review Updates cryptography to address a CVE and adjusts linting configuration for ruff 0.16. Currently pending maintainer review with CI passing and one unresolved comment.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 10
Confidence: 85
needs review Bumps cryptography to address a CVE and updates ruff 0.16 configuration to ignore a new rule. Currently pending maintainer review with most CI checks passing, though two self-hosted publish jobs are failing.
qwen/qwen3.6-35b-a3b
Staleness: 0
Complexity: 10
Confidence: 95
needs review Updates cryptography dependency to address a CVE and adds a ruff 0.16 rule ignore. Currently awaiting review and CI completion, with a failing PR title format check.

Update history

Date Change
updated
updated
updated
updated
updated
updated
updated
created

Related issues

Issue Project State Summary Similarity
#5574 style: ruff 0.12 snapcraft merged Merged after two reviewer approvals. Updates codebase for ruff 0.12 compatibility. CI passed except a non-blocking OSV-scanner failure. Changes affect 8 files with 56 additions and 23 deletions.
82%
#582 style: ruff 0.16 starbase merged Merged following two approvals and successful CI checks. Updates ruff to 0.16 and adds a configuration to ignore the PLR0917 rule for tests.
81%
#5343 style: ruff 0.11 fixes snapcraft merged Merged minor style updates to align with ruff 0.10 and 0.11. Approved by two reviewers, passed CI checks, and merged with minimal changes across one file.
80%
#408 style: fix linting for ruff 0.12 starbase merged Merged a one-line update to resolve linting errors for ruff 0.12. Approved by two reviewers and passed all CI checks before integration.
79%
#901 style: fix ruff 0.13 linting issues craft-application merged Merged after passing all CI checks and receiving approval from two reviewers. Resolves ruff 0.13 linting issues with a single-line change to one file.
78%
#415 style: fix ruff 0.16 warning craft-store merged Merged after two approvals and passing CI. Resolved a ruff 0.16 warning by adding an ignore directive copied from Starbase. The change added a single line to one file.
77%
#803 style: fix linting issues with ruff 0.12 craft-application merged Merged after approval by two reviewers. Resolves linting failures introduced by ruff 0.12 across 14 files. CI passed for fast tests, linting, and security scans, while slow test failures were tracked separately in #804.
77%
#2074 style: update to ruff 0.9.0 formatting charmcraft merged Merged to align code formatting with ruff 0.9.0 linting rules. Approved by two reviewers and passed CI. One change was noted for upstreaming to starbase instead of applying it locally.
77%
#1517 build: update ruff settings charmcraft merged Merged update to ruff configuration settings. The one-file build adjustment received approval from two reviewers and was integrated without comments or CI issues.
77%
#1156 style: fix linting errors for ruff 0.12.0 craft-parts merged Merged after receiving approval from two reviewers and passing all CI checks. The update resolves linting errors introduced by ruff 0.12.0 across five files, adjusting code formatting to comply with the new linter version.
77%