style(lint): ignore FBT001 and FBT002 in tests
Metadata
Current evaluation
Merged. Updates lint configuration to ignore FBT001 and FBT002 rules in test files, as boolean arguments are standard testing patterns. Approved by two reviewers, passed CI checks, and applied with a minimal two-line change to align with the ecosystem.
Suggested action: —
No scores available.
Issue body
Boolean-typed positional arguments and boolean default values are common patterns in tests (e.g. parametrize). This aligns with the rest of the craft-* ecosystem (craft-application, craft-providers, craft-cli).
This change was suggested by copilot after it examined all the other starcraft repositories for consistency.
---
- [ ] I've followed the [contribution guidelines](https://github.com/canonical/starbase/blob/main/CONTRIBUTING.md).
- [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [ ] I've successfully run `make lint && make test`.
- [ ] I've added or updated any relevant documentation.
- [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing.
- [ ] I've updated the relevant release notes.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged. Updates lint configuration to ignore FBT001 and FBT002 rules in test files, as boolean arguments are standard testing patterns. Approved by two reviewers, passed CI checks, and applied with a minimal two-line change to align with the ecosystem. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged lint configuration changes to ignore FBT001 and FBT002 rules in test files. Boolean arguments and defaults are standard in test parametrization and align with the craft-* ecosystem. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #151 style(lint): disable magic value check in tests | starbase | merged | Merged to disable the magic value lint check in tests, resolving issue #148. Approved by three reviewers, passed CI checks, and maintained 100% test coverage with a single line change. | |
| #335 fix(lint): suppress ty | imagecraft | merged | Merged after two approvals and passing CI checks. Fixes a lint failure by suppressing the ty rule across two files, modifying three lines of code. | |
| #415 style: add TC001, TC002 and TC003 rules | starbase | merged | Merged. Added TC001, TC002, and TC003 linting rules. Approved by two reviewers, passed all CI checks, and modified one file with three additions and three deletions. | |
| #5 style(lint): fix linting issues | starflow | merged | Merged after approval. Resolved linting issues by modifying one file with three additions and three deletions. No unresolved comments or CI checks were present. | |
| #1154 fix(lint): ignore PLR0917 in tests alongside PLR0913 | craft-application | merged | Merged a lint fix extending the PLR0913 test ignore to also suppress PLR0917. This resolves nine lint errors in test files caused by pytest fixtures and parametrization, allowing make lint-ruff to pass. Approved by two reviewers with all CI checks passing. | |
| #239 style(lint): autoformat | starbase | merged | Merged after approval. Applied automated linting to a single file, adjusting one line. The maintainer requested the merge post-review, completed without CI checks or unresolved comments. | |
| #5820 style: ignore legacy folder | snapcraft | merged | Merged a one-line config update to correctly ignore the legacy folder in linting rules. This prevents false positive ruff errors on legacy code. Approved by two reviewers and merged after passing CI checks. |