← Back to issue list

fix(lint): suppress ty

View original Github issue

Metadata

Project
imagecraft
Number
#335
Type
pull request
State
merged
Author
smethnani
Labels
—
Created
Updated
Closed

Current evaluation

Merged in PR #335 as c270f0a, adding targeted ty suppressions in two files so lint passes; all CI checks passed.

Resolution: closed resolved

Reason: PR #335 merged as commit c270f0a and fixed the lint failure with targeted suppressions. The PR was approved with no unresolved comments and all CI checks passing.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Suppresses ty rule to fix lint check --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/imagecraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in PR #335 as c270f0a, adding targeted ty suppressions in two files so lint passes; all CI checks passed.
stealth/space-bunny-alpha — closed resolved Merged PR #335 in commit c270f0a, suppressing the ty lint rule in two files; all CI checks passed.
stealth/space-bunny-alpha — closed resolved Merged as commit c270f0a via PR #335, suppressing the ty rule in two files to restore passing lint checks; all CI checks passed.
stealth/space-bunny-alpha — closed resolved Merged as c270f0a via PR #335, suppressing the ty rule in two files to fix the lint check. All CI checks passed.
stealth/space-bunny-alpha — closed resolved Merged in canonical/imagecraft#335 (commit c270f0a), suppressing the ty lint rule in two files to fix the lint failure; all CI checks passed.
stealth/space-bunny-alpha — closed resolved Merged PR #335 in commit c270f0a, suppressing the ty lint rule across two files to restore lint checks.
qwen/qwen3.6-35b-a3b — — Merged after two approvals and passing CI checks. Fixes a lint failure by suppressing the ty rule across two files, modifying three lines of code.
qwen3.6-35b-a3b-mtp-q6 — — Merged to suppress the ty lint rule and resolve a failing lint check. The change passed make lint and make test before being approved and merged.

Update history

No update history recorded yet.

Related work

  • Caused By: canonical/imagecraft#328 (confidence 90%)

    Merged as fc21f39, switching type checking to ty before these lint suppressions were needed.

  • Related To: canonical/imagecraft#341 (confidence 90%)

    Follow-up PR merged as 96c4d21 to clear ty diagnostics in partition-number helpers.

Related issues

Issue Project State Summary Similarity
#434 style: silence ty warnings craft-cli merged Merged PR #434 as commit ef91a65, adding targeted ty suppressions matching existing suppressions for other linters across two files.
82%
#2957 style: suppress ty diagnostics that block CI charmcraft closed Merged PR #2957 to fix CI `lint-ty` failures by suppressing 22 diagnostics and fixing a redundant cast.
81%
#1698 style: ty craft-parts merged Merged PR #1698 as commit 6b4db96f, enabling ty as a lint target and fixing its warnings across 37 files.
80%
#5970 Fix `ty` warnings snapcraft closed Resolved all ty warnings via merged PRs #6015 (a36429c18) and #6027 (47bda5515); make lint-ty now runs cleanly.
79%
#938 style: ty craft-providers merged Merged PR #938 as commit 44bcd1a, adding targeted ty suppressions across 8 files to ignore warnings introduced by the latest ty version.
79%
#2961 style: suppress ty diagnostics that block CI charmcraft merged Merged PR #2961 adds ty-specific lint ignores to match existing pyright/mypy configurations and removes a redundant cast in _expand_base, resolving CI blocks.
78%
#27 ci: type check with ty craft-artifacts merged Merged PR #27 as commit 716f05a, adding ty type checking to CI and suppressing intentional type violations; related lint fixes landed in #20.
78%
#242 style: fix ty linting error craft-platforms merged Merged PR #242 with a one-line fix for the ty linting error; the change landed as commit e8b89ce.
75%
#910 style: fix ty error craft-providers merged Merged in #910 via commit 30fc806, adding a targeted suppression for a ty false positive; all listed CI checks passed.
75%
#446 style(lint): fix typing for ty update craft-cli merged Merged PR #446 as commit 75ec620, updating typing for the ty linter and applying minor style fixes across three files.
74%