← Back to issue list

build: enable pyright

View original Github issue

Metadata

Project
charmcraft
Number
#1525
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged changes enabling pyright type checking. Configured a gradual rollout by downgrading type errors to warnings. Approved by two reviewers, the update modifies 12 files with a +60/-31 line diff.

Suggested action:

No scores available.

Issue body

No description provided.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged changes enabling pyright type checking. Configured a gradual rollout by downgrading type errors to warnings. Approved by two reviewers, the update modifies 12 files with a +60/-31 line diff.
qwen3.6-35b-a3b-mtp-q6 Merged to enable pyright type checking. A gradual adoption strategy downgraded many type errors to warnings, preserving build stability. The change passed maintainer review and was successfully integrated.
qwen3.6-35b-a3b-mtp-q6 Merged to enable pyright type checking. The maintainer adopted a gradual approach by downgrading numerous type errors to warnings, allowing incremental codebase improvements without breaking the build.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1574 style(type): enable stricter pyright rules charmcraft merged Merged changes enabling stricter pyright type checking rules. Approved by two reviewers, the update modifies three files with a +4/-15 line diff to enforce stricter static analysis standards.
83%
#1703 build: update pyright to 1.1.366 charmcraft merged Merged update to pyright version 1.1.366. The change modified two files with a net reduction of five lines. Approved by one reviewer with no unresolved comments before integration.
82%
#515 build(deps): update pyright craft-application merged Successfully merged pyright dependency update. Approved by two reviewers with no unresolved comments. Changes modify three files, adding five and removing three lines.
82%
#170 build(deps): update pyright starbase merged Updated pyright configuration was merged after reviewer approval and passing CI checks. The changes disabled pyright complaints for mocks and moved the types/pyright settings into Renovate's group, affecting three files.
81%
#266 build(deps): update pyright craft-application merged Merged the pyright dependency update following three reviewer approvals and passing CI checks. The minimal changes affected two files.
80%
#158 style(types): update pyright craft-store merged Merged following approval by two reviewers and successful CI checks. The change updated pyright type checking configuration, modifying two files with minimal adjustments to align with updated pyright standards.
79%
#701 build(deps): update pyright to 1.1.358 craft-parts merged Merged update to pyright version 1.1.358. Approved by two reviewers and passed CI. A lint issue was addressed separately in PR #702. The change modified three files with minimal adjustments.
79%
#58 lint: fix typing issues with updated pyright craft-archives merged Merged following reviewer approval and successful CI checks. Fixed typing errors introduced by an updated pyright version across seven files. Improved overall code coverage by 0.03%.
79%
#2052 style(type): make pyright stricter charmcraft merged Merged changes that enforce stricter pyright type checking by converting two warnings to errors and resolving the resulting type issues across 16 files.
79%
#342 type: fix pyright possibly-unbound error rockcraft merged Merged to resolve a pyright possibly-unbound type error. Approved by two reviewers, passed CI checks, and modified one file with three additions and two deletions.
78%