← Back to issue list

build: enable pyright

View original Github issue

Metadata

Project
charmcraft
Number
#1525
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1525 as commit 6374ef9e, enabling Pyright with existing type errors downgraded to warnings for gradual adoption.

Resolution: closed resolved

Reason: PR #1525 was approved and merged into main as commit 6374ef9e, adding Pyright-based type checking.

Evaluated by: mr-cal-bot

No scores available.

Issue body

No description provided.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1525 as commit 6374ef9e, enabling Pyright with existing type errors downgraded to warnings for gradual adoption.
stealth/space-bunny-alpha — closed resolved Merged charmcraft PR #1525 (commit 6374ef9e): added pyright as a static type checker, with existing type errors demoted to warnings for gradual adoption. 12 files, +60/-31.
stealth/space-bunny-alpha — closed resolved Merged canonical/charmcraft#1525, enabling Pyright with existing type errors configured as warnings for gradual adoption. The change updated 12 files (+60/-31).
qwen/qwen3.6-35b-a3b — — Merged changes enabling pyright type checking. Configured a gradual rollout by downgrading type errors to warnings. Approved by two reviewers, the update modifies 12 files with a +60/-31 line diff.
qwen3.6-35b-a3b-mtp-q6 — — Merged to enable pyright type checking. A gradual adoption strategy downgraded many type errors to warnings, preserving build stability. The change passed maintainer review and was successfully integrated.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#170 build(deps): update pyright starbase merged Pyright updates were merged: mock complaints were disabled and types/pyright was grouped with Pyright in Renovate. PR #170 landed as commit 20eb129.
79%
#1528 Enable pyright and clear the typing issues charmcraft closed Pyright was enabled by merged PR #1525 (6374ef9e), then tightened by #1574 and #1614; #1528 was later closed without a maintainer explanation.
78%
#1703 build: update pyright to 1.1.366 charmcraft merged Merged PR #1703 upgraded Pyright to 1.1.366 in two build files via commit d189a48e.
78%
#1294 style: enable strict type checking with pyright craft-parts merged Merged as bb62329e, enabling strict Pyright type checking and fixing resulting errors across 58 files.
77%
#1574 style(type): enable stricter pyright rules charmcraft merged Merged PR #1574 in commit 3445f5f4, enabling stricter Pyright type-checking rules across three files.
77%
#613 build(deps): update pyright to 1.1.373 craft-providers merged Merged PR #613 updated pyright to 1.1.373 in commit 0f8df4f.
76%
#58 lint: fix typing issues with updated pyright craft-archives merged Merged PR #58 as commit 7983916, fixing typing issues across seven files after Pyright was updated.
75%
#342 type: fix pyright possibly-unbound error rockcraft merged Merged PR #342 fixed a Pyright possibly-unbound diagnostic with a small one-file change, landing as commit 06629929.
75%
#2052 style(type): make pyright stricter charmcraft merged Merged PR canonical/charmcraft#2052, promoting two Pyright warnings to errors and fixing the resulting type errors across 16 files.
75%
#161 build(deps): update dependency pyright to v1.1.402 imagecraft merged Renovate PR #161 bumping pyright 1.1.401 -> 1.1.402 was approved and merged into main as commit fbe8b05; pyright later removed from pyproject in #231.
74%