← Back to issue list

style(type): enable stricter pyright rules

View original Github issue

Metadata

Project
charmcraft
Number
#1574
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged changes enabling stricter pyright type checking rules. Approved by two reviewers, the update modifies three files with a +4/-15 line diff to enforce stricter static analysis standards.

Suggested action:

No scores available.

Issue body

No description provided.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged changes enabling stricter pyright type checking rules. Approved by two reviewers, the update modifies three files with a +4/-15 line diff to enforce stricter static analysis standards.
qwen3.6-35b-a3b-mtp-q6 Merged a maintainer-submitted change enabling stricter pyright type-checking rules. The update was integrated without discussion to enforce more rigorous static type analysis across the codebase.
qwen3.6-35b-a3b-mtp-q6 Merged changes enabling stricter pyright type-checking rules. The maintainer updated the configuration to enforce tighter static analysis standards across the codebase.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1614 style(typing): enable most disabled pyright checks charmcraft merged Merged after approval by two reviewers, enabling most previously disabled pyright type checking rules. The update modifies 16 files (+94/-106 lines) to enforce stricter static type analysis across the codebase.
89%
#2052 style(type): make pyright stricter charmcraft merged Merged changes that enforce stricter pyright type checking by converting two warnings to errors and resolving the resulting type issues across 16 files.
85%
#1525 build: enable pyright charmcraft merged Merged changes enabling pyright type checking. Configured a gradual rollout by downgrading type errors to warnings. Approved by two reviewers, the update modifies 12 files with a +60/-31 line diff.
83%
#158 style(types): update pyright craft-store merged Merged following approval by two reviewers and successful CI checks. The change updated pyright type checking configuration, modifying two files with minimal adjustments to align with updated pyright standards.
83%
#186 style(typing): update pyright craft-application merged Merged after updating pyright configuration and typing across seven files. Approved by two reviewers, passed CI checks, and maintained 99.28% test coverage with 29 additions and 20 deletions.
80%
#639 style: update pyright craft-parts merged Merged a style update to pyright via an automated codespell autofix. Approved by two reviewers, passed CI checks, and modified four files.
78%
#16 style: make pyright less concerned about grammar methods craft-grammar merged Merged a style update configuring pyright to reduce warnings for grammar methods. Approved by one reviewer, passed CI checks, and applied a minimal change of four additions and two deletions across one file.
77%
#1294 style: enable strict type checking with pyright craft-parts merged Merged PR enabling strict type checking with pyright. All resulting type errors were resolved, improving the project's typing and linting status. The change passed CI checks and was approved, successfully integrating stricter type safety.
77%
#342 type: fix pyright possibly-unbound error rockcraft merged Merged to resolve a pyright possibly-unbound type error. Approved by two reviewers, passed CI checks, and modified one file with three additions and two deletions.
76%
#58 lint: fix typing issues with updated pyright craft-archives merged Merged following reviewer approval and successful CI checks. Fixed typing errors introduced by an updated pyright version across seven files. Improved overall code coverage by 0.03%.
75%