← Back to issue list

style(type): enable stricter pyright rules

View original Github issue

Metadata

Project
charmcraft
Number
#1574
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1574 in commit 3445f5f4, enabling stricter Pyright type-checking rules across three files.

Resolution: closed resolved

Reason: PR #1574 was merged as commit 3445f5f4, directly implementing the stricter Pyright configuration.

Evaluated by: mr-cal-bot

No scores available.

Issue body

No description provided.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1574 in commit 3445f5f4, enabling stricter Pyright type-checking rules across three files.
stealth/space-bunny-alpha — closed resolved Merged PR #1574 (commit 3445f5f4), enabling stricter Pyright type-checking rules across three files.
qwen/qwen3.6-35b-a3b — — Merged changes enabling stricter pyright type checking rules. Approved by two reviewers, the update modifies three files with a +4/-15 line diff to enforce stricter static analysis standards.
qwen3.6-35b-a3b-mtp-q6 — — Merged a maintainer-submitted change enabling stricter pyright type-checking rules. The update was integrated without discussion to enforce more rigorous static type analysis across the codebase.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1294 style: enable strict type checking with pyright craft-parts merged Merged as bb62329e, enabling strict Pyright type checking and fixing resulting errors across 58 files.
83%
#1614 style(typing): enable most disabled pyright checks charmcraft merged Merged as commit 66952557, enabling most previously disabled Pyright checks and updating typing across 16 files.
80%
#2052 style(type): make pyright stricter charmcraft merged Merged PR canonical/charmcraft#2052, promoting two Pyright warnings to errors and fixing the resulting type errors across 16 files.
79%
#186 style(typing): update pyright craft-application merged Merged PR #186 as commit 43e6f1b9, updating Pyright configuration and typing across seven files (+29/-20).
79%
#1525 build: enable pyright charmcraft merged Merged PR #1525 as commit 6374ef9e, enabling Pyright with existing type errors downgraded to warnings for gradual adoption.
77%
#158 style(types): update pyright craft-store merged Merged into main as commit 1b66727, updating Pyright typing configuration in two files after approval by two reviewers.
76%
#58 lint: fix typing issues with updated pyright craft-archives merged Merged PR #58 as commit 7983916, fixing typing issues across seven files after Pyright was updated.
75%
#1528 Enable pyright and clear the typing issues charmcraft closed Pyright was enabled by merged PR #1525 (6374ef9e), then tightened by #1574 and #1614; #1528 was later closed without a maintainer explanation.
74%
#1706 style: drop mypy, pyright craft-parts merged Merged PR #1706 in commit 770e2130, replacing mypy and pyright with ty; redundant runtime type-check cleanup was deferred to #1707.
72%
#237 style: fix pyright config craft-cli merged Merged #237 (commit 675d42a), updating two Pyright ignore patterns so they apply recursively.
71%