Enable pyright and clear the typing issues
Metadata
Current evaluation
Pyright was enabled by merged PR #1525 (6374ef9e), then tightened by #1574 and #1614; #1528 was later closed without a maintainer explanation.
Resolution: closed stale
Reason: The only recorded comment was an automated Jira synchronization, with no closing rationale after prolonged inactivity. Related typing work was merged, but GitHub does not document why the issue itself was closed.
Evaluated by: mr-cal-bot
No scores available.
Issue body
### What needs to get done
1. Enable pyright (#1525)
2. Ensure all current errors reduced to warning are fixed
### Why it needs to get done
Stricter typing will help us fix many common bugs.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed stale | Pyright was enabled by merged PR #1525 (6374ef9e), then tightened by #1574 and #1614; #1528 was later closed without a maintainer explanation. | |
| stealth/space-bunny-alpha | — | closed resolved | Pyright was enabled by PR #1525 (6374ef9e); stricter rules and typing cleanups followed in PRs #1574 (3445f5f4) and #1614 (66952557). | |
| stealth/space-bunny-alpha | — | closed stale | No documented resolution was recorded; the only comment was an automated CRAFT-2502 Jira notice, followed by about 903 days without activity. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed without a linked pull request or resolution. The task was synced to internal Jira ticket CRAFT-2502, suggesting it was abandoned or handled outside the repository. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without a direct GitHub resolution. The pyright typing task was superseded by internal Jira ticket CRAFT-2502, with no associated pull request or code changes noted. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without a merged pull request, indicating the pyright integration and typing fixes were deferred or abandoned. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed without a merge or explicit resolution. The request to enable pyright and fix typing errors was logged, but no implementation pull request or fix was documented, indicating the task was abandoned. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
charmcraft#1525
(confidence 100%)
Merged as commit 6374ef9e; enabled Pyright with existing errors initially configured as warnings.
-
Likely Fixed By:
charmcraft#1574
(confidence 95%)
Enabled stricter Pyright rules.
-
Likely Fixed By:
charmcraft#1614
(confidence 95%)
Enabled most previously disabled Pyright checks.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1525 build: enable pyright | charmcraft | merged | Merged PR #1525 as commit 6374ef9e, enabling Pyright with existing type errors downgraded to warnings for gradual adoption. | |
| #58 lint: fix typing issues with updated pyright | craft-archives | merged | Merged PR #58 as commit 7983916, fixing typing issues across seven files after Pyright was updated. | |
| #65 Fixed new pyright issues. | craft-cli | merged | Maintainer PR fixing newly surfaced Pyright type errors (2-line change in 1 file). Merged into main as commit bbf67e4 via merge commit 88a68ac; Pyright was later dropped from the repo (#327, #479). | |
| #186 style(typing): update pyright | craft-application | merged | Merged PR #186 as commit 43e6f1b9, updating Pyright configuration and typing across seven files (+29/-20). | |
| #1574 style(type): enable stricter pyright rules | charmcraft | merged | Merged PR #1574 in commit 3445f5f4, enabling stricter Pyright type-checking rules across three files. | |
| #1294 style: enable strict type checking with pyright | craft-parts | merged | Merged as bb62329e, enabling strict Pyright type checking and fixing resulting errors across 58 files. | |
| #158 style(types): update pyright | craft-store | merged | Merged into main as commit 1b66727, updating Pyright typing configuration in two files after approval by two reviewers. | |
| #1614 style(typing): enable most disabled pyright checks | charmcraft | merged | Merged as commit 66952557, enabling most previously disabled Pyright checks and updating typing across 16 files. | |
| #639 style: update pyright | craft-parts | merged | Merged #639 in commit 162a3522, updating Pyright and including codespell autofixes across four files. | |
| #4233 type: workaround for pyright bug | snapcraft | merged | Merged as f5b2f2e0f, adding a two-file typing workaround for microsoft/pyright#5394 after maintainer approval. |