← Back to issue list

ci: add experimental workflow using ty for type checking

View original Github issue

Metadata

Project
charmcraft
Number
#2370
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2370 (commit d06324ff) added an experimental ty type-checking workflow; CI passed and reported ty diagnostics were informational.

Resolution: closed resolved

Reason: PR #2370 was approved and merged as commit d06324ff, adding the experimental ty workflow. A later change, PR #2726 (commit f2e05e81), switched the project’s type checking to ty.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Since craft-platforms is passing with ty, let's give it something a bit harder to bang against.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2370 (commit d06324ff) added an experimental ty type-checking workflow; CI passed and reported ty diagnostics were informational.
stealth/space-bunny-alpha — closed resolved Added an experimental CI workflow for ty type checking; approved PR #2370 was merged in commit d06324ff.
stealth/space-bunny-alpha — closed resolved Merged experimental ty type-checking CI in charmcraft#2370 via commit d06324ff; all required checks passed, with reported ty errors treated as informational.
stealth/space-bunny-alpha — closed resolved Merged canonical/charmcraft#2370, adding an experimental ty type-checking CI workflow in commit d06324ff; reported ty errors were informational, and the final typecheck CI passed.
stealth/space-bunny-alpha — closed resolved Experimental ty type-checking CI was added and merged in charmcraft#2370 (commit d06324ff); reviewers approved it, all checks passed, and reported ty errors were informational.
stealth/space-bunny-alpha — closed resolved Merged PR #2370 (commit d06324ff), adding an experimental, non-blocking ty type-checking CI workflow for Charmcraft.
stealth/space-bunny-alpha — closed resolved Merged PR #2370 added an experimental, non-blocking ty type-checking workflow to Charmcraft, landing as commit d06324ff.
qwen/qwen3.6-35b-a3b — — Merged an experimental CI workflow adding ty type checking. All checks passed despite bot notifications of type errors, which were marked as informational. Approved by two reviewers and integrated into the repository.
qwen3.6-35b-a3b-mtp-q6 — — Merged an experimental CI workflow for ty type checking. It flagged unresolved imports and attribute errors in charmcraft. The maintainer noted extensive pyright ignores, and the workflow was merged despite ongoing type failures.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/charmcraft#2726 (confidence 90%)

    Follow-up commit f2e05e81 promoted ty to the project’s type-checking tool.

Related issues

Issue Project State Summary Similarity
#132 ci(experimental): type check with ty craft-platforms merged PR #132 merged, adding experimental ty type checking to CI; detected type errors were retained as non-blocking notifications.
84%
#27 ci: type check with ty craft-artifacts merged Merged PR #27 as commit 716f05a, adding ty type checking to CI and suppressing intentional type violations; related lint fixes landed in #20.
80%
#2538 ci: adjust the ty experimental workflow to use beta charmcraft merged Merged #2538 in commit 76aa10a3, updating the experimental ty type-checking workflow to use the beta release.
79%
#885 style: enable type checking with ty craft-providers merged Merged as commit 28ccfe5, PR #885 enabled ty type checking and fixed resulting errors across 8 files; all CI checks passed.
77%
#62 ci: use the latest edge ty in the experimental workflow craft-artifacts closed Closed unmerged after typecheck-with-ty failed; the experimental workflow was not updated to use the latest edge version of ty.
74%
#2662 fix: prevent typecheck_with_ty workflow from failing on external PRs charmcraft merged Merged PR #2662 (commit ca1d431f) split the typecheck_with_ty workflow into a 'Run ty' step and a 'Report as a comment' step with continue-on-error, so fork PRs no longer fail CI on read-only token addComment errors.
73%
#910 style: fix ty error craft-providers merged Merged in #910 via commit 30fc806, adding a targeted suppression for a ty false positive; all listed CI checks passed.
72%
#160 style: silence the ty job craft-platforms merged Merged PR #160 (commit 469db5d) by lengau silenced the experimental ty typecheck CI job and, as a drive-by, removed the leftover unused yamllint pre-commit hook; all CI checks passed.
71%
#60 ci: get ty from beta craft-artifacts closed PR #60 was approved but closed unmerged after typecheck-with-ty failed; the beta-channel change to the ty installation workflow was abandoned.
71%