← Back to issue list

style: silence the ty job

View original Github issue

Metadata

Project
craft-platforms
Number
#160
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #160 (commit 469db5d) by lengau silenced the experimental ty typecheck CI job and, as a drive-by, removed the leftover unused yamllint pre-commit hook; all CI checks passed.

Resolution: closed resolved

Reason: The PR itself was merged into main as commit 469db5d ("style: silence the ty job (#160)"), a 2-file, +1/-5 change that disabled the experimental ty job and dropped the orphaned yamllint pre-commit hook. It was later superseded in spirit by #223/#207, which switched to or re-enabled ty as the project's real type checker.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The celebration is getting a bit much. Drive-by: remove unused yamllint pre-commit hook - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #160 (commit 469db5d) by lengau silenced the experimental ty typecheck CI job and, as a drive-by, removed the leftover unused yamllint pre-commit hook; all CI checks passed.
qwen/qwen3.6-35b-a3b — closed resolved Silenced the ty lint job and removed the unused yamllint pre-commit hook. Merged by maintainer lengau.

Update history

Date Change
created

Related work

  • Caused By: canonical/craft-platforms#132 (confidence 70%)

    PR #132 'ci(experimental): type check with ty' added the experimental ty CI job that this PR silenced.

  • Related To: canonical/craft-platforms#144 (confidence 70%)

    PR #144 removed the yamllint dependency but left its pre-commit hook behind, which this PR cleaned up as a drive-by.

  • Superseded By: canonical/craft-platforms#223 (confidence 55%)

    Later PRs (#207 pyright→ty, #223 switch mypy+pyright to ty) made ty the real type checker, reversing the silencing done here.

Related issues

Issue Project State Summary Similarity
#434 style: silence ty warnings craft-cli merged Merged PR #434 as commit ef91a65, adding targeted ty suppressions matching existing suppressions for other linters across two files.
76%
#1698 style: ty craft-parts merged Merged PR #1698 as commit 6b4db96f, enabling ty as a lint target and fixing its warnings across 37 files.
75%
#885 style: enable type checking with ty craft-providers merged Merged as commit 28ccfe5, PR #885 enabled ty type checking and fixed resulting errors across 8 files; all CI checks passed.
74%
#27 ci: type check with ty craft-artifacts merged Merged PR #27 as commit 716f05a, adding ty type checking to CI and suppressing intentional type violations; related lint fixes landed in #20.
74%
#2957 style: suppress ty diagnostics that block CI charmcraft closed Merged PR #2957 to fix CI `lint-ty` failures by suppressing 22 diagnostics and fixing a redundant cast.
74%
#910 style: fix ty error craft-providers merged Merged in #910 via commit 30fc806, adding a targeted suppression for a ty false positive; all listed CI checks passed.
74%
#938 style: ty craft-providers merged Merged PR #938 as commit 44bcd1a, adding targeted ty suppressions across 8 files to ignore warnings introduced by the latest ty version.
74%
#6280 style: ty 0.0.44 snapcraft merged Merged PR #6280 in commit 8b45efc80, applying ty 0.0.44 style updates after two approvals; unrelated CI failures did not block the merge.
72%
#335 fix(lint): suppress ty imagecraft merged Merged in PR #335 as c270f0a, adding targeted ty suppressions in two files so lint passes; all CI checks passed.
71%
#2370 ci: add experimental workflow using ty for type checking charmcraft merged Merged PR #2370 (commit d06324ff) added an experimental ty type-checking workflow; CI passed and reported ty diagnostics were informational.
71%