ci: type check with ty
Metadata
Current evaluation
Merged to integrate ty type checking into CI, silencing intentional violations. Reviewers advised delaying broader adoption until ty stabilizes. The change remains opt-in for dependent projects pending upstream fixes.
Suggested action: —
No scores available.
Issue body
Also silences ty in cases where we're intentionally doing bad things.
Linting issues are fixed in #20
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint && make test`?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged to integrate ty type checking into CI, silencing intentional violations. Reviewers advised delaying broader adoption until ty stabilizes. The change remains opt-in for dependent projects pending upstream fixes. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged as an opt-in type checker in starbase. The maintainer deferred integration into starflow due to ty's unstable status and current failures, opting to address linting issues separately. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2370 ci: add experimental workflow using ty for type checking | charmcraft | merged | Merged an experimental CI workflow adding ty type checking. All checks passed despite bot notifications of type errors, which were marked as informational. Approved by two reviewers and integrated into the repository. | |
| #472 style: enable ty by default | starbase | merged | Merged to enable the ty type checker by default. Approved by two reviewers with all CI checks passing. The minimal configuration change lays groundwork for eventually replacing mypy and pyright once ty reaches stable release. | |
| #407 style(types): enable type checking with ty | craft-cli | merged | Merged pull request enabling type checking with ty. Approved by two reviewers with all CI checks passing. Changes add 21 lines and remove 3 across three files, successfully implementing the requested type checking improvements. | |
| #60 ci: get ty from beta | craft-artifacts | closed | Closed without merging after the typecheck-with-ty CI check failed. Although approved by a reviewer, the change to fetch ty from beta was abandoned. | |
| #2726 style: switch type checking to ty | charmcraft | merged | Merged after switching type checking to the ty tool. Resolves existing ty issues, approved by two reviewers, passed CI checks, and modified 40 files. | |
| #2538 ci: adjust the ty experimental workflow to use beta | charmcraft | merged | Merged a one-line update to switch the experimental ty type-checking CI workflow to the beta version. Approved by two reviewers, passed CI checks, and successfully integrated. | |
| #6045 fix(type): update ty config for unused-ignore-comment | snapcraft | merged | Merged a configuration update renaming unused-ignore-comment to unused-type-ignore-comment, ensuring compatibility with ty linter version 0.0.15 and higher. Approved by reviewers and passed all CI checks. | |
| #2692 style(type): add ty ignores | charmcraft | closed | Closed without merging. The PR adding ty type ignores remained unreviewed with unresolved comments and multiple failing CI checks. The change was abandoned. | |
| #446 style(lint): fix typing for ty update | craft-cli | merged | Merged a maintainer pull request fixing typing for the ty linter update. Approved by one reviewer, the change adjusted three files with minor style modifications. CI checks passed and the branch was successfully integrated. | |
| #62 ci: use the latest edge ty in the experimental workflow | craft-artifacts | closed | Closed without merging. The PR updated the experimental CI workflow to use the latest edge ty version but failed the typecheck-with-ty check. Unresolved CI and comment functionality issues led to abandonment. |