ci: type check with ty
Metadata
Current evaluation
Merged PR #27 as commit 716f05a, adding ty type checking to CI and suppressing intentional type violations; related lint fixes landed in #20.
Resolution: closed resolved
Reason: PR #27 was merged into the project after approval and passing CI, with commit 716f05a adding ty type checking to CI and silencing intentional type errors. The PR also identifies #20 as the completed linting fixes.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Also silences ty in cases where we're intentionally doing bad things.
Linting issues are fixed in #20
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint && make test`?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #27 as commit 716f05a, adding ty type checking to CI and suppressing intentional type violations; related lint fixes landed in #20. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #27 in commit 716f05a, adding ty type checking to CI and suppressing intentional type violations; related lint fixes were tracked in #20. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #27 as 716f05a, adding ty type checking to CI and suppressing intentional type violations; related lint fixes are tracked in #20. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as 716f05a, adding ty type checking to CI and suppressing intentional type violations; lint fixes are tracked in #20. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to integrate ty type checking into CI, silencing intentional violations. Reviewers advised delaying broader adoption until ty stabilizes. The change remains opt-in for dependent projects pending upstream fixes. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged as an opt-in type checker in starbase. The maintainer deferred integration into starflow due to ty's unstable status and current failures, opting to address linting issues separately. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-artifacts#20
(confidence 100%)
The PR body states that the related linting issues were fixed in #20.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #885 style: enable type checking with ty | craft-providers | merged | Merged as commit 28ccfe5, PR #885 enabled ty type checking and fixed resulting errors across 8 files; all CI checks passed. | |
| #132 ci(experimental): type check with ty | craft-platforms | merged | PR #132 merged, adding experimental ty type checking to CI; detected type errors were retained as non-blocking notifications. | |
| #2370 ci: add experimental workflow using ty for type checking | charmcraft | merged | Merged PR #2370 (commit d06324ff) added an experimental ty type-checking workflow; CI passed and reported ty diagnostics were informational. | |
| #2957 style: suppress ty diagnostics that block CI | charmcraft | closed | Merged PR #2957 to fix CI `lint-ty` failures by suppressing 22 diagnostics and fixing a redundant cast. | |
| #910 style: fix ty error | craft-providers | merged | Merged in #910 via commit 30fc806, adding a targeted suppression for a ty false positive; all listed CI checks passed. | |
| #335 fix(lint): suppress ty | imagecraft | merged | Merged in PR #335 as c270f0a, adding targeted ty suppressions in two files so lint passes; all CI checks passed. | |
| #1698 style: ty | craft-parts | merged | Merged PR #1698 as commit 6b4db96f, enabling ty as a lint target and fixing its warnings across 37 files. | |
| #2961 style: suppress ty diagnostics that block CI | charmcraft | merged | Merged PR #2961 adds ty-specific lint ignores to match existing pyright/mypy configurations and removes a redundant cast in _expand_base, resolving CI blocks. | |
| #160 style: silence the ty job | craft-platforms | merged | Merged PR #160 (commit 469db5d) by lengau silenced the experimental ty typecheck CI job and, as a drive-by, removed the leftover unused yamllint pre-commit hook; all CI checks passed. | |
| #902 style: add type ignores | craft-providers | merged | Merged #902 added targeted ty type-ignore comments across three files, unblocking lint CI. |