fix(test): fix reactive plugin test if 'charm' tool is installed
Metadata
Current evaluation
Merged test-only fix making reactive plugin tests deterministic when the charm executable is installed, via PR #1326 and commit 4a573702.
Resolution: closed resolved
Reason: PR #1326 was approved by two reviewers and merged as commit 4a573702. It corrected the reactive plugin test for environments with the charm tool installed.
Evaluated by: mr-cal-bot
No scores available.
Issue body
No description provided.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged test-only fix making reactive plugin tests deterministic when the charm executable is installed, via PR #1326 and commit 4a573702. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged charmcraft#1326, fixing the reactive plugin test for environments where the charm tool is installed. The test-only change was approved by two reviewers. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix for the reactive plugin test that failed when the charm tool was installed. Approved by two reviewers with a +5/-1 line change. Resolves the test compatibility issue. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix for the reactive plugin test that failed when the charm tool was installed. The maintainer updated test configuration to handle the charm binary presence, ensuring reliable execution across environments. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2426 fix(test): fix the reactive charm spread test | charmcraft | merged | Merged in canonical/charmcraft#2426 via commit 7c33dd1b, applying a one-line fix to the reactive-charm spread test for CHARMCRAFT-641. | |
| #1235 tests: re-enable reactive charms test | charmcraft | merged | Merged PR canonical/charmcraft#1235 as commit bff2a6a3, re-enabling the reactive charms test with a one-line change after two approvals. | |
| #866 reactive_plugin: Fix charm tools version validation | charmcraft | merged | Merged PR #866 as commit 35ec089e (merge c40c30c2), replacing brittle charm-tools version parsing with JSON output and fixing #864. | |
| #613 plugins: reactive using charm tool (CRAFT-699) | charmcraft | merged | Merged PR #613 (merge commit 32c8650a, branch charm-tools-plugin) added the reactive charm plugin built on the charm tool, implementing CRAFT-699; 11 files, +499/-8. | |
| #610 many: add reactive charm plugin | charmcraft | closed | PR #610 (charm-tools-based reactive plugin) was closed unmerged on 2021-12-14 by sergiusens in favor of #613, which reimplemented the plugin on the charm tool (CRAFT-699) and merged as 32c8650a. | |
| #869 reactive_plugin: Properly check returncode from charm tool | charmcraft | merged | Merged in commit 7046f61d (merge ecce30c6), fixing reactive_plugin to validate the charm tool return code and always log it; resolves #804. | |
| #864 reactive plugin charm tools version validation code is britle | charmcraft | closed | Fixed by merged PR #866: commit 35ec089e updated reactive-plugin charm-tools validation to use JSON output; merge c40c30c2 closed #864. | |
| #804 The reactive plugin is not correctly checking if `charm` failed | charmcraft | closed | Fixed in merged PR #869 (commit 7046f61d), adding negative-return-code handling and return-code logging for both charm invocations. | |
| #1092 Some tests will require the charm plugin to be enabled | craft-application | open | Open, unlabelled issue: charmcraft PR #2722 may make craft-application tests depend on the charm plugin; the maintainer asks to remove that dependency, but no affected test or fix is identified. |