fix(test): fix reactive plugin test if 'charm' tool is installed
Metadata
Current evaluation
Merged a fix for the reactive plugin test that failed when the charm tool was installed. Approved by two reviewers with a +5/-1 line change. Resolves the test compatibility issue.
Suggested action: —
No scores available.
Issue body
No description provided.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix for the reactive plugin test that failed when the charm tool was installed. Approved by two reviewers with a +5/-1 line change. Resolves the test compatibility issue. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix for the reactive plugin test that failed when the charm tool was installed. The maintainer updated test configuration to handle the charm binary presence, ensuring reliable execution across environments. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a test fix for the reactive plugin that failed when the charm CLI tool was installed. The update ensures test stability regardless of charm availability. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2426 fix(test): fix the reactive charm spread test | charmcraft | merged | Merged a one-line fix for the reactive charm spread test. Approved by two reviewers and passed CI checks. Resolves CHARMCRAFT-641. | |
| #866 reactive_plugin: Fix charm tools version validation | charmcraft | merged | Merged fix for brittle charm-tools version validation in reactive_plugin, resolving issue #864. Approved by one reviewer, passed CI, and updated two files with 12 additions and 6 deletions. | |
| #1235 tests: re-enable reactive charms test | charmcraft | merged | Merged a one-line update to re-enable the reactive charms test. Approved by two reviewers with no comments or CI issues. Successfully integrated into the repository. | |
| #869 reactive_plugin: Properly check returncode from charm tool | charmcraft | merged | Merged to fix issue #804 by properly validating and logging the charm tool return code in reactive_plugin. Approved by one reviewer and integrated into the repository. | |
| #613 plugins: reactive using charm tool (CRAFT-699) | charmcraft | merged | Implemented reactive plugin functionality using the charm tool, addressing CRAFT-699. Merged after approval, modifying 11 files with 499 additions and 8 deletions. | |
| #2664 tests: add reproducer for reactive plugin missing .build.manifest (#872) | charmcraft | open | Adds a failing unit test reproducing #872 (reactive plugin omits .build.manifest from .charm artifacts) plus a fix copying the manifest into install_dir. Pending review, 0 reviewers, CI green; branch appears stale vs main (-310 lines). | |
| #2502 Fix missing build metadata in reactive charm artifacts | charmcraft | open | Adds .build.manifest preservation and charmtool_version to manifest.yaml for reactive charm builds. Fixes #872. Inactive 263 days, 0 reviewer approvals, several CI checks failing (snap-tests, Conventional Commits policy). | |
| #1198 tests: add charm library multiple versions update test | charmcraft | merged | Merged after approval, adding a test for updating charm library multiple versions. The change introduces 120 lines to address CRAFT-1916 and issue #1020, with zero unresolved review comments. | |
| #1666 fix: only keep metadata.yaml for reactive charms | charmcraft | merged | Merged to fix issue #1654 by restricting metadata.yaml retention to reactive charms only. Approved by two reviewers, passed CI, and modified six files (+101/-5). | |
| #804 The reactive plugin is not correctly checking if `charm` failed | charmcraft | closed | Incorrect charm return code validation in the reactive plugin was abandoned and closed without a fix. No pull requests or follow-up actions were recorded. |