Remove now unused functionalities (CRAFT-241).
Metadata
Current evaluation
Merged following approval by two reviewers. Removed unused functionalities referenced as CRAFT-241, altering two files with a net deletion of 229 lines. No unresolved review comments or CI checks were required.
Suggested action: —
No scores available.
Issue body
No description provided.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged following approval by two reviewers. Removed unused functionalities referenced as CRAFT-241, altering two files with a net deletion of 229 lines. No unresolved review comments or CI checks were required. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes removing unused functionalities tracked under CRAFT-241. The pull request was accepted and integrated into the main branch by maintainer facundobatista without additional discussion. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes removing unused functionalities tracked under CRAFT-241 by maintainer facundobatista. The pull request was accepted and integrated into the codebase without additional review. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #5205 refactor: use craft-platforms utilities | snapcraft | merged | Merged following approval by two reviewers. Refactored the codebase to use craft-platforms utilities, resolving CRAFT-3278 and closing #4993. Net reduction of 307 lines across 20 files. | |
| #1571 refactor: remove unused clean command implementation | charmcraft | merged | Merged refactoring that removes the unused custom clean command and associated regression tests, as the project now uses the craft-application clean command. Approved by three reviewers, passed CI, and modified four files. | |
| #1852 docs: remove how-to and tutorial sections | charmcraft | merged | Merged following approval by two reviewers and successful CI checks. The change removes how-to and tutorial documentation sections across three files, deleting 40 lines to resolve issue #1836 and ticket CRAFT-3261. | |
| #1078 chore!: remove deprecated APIs | craft-application | merged | Merged, removing 8 deprecated APIs from craft-applications to resolve issue #1063. Approved by two reviewers with all CI checks passing. Locally verified with snapcraft, reducing code by 345 lines across 11 files. | |
| #1572 refactor: remove unused extension command implementations | charmcraft | merged | Merged refactoring that removes unused extension command implementations. Tests were relocated to craft-application, with remote build fixes tracked in #1573. Approved by three reviewers, the change reduced 161 lines across six files. | |
| #635 Use all functionality from craft-cli (CRAFT-710). | charmcraft | merged | Merged after approval. Integrated all craft-cli functionality, netting a reduction of 1724 lines across 11 files. Resolves CRAFT-710. | |
| #1520 refactor: remove old "init" command implementation | charmcraft | merged | Merged a refactoring PR removing the old "init" command after the craft-application transition. Approved by two reviewers with passing CI, the change modified four files, adding one line and deleting 248. | |
| #1419 refactor: remove non craft-application analyze command | charmcraft | merged | Merged refactoring that removes a superfluous non-craft-application version of the analyze command. Approved by three reviewers with zero unresolved comments. Modified seven files, deleting 339 lines and adding 135. | |
| #797 Removed the --requirements option for build and pack commands (CRAFT-787). | charmcraft | merged | Merged after removing the --requirements option from build and pack commands, resolving issue #657. Approved by one reviewer. Changes span six files, deleting 315 lines and adding 16. | |
| #800 many: reword docstrings and code comments | charmcraft | merged | Merged following single reviewer approval. Reworded docstrings and code comments across five files to improve clarity, resolving CRAFT-697. The +10/-10 line change passed all CI checks. |