reactive_plugin: Properly check returncode from charm tool
Metadata
Current evaluation
Merged to fix issue #804 by properly validating and logging the charm tool return code in reactive_plugin. Approved by one reviewer and integrated into the repository.
Suggested action: —
No scores available.
Issue body
Also always log the returncode.
Fixes #804
Signed-off-by: Frode Nordahl <frode.nordahl@canonical.com>
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged to fix issue #804 by properly validating and logging the charm tool return code in reactive_plugin. Approved by one reviewer and integrated into the repository. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for issue #804 that properly checks and logs the charm tool return code in the reactive_plugin. Originally drafted to address test failures, the changes were reviewed and integrated. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Properly checks and logs the returncode from the charm tool in the reactive_plugin module, resolving issue #804. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #866 reactive_plugin: Fix charm tools version validation | charmcraft | merged | Merged fix for brittle charm-tools version validation in reactive_plugin, resolving issue #864. Approved by one reviewer, passed CI, and updated two files with 12 additions and 6 deletions. | |
| #1326 fix(test): fix reactive plugin test if 'charm' tool is installed | charmcraft | merged | Merged a fix for the reactive plugin test that failed when the charm tool was installed. Approved by two reviewers with a +5/-1 line change. Resolves the test compatibility issue. | |
| #804 The reactive plugin is not correctly checking if `charm` failed | charmcraft | closed | Incorrect charm return code validation in the reactive plugin was abandoned and closed without a fix. No pull requests or follow-up actions were recorded. | |
| #613 plugins: reactive using charm tool (CRAFT-699) | charmcraft | merged | Implemented reactive plugin functionality using the charm tool, addressing CRAFT-699. Merged after approval, modifying 11 files with 499 additions and 8 deletions. | |
| #864 reactive plugin charm tools version validation code is britle | charmcraft | closed | Closed without resolution. The reactive plugin's brittle charm-tools version validation was flagged for potential breakage. Suggestions to use JSON format or string matching were not implemented. No comments or fixes were applied, indicating the issue was abandoned. |