reactive_plugin: Properly check returncode from charm tool
Metadata
Current evaluation
Merged in commit 7046f61d (merge ecce30c6), fixing reactive_plugin to validate the charm tool return code and always log it; resolves #804.
Resolution: closed resolved
Reason: PR #869 was merged as commit 7046f61d via merge ecce30c6. It corrected reactive_plugin return-code handling and closed issue #804.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Also always log the returncode.
Fixes #804
Signed-off-by: Frode Nordahl <frode.nordahl@canonical.com>
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in commit 7046f61d (merge ecce30c6), fixing reactive_plugin to validate the charm tool return code and always log it; resolves #804. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR charmcraft#869 via commit 7046f61d (merge ecce30c6), fixing reactive_plugin to validate and always log charm tool return codes; fixes #804. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #869 (merge ecce30c6, commit 7046f61d), fixing reactive_plugin to propagate charm tool failures and always log return codes. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #869 (commit 7046f61d, merge ecce30c6) by fnordahl, fixing the reactive_plugin to properly check the `charm` tool's return code and always log it; closes issue #804. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #869 with commit 7046f61d (merge ecce30c6), fixing reactive_plugin to check the charm tool's return code and always log it, resolving #804. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to fix issue #804 by properly validating and logging the charm tool return code in reactive_plugin. Approved by one reviewer and integrated into the repository. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for issue #804 that properly checks and logs the charm tool return code in the reactive_plugin. Originally drafted to address test failures, the changes were reviewed and integrated. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/charmcraft#804
(confidence 100%)
PR #869 explicitly fixes the reactive plugin's incorrect charm failure detection.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #804 The reactive plugin is not correctly checking if `charm` failed | charmcraft | closed | Fixed in merged PR #869 (commit 7046f61d), adding negative-return-code handling and return-code logging for both charm invocations. | |
| #866 reactive_plugin: Fix charm tools version validation | charmcraft | merged | Merged PR #866 as commit 35ec089e (merge c40c30c2), replacing brittle charm-tools version parsing with JSON output and fixing #864. | |
| #864 reactive plugin charm tools version validation code is britle | charmcraft | closed | Fixed by merged PR #866: commit 35ec089e updated reactive-plugin charm-tools validation to use JSON output; merge c40c30c2 closed #864. | |
| #1326 fix(test): fix reactive plugin test if 'charm' tool is installed | charmcraft | merged | Merged test-only fix making reactive plugin tests deterministic when the charm executable is installed, via PR #1326 and commit 4a573702. | |
| #613 plugins: reactive using charm tool (CRAFT-699) | charmcraft | merged | Merged PR #613 (merge commit 32c8650a, branch charm-tools-plugin) added the reactive charm plugin built on the charm tool, implementing CRAFT-699; 11 files, +499/-8. | |
| #924 reactive plugin: call `charm build` with `-v` | charmcraft | closed | Fixed by merged PR #2021 (commit 7129d57e): the reactive plugin adds --verbose to charm build unless an explicit verbosity or log level is supplied. |