reactive_plugin: Fix charm tools version validation
Metadata
Current evaluation
Merged PR #866 as commit 35ec089e (merge c40c30c2), replacing brittle charm-tools version parsing with JSON output and fixing #864.
Resolution: closed resolved
Reason: PR #866 was approved and merged into main via merge commit c40c30c2. Its commit 35ec089e changed the reactive plugin to use charm-tools' JSON version output, resolving #864.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The current charm-tools version validation code is britle and may soon break as charm-tools evolves.
Fixes #864
Signed-off-by: Frode Nordahl <frode.nordahl@canonical.com>
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #866 as commit 35ec089e (merge c40c30c2), replacing brittle charm-tools version parsing with JSON output and fixing #864. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in #866 via commit 35ec089e, replacing brittle charm-tools version validation in reactive_plugin and fixing #864. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix for brittle charm-tools version validation in reactive_plugin, resolving issue #864. Approved by one reviewer, passed CI, and updated two files with 12 additions and 6 deletions. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged update fixing brittle charm-tools version validation in reactive_plugin, resolving issue #864. Ensures compatibility as charm-tools evolves. |
Update history
No update history recorded yet.
Related work
-
Caused By:
canonical/charmcraft#864
(confidence 100%)
The version-validation bug report explicitly prompted and was fixed by PR #866.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #864 reactive plugin charm tools version validation code is britle | charmcraft | closed | Fixed by merged PR #866: commit 35ec089e updated reactive-plugin charm-tools validation to use JSON output; merge c40c30c2 closed #864. | |
| #869 reactive_plugin: Properly check returncode from charm tool | charmcraft | merged | Merged in commit 7046f61d (merge ecce30c6), fixing reactive_plugin to validate the charm tool return code and always log it; resolves #804. | |
| #613 plugins: reactive using charm tool (CRAFT-699) | charmcraft | merged | Merged PR #613 (merge commit 32c8650a, branch charm-tools-plugin) added the reactive charm plugin built on the charm tool, implementing CRAFT-699; 11 files, +499/-8. | |
| #610 many: add reactive charm plugin | charmcraft | closed | PR #610 (charm-tools-based reactive plugin) was closed unmerged on 2021-12-14 by sergiusens in favor of #613, which reimplemented the plugin on the charm tool (CRAFT-699) and merged as 32c8650a. | |
| #804 The reactive plugin is not correctly checking if `charm` failed | charmcraft | closed | Fixed in merged PR #869 (commit 7046f61d), adding negative-return-code handling and return-code logging for both charm invocations. | |
| #1326 fix(test): fix reactive plugin test if 'charm' tool is installed | charmcraft | merged | Merged test-only fix making reactive plugin tests deterministic when the charm executable is installed, via PR #1326 and commit 4a573702. | |
| #924 reactive plugin: call `charm build` with `-v` | charmcraft | closed | Fixed by merged PR #2021 (commit 7129d57e): the reactive plugin adds --verbose to charm build unless an explicit verbosity or log level is supplied. |