reactive_plugin: Fix charm tools version validation
Metadata
Current evaluation
Merged fix for brittle charm-tools version validation in reactive_plugin, resolving issue #864. Approved by one reviewer, passed CI, and updated two files with 12 additions and 6 deletions.
Suggested action: —
No scores available.
Issue body
The current charm-tools version validation code is britle and may soon break as charm-tools evolves.
Fixes #864
Signed-off-by: Frode Nordahl <frode.nordahl@canonical.com>
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged fix for brittle charm-tools version validation in reactive_plugin, resolving issue #864. Approved by one reviewer, passed CI, and updated two files with 12 additions and 6 deletions. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged update fixing brittle charm-tools version validation in reactive_plugin, resolving issue #864. Ensures compatibility as charm-tools evolves. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix for brittle charm-tools version validation in the reactive_plugin, resolving issue #864. The update replaces fragile parsing logic to maintain compatibility with future charm-tools releases. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1326 fix(test): fix reactive plugin test if 'charm' tool is installed | charmcraft | merged | Merged a fix for the reactive plugin test that failed when the charm tool was installed. Approved by two reviewers with a +5/-1 line change. Resolves the test compatibility issue. | |
| #869 reactive_plugin: Properly check returncode from charm tool | charmcraft | merged | Merged to fix issue #804 by properly validating and logging the charm tool return code in reactive_plugin. Approved by one reviewer and integrated into the repository. | |
| #613 plugins: reactive using charm tool (CRAFT-699) | charmcraft | merged | Implemented reactive plugin functionality using the charm tool, addressing CRAFT-699. Merged after approval, modifying 11 files with 499 additions and 8 deletions. | |
| #864 reactive plugin charm tools version validation code is britle | charmcraft | closed | Closed without resolution. The reactive plugin's brittle charm-tools version validation was flagged for potential breakage. Suggestions to use JSON format or string matching were not implemented. No comments or fixes were applied, indicating the issue was abandoned. | |
| #610 many: add reactive charm plugin | charmcraft | closed | Closed and superseded by pull request #613. The reactive charm plugin was replaced rather than merged. | |
| #804 The reactive plugin is not correctly checking if `charm` failed | charmcraft | closed | Incorrect charm return code validation in the reactive plugin was abandoned and closed without a fix. No pull requests or follow-up actions were recorded. | |
| #2426 fix(test): fix the reactive charm spread test | charmcraft | merged | Merged a one-line fix for the reactive charm spread test. Approved by two reviewers and passed CI checks. Resolves CHARMCRAFT-641. | |
| #2502 Fix missing build metadata in reactive charm artifacts | charmcraft | open | Adds .build.manifest preservation and charmtool_version to manifest.yaml for reactive charm builds. Fixes #872. Inactive 263 days, 0 reviewer approvals, several CI checks failing (snap-tests, Conventional Commits policy). | |
| #777 Do not modify the charm's project when packing using the reactive plugin (CRAFT-928). | charmcraft | merged | Merged to resolve issue #693. The change prevents the reactive plugin from modifying the charm's project during packing. Approved by one reviewer with zero unresolved comments. Two files modified, netting a 21-line reduction. |