The reactive plugin is not correctly checking if `charm` failed
Metadata
Current evaluation
Incorrect charm return code validation in the reactive plugin was abandoned and closed without a fix. No pull requests or follow-up actions were recorded.
Suggested action: —
No scores available.
Issue body
The `charm` tool used by the reactive plugin has a complex return code specification.
While Charmcraft is correctly checking that the return code >= 200 is an error, it's failing to verify that <0 is also an error.
Furthermore, it should log in debug the return code from the execution (no matter which one it is).
All said above applies for both `charm` calls.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen3.6-35b-a3b-mtp-q6 | — | — | Incorrect charm return code validation in the reactive plugin was abandoned and closed without a fix. No pull requests or follow-up actions were recorded. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without a linked pull request or resolution, indicating the issue was abandoned. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Reactive plugin charm error handling and debug logging gaps were closed without resolution. No fix or pull request was submitted, indicating the report was abandoned. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed without implementation. The reactive plugin remains unpatched, failing to treat negative charm return codes as errors and lacking debug logging. No fix was submitted. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #610 many: add reactive charm plugin | charmcraft | closed | Closed and superseded by pull request #613. The reactive charm plugin was replaced rather than merged. | |
| #869 reactive_plugin: Properly check returncode from charm tool | charmcraft | merged | Merged to fix issue #804 by properly validating and logging the charm tool return code in reactive_plugin. Approved by one reviewer and integrated into the repository. | |
| #864 reactive plugin charm tools version validation code is britle | charmcraft | closed | Closed without resolution. The reactive plugin's brittle charm-tools version validation was flagged for potential breakage. Suggestions to use JSON format or string matching were not implemented. No comments or fixes were applied, indicating the issue was abandoned. | |
| #866 reactive_plugin: Fix charm tools version validation | charmcraft | merged | Merged fix for brittle charm-tools version validation in reactive_plugin, resolving issue #864. Approved by one reviewer, passed CI, and updated two files with 12 additions and 6 deletions. | |
| #870 reactive_plugin: Inappropriate environment used when calling out to `charm` command | charmcraft | closed | Author retracted the report after verifying the environment was already properly sanitized to exclude the charmcraft snap's Python dependencies. No code changes were required, and the issue was closed as invalid. | |
| #924 reactive plugin: call `charm build` with `-v` | charmcraft | closed | Closed after triage and internal ticket creation. Implementation guidance was provided to pass verbose flags to charm calls when verbosity is trace or debug. No fix or pull request was merged. |