reactive plugin charm tools version validation code is britle
Metadata
Current evaluation
Closed without resolution. The reactive plugin's brittle charm-tools version validation was flagged for potential breakage. Suggestions to use JSON format or string matching were not implemented. No comments or fixes were applied, indicating the issue was abandoned.
Suggested action: —
No scores available.
Issue body
The charm tools may soon remove the now redundant legacy charm store code, when that happens the output from the version command may no longer use the format expected here:
https://github.com/canonical/charmcraft/blob/dbf82a0fbaa6633248bb213d3943603c1e7c50a6/charmcraft/reactive_plugin.py#L64-L65
I would recommend either using the `--format json` argument or looking for the `charm-tools` string in the output rather than relying on there being a newline character there.
Ref: https://github.com/juju/charm-tools/blob/17812f0e00ad634f8440053d43d1a5370a71fa50/charmtools/version.py#L15-L25
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed without resolution. The reactive plugin's brittle charm-tools version validation was flagged for potential breakage. Suggestions to use JSON format or string matching were not implemented. No comments or fixes were applied, indicating the issue was abandoned. | |
| qwen/qwen3.6-35b-a3b | — | — | Reactive plugin version validation relied on a fragile charm-tools output format. Recommended using JSON format or string matching. Closed without comments or resolution, indicating the report was abandoned. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed without action. The report flagged brittle version validation in the reactive plugin relying on a specific charm tools output format. Recommended using JSON formatting or string matching instead. No resolution was applied. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Abandoned due to inactivity. The reactive plugin's brittle version validation, which relies on parsing newline characters from charm-tools output, was never updated. No fix or alternative implementation was merged. |
Update history
No update history recorded yet.
Related issues
No related issues found above the similarity threshold.