← Back to issue list

chore: skip typing checkers in "_version.py"

View original Github issue

Metadata

Project
craft-application
Number
#82
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #82 as commit 1ec888d8, excluding setuptools_scm-generated _version.py from mypy and pyright to avoid false-positive typing errors.

Resolution: closed resolved

Reason: PR #82 was merged into main as commit 1ec888d8, adding type-checker exclusions for the autogenerated _version.py module.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The _version module is autogenerated by setuptools_scm. The newest version of the package adds type annotations in a way that make both mypy (in version 8.0.1) and pyright (in version 8.0.2) complain. Since it's auto-generated simple code, skip that module from those linters. - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #82 as commit 1ec888d8, excluding setuptools_scm-generated _version.py from mypy and pyright to avoid false-positive typing errors.
stealth/space-bunny-alpha — closed resolved Merged PR #82 in commit 1ec888d8, excluding setuptools_scm-generated craft_application/_version.py from mypy and pyright.
stealth/space-bunny-alpha — closed resolved Merged PR #82 excluded the setuptools_scm-generated _version.py from mypy and pyright, resolving their annotation warnings.
qwen/qwen3.6-35b-a3b — — Merged. Skips type checking for the auto-generated _version.py file, resolving mypy and pyright complaints from newer setuptools_scm versions. Approved by two reviewers, passed CI, and integrated with zero coverage impact.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#128 chore: skip typing checkers in "_version.py" starbase merged Merged PR #128 as commit edf7d5a, excluding setuptools_scm-generated _version.py from mypy and Pyright checks.
95%
#404 chore: skip typing checkers in "_version.py" craft-providers merged Merged PR #404 via commit 371d77c excludes _version.py from typing checks and explicitly excludes hidden and cache paths once exclusion is configured.
84%
#158 chore: fix pyright error craft-archives merged Merged PR #158 as commit fc48bed, fixing a Pyright error with a one-line deletion despite a failing minimum-dependencies job.
75%
#4406 chore: ignore types snapcraft merged Merged PR #4406 as feb701d30, suppressing pkg_resources type errors from pyright 1.1.332 and unblocking PEP 518 support in #4087.
75%
#158 chore: use new mypy config `extra_checks` starbase merged Merged PR #158 as commit 86b7568, replacing mypy's deprecated strict_concatenate option with extra_checks.
74%
#181 chore(lint): add new typing dependencies and fix pyright issues craft-cli merged PR #181 merged into main as commit d34fdd6 (Sep 2023): added typing stub dependencies and fixed the resulting Pyright errors, a 1-file, +6/-1 lint/tooling change.
74%
#457 chore: remove unused mypy and pyright configuration imagecraft merged Merged PR #457 (maintainer lengau) deleted unused [tool.mypy]/[[tool.mypy.overrides]] and [tool.pyright] config plus the mypy[reports] dep and uv.lock entries (-229 lines), cleaning up leftovers after the ty migration.
74%
#784 chore(deps): update bugfixes craft-parts merged Merged PR #784 in commit 764786e7, updating pyright 1.1.358→1.1.372 and tox-gh 1.3→1.3.2.
72%
#193 chore(deps): update development dependencies (non-major) starbase merged Merged PR #193 in commit c9c4de0, updating types/mypy from ~=1.8.0 to ~=1.9.0 and types/pyright from 1.1.352 to 1.1.355.
72%
#122 chore: eliminate pydantic warnings craft-archives merged Merged PR #122 eliminated Pydantic warnings, landing as commit 00b9b3b after approval by two reviewers.
72%