← Back to issue list

chore: skip typing checkers in "_version.py"

View original Github issue

Metadata

Project
craft-application
Number
#82
Type
pull request
State
merged
Author
tigarmo
Labels
Created
Updated
Closed

Current evaluation

Merged. Skips type checking for the auto-generated _version.py file, resolving mypy and pyright complaints from newer setuptools_scm versions. Approved by two reviewers, passed CI, and integrated with zero coverage impact.

Suggested action:

No scores available.

Issue body

The _version module is autogenerated by setuptools_scm. The newest version of the package adds type annotations in a way that make both mypy (in version 8.0.1) and pyright (in version 8.0.2) complain. Since it's auto-generated simple code, skip that module from those linters. - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged. Skips type checking for the auto-generated _version.py file, resolving mypy and pyright complaints from newer setuptools_scm versions. Approved by two reviewers, passed CI, and integrated with zero coverage impact.
qwen3.6-35b-a3b-mtp-q6 Merged into main. Configures mypy and pyright to skip type checking for the auto-generated _version.py file, preventing false positives from setuptools_scm's type annotations. Coverage remains unchanged.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#128 chore: skip typing checkers in "_version.py" starbase merged Merged a chore to skip typing checkers in _version.py. Approved by two reviewers and passed all CI checks. The change adds seven lines with zero coverage impact, serving as an upstream dependency for related repositories.
87%
#181 chore(lint): add new typing dependencies and fix pyright issues craft-cli merged Merged into main following approval. The update adds typing dependencies and resolves pyright type errors across a single file. All CI checks passed, and code coverage remained stable during integration.
75%
#193 chore(deps): update development dependencies (non-major) starbase merged Merged automated dependency updates for mypy to 1.9.0 and pyright to 1.1.355. Approved by one reviewer, passed CI checks, and merged with a two-line change in a single file.
74%
#158 chore: fix pyright error craft-archives merged Merged a maintainer's pull request that resolved a pyright error by removing a single line. Approved by three reviewers and passed CI checks before integration.
74%
#198 chore(deps): update bugfixes craft-store merged Merged automated dependency updates for coverage, mypy, pyright, and pytest to latest patch versions. Approved by two reviewers, passed CI, and auto-merged via Renovate bot configuration.
74%
#117 chore: fix pyright config craft-store merged Merged after two reviewers approved and CI checks passed. The pull request updates the pyright configuration across two files, adding 24 lines and removing 16 to resolve type-checking setup issues.
74%
#4696 chore(deps): update development dependencies (non-major) snapcraft merged Merged automated updates for Python type stubs via Renovate. Approved after passing CI and coverage checks. Maintainer deferred merge to address unrelated spread test failures before applying.
72%
#122 chore: eliminate pydantic warnings craft-archives merged Merged after two approvals and passing CI. Refactored three files to eliminate pydantic deprecation warnings, adding 24 lines and removing 15.
72%
#161 chore(deps): update development dependencies (non-major) craft-application merged Merged automated non-major dependency updates for coverage, pytest-check, yamllint, and mypy types. Approved by two reviewers, passed CI checks, and maintained 99.28% code coverage.
72%
#45 chore(deps): update development dependencies (non-major) craft-application merged Merged automated non-major updates for dev dependencies pytest-check, black, and pyright. Approved by reviewers, passed CI, and merged with zero coverage impact.
72%