← Back to issue list

style: ty

View original Github issue

Metadata

Project
craft-cli
Number
#421
Type
pull request
State
merged
Author
mr-cal
Labels
PR: Rebase
Created
Updated
Closed

Current evaluation

Merged to update the ty tool, unblocking work on snapcraft issue #5673. Approved by two reviewers with all CI checks passing. Changes affect two files (+10/-5 lines) and create follow-up issue #420.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? --- Updates for `ty` to unblock work on https://github.com/canonical/snapcraft/issues/5673. Creates #420

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged to update the ty tool, unblocking work on snapcraft issue #5673. Approved by two reviewers with all CI checks passing. Changes affect two files (+10/-5 lines) and create follow-up issue #420.
qwen3.6-35b-a3b-mtp-q6 Updates for ty to unblock work on issue 5673. Merged after passing lint and test checks, enabling downstream development.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2726 style: switch type checking to ty charmcraft merged Merged after switching type checking to the ty tool. Resolves existing ty issues, approved by two reviewers, passed CI checks, and modified 40 files.
81%
#6280 style: ty 0.0.44 snapcraft merged Merged update to ty version 0.0.44. Approved by two reviewers and passed core CI checks. Unrelated lint failures and integration timeouts did not block the merge.
80%
#1698 style: ty craft-parts merged Enables ty as a lint target and fixes its warnings across 37 files (+69/-65). Fresh maintainer-authored PR, CI passing with some slow-test jobs pending, awaiting first review.
79%
#6247 style: go all-in on ty snapcraft merged Merged after approval by two reviewers. The change adopts the ty linter for comprehensive typo detection, resolving issue #6007. It updated 47 files, reducing 370 lines and adding 139.
78%
#242 style: fix ty linting error craft-platforms merged Merged a single-file change fixing a ty linting error. Approved by one reviewer and passed CI checks. The one-line modification resolves the style violation.
77%
#1084 style: replace mypy and pyright with ty craft-application merged Merged a squashed pull request replacing mypy and pyright with ty for type checking across 70 files. Approved by two reviewers with all CI checks passing, the change streamlines the linting configuration for craft-app 7.
76%
#1267 style(type): make `ty` happy with the `craft_parts` directory craft-parts merged Merged after two approvals and passing CI. Applied style and type fixes to the craft_parts directory to satisfy the ty linter, modifying five files with minor adjustments.
75%
#6015 style: fix additional ty warnings snapcraft merged Merged pull request resolving additional ty linter warnings for unsupported operators and non-subscriptable types. Approved by two reviewers, passed CI checks, and implemented a minimal two-file fix related to #5970.
74%
#1361 style: suppress ty warning rockcraft merged Merged a one-line change to suppress a ty 0.0.79 false positive on user_files["shadow"]. Approved by one reviewer and passed CI checks.
74%
#2486 docs: revise issue templates charmcraft merged Issue templates revised to align with Snapcraft and merged. Approved by two reviewers with zero unresolved comments. Integrated despite some failing CI checks. Type-check warnings were informational only.
74%