← Back to issue list

style: ty

View original Github issue

Metadata

Project
craft-cli
Number
#421
Type
pull request
State
merged
Author
mr-cal
Labels
PR: Rebase
Created
Updated
Closed

Current evaluation

Merged PR #421 as 5c6d127, updating ty to unblock snapcraft#5673; it opened #420 to remove mypy and pyright, later resolved by #479.

Resolution: closed resolved

Reason: PR #421 merged successfully as commit 5c6d127 with all CI checks passing. It updated ty to unblock canonical/snapcraft#5673 and created #420, which was resolved by merged PR #479 (0e49c01).

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? --- Updates for `ty` to unblock work on https://github.com/canonical/snapcraft/issues/5673. Creates #420

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #421 as 5c6d127, updating ty to unblock snapcraft#5673; it opened #420 to remove mypy and pyright, later resolved by #479.
stealth/space-bunny-alpha — closed resolved Merged #421 as commit 5c6d127, updating style tooling for ty to unblock canonical/snapcraft#5673. Follow-up craft-cli#420 was created.
stealth/space-bunny-alpha — closed resolved Merged canonical/craft-cli#421 (5c6d127) updated ty to unblock snapcraft#5673; all CI checks passed and follow-up #420 was created.
qwen/qwen3.6-35b-a3b — — Merged to update the ty tool, unblocking work on snapcraft issue #5673. Approved by two reviewers with all CI checks passing. Changes affect two files (+10/-5 lines) and create follow-up issue #420.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-cli#420 (confidence 100%)

    Created by PR #421 to remove mypy and pyright after adopting ty.

  • Related To: canonical/snapcraft#5673 (confidence 100%)

    Snapcraft work that this ty update was intended to unblock.

  • Related To: canonical/craft-cli#479 (confidence 98%)

    Merged follow-up that completed #420 by dropping mypy and pyright.

Related issues

Issue Project State Summary Similarity
#6247 style: go all-in on ty snapcraft merged Merged PR #6247 (commit 534d7dce7) replaced mypy and pyright with ty, removed obsolete suppressions, and resolved #6007.
80%
#1084 style: replace mypy and pyright with ty craft-application merged Merged PR #1084 as squash commit 345bd5d9, replacing mypy and pyright with ty and updating lint configuration for craft-app 7.
80%
#223 style: switch from mypy+pyright to ty craft-platforms merged Merged PR #223 by lengau replaced mypy and pyright with the ty type checker in craft-platforms, dropping ~274 lines across 3 files; approved by 2 reviewers with all lint/test CI green.
77%
#253 style: drop mypy, pyright craft-archives merged Merged PR #253 (commit 1949f53) drops mypy and pyright in favor of ty; lint and test CI checks passed.
75%
#901 Remove mypy and pyright craft-providers open Drop mypy/pyright in favour of ty. Makefile, CI and pyproject already use ty only; common.mk still defines lint-mypy, lint-pyright, install-pyright, and stale .gitignore/type: ignore entries remain. Mirrors snapcraft#6007 and craft-cli#420, both completed.
75%
#152 style: remove mypy and pyright to go all-in on ty debcraft merged Merged canonical/debcraft#152, removing mypy and pyright and standardizing type checking on Astral ty after approval by two reviewers.
75%
#1706 style: drop mypy, pyright craft-parts merged Merged PR #1706 in commit 770e2130, replacing mypy and pyright with ty; redundant runtime type-check cleanup was deferred to #1707.
74%
#215 style: drop mypy, pyright craft-grammar merged Merged #215 in commit 19a38b7, dropping mypy and pyright in favor of ty across six files (+4/-481).
74%
#2961 style: suppress ty diagnostics that block CI charmcraft merged Merged PR #2961 adds ty-specific lint ignores to match existing pyright/mypy configurations and removes a redundant cast in _expand_base, resolving CI blocks.
74%
#420 Remove mypy and pyright craft-cli closed Removed mypy and pyright in favor of ty through merged PR #479 (commit 0e49c01).
74%