← Back to issue list

style: remove mypy and pyright to go all-in on ty

View original Github issue

Metadata

Project
debcraft
Number
#152
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged canonical/debcraft#152, removing mypy and pyright and standardizing type checking on Astral ty after approval by two reviewers.

Resolution: closed resolved

Reason: PR #152 was merged, completing the migration to Astral ty. Its lint and test checks passed, and the change received two approvals.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged canonical/debcraft#152, removing mypy and pyright and standardizing type checking on Astral ty after approval by two reviewers.
stealth/space-bunny-alpha — closed resolved Merged canonical/debcraft#152 removes mypy and pyright in favor of ty, changing 12 files (+20/-174) and receiving two approvals.
stealth/space-bunny-alpha — closed resolved Merged PR #152 (commit 56b70aa) removed mypy and pyright, standardizing linting on ty across 12 files.
stealth/space-bunny-alpha — closed resolved Merged PR #152 removed mypy and pyright, standardizing type checking on ty across 12 files (+20/-174); two reviewers approved the change.
qwen/qwen3.6-35b-a3b — — Merged changes removing mypy and pyright type checkers to exclusively use the ty tool. Approved by two reviewers, passed CI checks, and modified 12 files with a net reduction of 154 lines.
qwen3.6-35b-a3b-mtp-q6 — — Merged a pull request removing mypy and pyright, consolidating type checking exclusively to ty. The change was integrated without additional discussion.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#207 style: disable pyright in favour of ty craft-platforms merged Merged as f287a56, replacing the active Pyright configuration with Astral’s ty type checker.
81%
#1207 style: replace mypy and pyright with ty rockcraft merged Merged PR #1207 (commit 5d9356c1), replacing mypy and pyright type checking with Astral ty and updating lint configuration across 43 files.
81%
#421 style: drop mypy, pyright craft-store merged Merged #421 to replace mypy and pyright with Astral ty; the lint pipeline now runs lint-ty.
80%
#223 style: switch from mypy+pyright to ty craft-platforms merged Merged PR #223 by lengau replaced mypy and pyright with the ty type checker in craft-platforms, dropping ~274 lines across 3 files; approved by 2 reviewers with all lint/test CI green.
77%
#1007 style: drop mypy, pyright craft-providers merged Merged into main as commit 232143d, replacing mypy and pyright with ty and removing obsolete type-checker tooling.
77%
#6007 Remove mypy and pyright snapcraft closed Request to drop mypy and pyright for ty was resolved by merged PR #6247 ("style: go all-in on ty", commit 534d7dce7), which replaced both checkers with ty and removed the unused-ignore-comment suppression.
76%
#6247 style: go all-in on ty snapcraft merged Merged PR #6247 (commit 534d7dce7) replaced mypy and pyright with ty, removed obsolete suppressions, and resolved #6007.
75%
#1706 style: drop mypy, pyright craft-parts merged Merged PR #1706 in commit 770e2130, replacing mypy and pyright with ty; redundant runtime type-check cleanup was deferred to #1707.
75%
#1084 style: replace mypy and pyright with ty craft-application merged Merged PR #1084 as squash commit 345bd5d9, replacing mypy and pyright with ty and updating lint configuration for craft-app 7.
75%
#420 Remove mypy and pyright craft-cli closed Removed mypy and pyright in favor of ty through merged PR #479 (commit 0e49c01).
75%