← Back to issue list

style: drop mypy, pyright

View original Github issue

Metadata

Project
craft-parts
Number
#1706
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1706 in commit 770e2130, replacing mypy and pyright with ty; redundant runtime type-check cleanup was deferred to #1707.

Resolution: closed resolved

Reason: PR #1706 was approved and merged as commit 770e2130, with all CI checks passing. It completed the type-checker migration while explicitly moving unrelated isinstance-check cleanup to issue #1707.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? --- Drops mypy and pyright in favor of ty.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1706 in commit 770e2130, replacing mypy and pyright with ty; redundant runtime type-check cleanup was deferred to #1707.
stealth/space-bunny-alpha — closed resolved Merged PR #1706 (commit 770e2130) removed mypy and pyright, replacing them with ty across 88 files; redundant isinstance-check cleanup was deferred.
qwen3.6-35b-a3b-mtp-q6 — — Merged after approval and passing CI. Replaced mypy and pyright with ty for type checking across 88 files. Redundant isinstance checks were deferred to a separate issue.

Update history

Date Change
updated
updated
updated
updated
updated
updated
created

Related work

  • Related To: canonical/craft-parts#1707 (confidence 100%)

    Open follow-up created by the maintainer to remove redundant runtime isinstance checks deferred from PR #1706.

  • Related To: canonical/craft-parts#1698 (confidence 98%)

    Merged PR #1698 introduced ty and resolved its warnings, directly enabling the subsequent migration.

Related issues

Issue Project State Summary Similarity
#1007 style: drop mypy, pyright craft-providers merged Merged into main as commit 232143d, replacing mypy and pyright with ty and removing obsolete type-checker tooling.
88%
#253 style: drop mypy, pyright craft-archives merged Merged PR #253 (commit 1949f53) drops mypy and pyright in favor of ty; lint and test CI checks passed.
88%
#479 style: drop mypy, pyright craft-cli merged Merged PR #479 (commit 0e49c01) dropped the mypy and pyright type checkers in favour of ty, removing ~340 lines of type-checker config and ignore directives across 8 files; all CI checks passed.
86%
#215 style: drop mypy, pyright craft-grammar merged Merged #215 in commit 19a38b7, dropping mypy and pyright in favor of ty across six files (+4/-481).
85%
#420 Remove mypy and pyright craft-cli closed Removed mypy and pyright in favor of ty through merged PR #479 (commit 0e49c01).
81%
#6247 style: go all-in on ty snapcraft merged Merged PR #6247 (commit 534d7dce7) replaced mypy and pyright with ty, removed obsolete suppressions, and resolved #6007.
81%
#6007 Remove mypy and pyright snapcraft closed Request to drop mypy and pyright for ty was resolved by merged PR #6247 ("style: go all-in on ty", commit 534d7dce7), which replaced both checkers with ty and removed the unused-ignore-comment suppression.
80%
#1207 style: replace mypy and pyright with ty rockcraft merged Merged PR #1207 (commit 5d9356c1), replacing mypy and pyright type checking with Astral ty and updating lint configuration across 43 files.
78%
#421 style: drop mypy, pyright craft-store merged Merged #421 to replace mypy and pyright with Astral ty; the lint pipeline now runs lint-ty.
78%
#223 style: switch from mypy+pyright to ty craft-platforms merged Merged PR #223 by lengau replaced mypy and pyright with the ty type checker in craft-platforms, dropping ~274 lines across 3 files; approved by 2 reviewers with all lint/test CI green.
77%