← Back to issue list

style: go all-in on ty

View original Github issue

Metadata

Project
snapcraft
Number
#6247
Type
pull request
State
merged
Author
bepri
Labels
Created
Updated
Closed

Current evaluation

Merged after approval by two reviewers. The change adopts the ty linter for comprehensive typo detection, resolving issue #6007. It updated 47 files, reducing 370 lines and adding 139.

Suggested action:

No scores available.

Issue body

Fixes #6007 --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after approval by two reviewers. The change adopts the ty linter for comprehensive typo detection, resolving issue #6007. It updated 47 files, reducing 370 lines and adding 139.
qwen3.6-35b-a3b-mtp-q6 Merged a style update to fully integrate the ty typo-checking tool, resolving issue #6007. The maintainer applied comprehensive typo fixes across the codebase and documentation, enforcing consistent linting standards.
qwen3.6-35b-a3b-mtp-q6 Merged a style update adopting the ty linter across the codebase, resolving issue #6007. The maintainer applied the changes after passing lint and test checks, standardizing project formatting.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2726 style: switch type checking to ty charmcraft merged Merged after switching type checking to the ty tool. Resolves existing ty issues, approved by two reviewers, passed CI checks, and modified 40 files.
80%
#446 style(lint): fix typing for ty update craft-cli merged Merged a maintainer pull request fixing typing for the ty linter update. Approved by one reviewer, the change adjusted three files with minor style modifications. CI checks passed and the branch was successfully integrated.
79%
#242 style: fix ty linting error craft-platforms merged Merged a single-file change fixing a ty linting error. Approved by one reviewer and passed CI checks. The one-line modification resolves the style violation.
79%
#6280 style: ty 0.0.44 snapcraft merged Merged update to ty version 0.0.44. Approved by two reviewers and passed core CI checks. Unrelated lint failures and integration timeouts did not block the merge.
79%
#1698 style: ty craft-parts merged Enables ty as a lint target and fixes its warnings across 37 files (+69/-65). Fresh maintainer-authored PR, CI passing with some slow-test jobs pending, awaiting first review.
78%
#421 style: ty craft-cli merged Merged to update the ty tool, unblocking work on snapcraft issue #5673. Approved by two reviewers with all CI checks passing. Changes affect two files (+10/-5 lines) and create follow-up issue #420.
78%
#152 style: remove mypy and pyright to go all-in on ty debcraft merged Merged changes removing mypy and pyright type checkers to exclusively use the ty tool. Approved by two reviewers, passed CI checks, and modified 12 files with a net reduction of 154 lines.
78%
#407 style(types): enable type checking with ty craft-cli merged Merged pull request enabling type checking with ty. Approved by two reviewers with all CI checks passing. Changes add 21 lines and remove 3 across three files, successfully implementing the requested type checking improvements.
78%
#6015 style: fix additional ty warnings snapcraft merged Merged pull request resolving additional ty linter warnings for unsupported operators and non-subscriptable types. Approved by two reviewers, passed CI checks, and implemented a minimal two-file fix related to #5970.
77%
#223 style: switch from mypy+pyright to ty craft-platforms merged Merged after approval by two reviewers and passing CI checks. Replaces mypy and pyright with the ty type checker across three files, reducing 266 lines.
76%