← Back to issue list

style: go all-in on ty

View original Github issue

Metadata

Project
snapcraft
Number
#6247
Type
pull request
State
merged
Author
bepri
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #6247 (commit 534d7dce7) replaced mypy and pyright with ty, removed obsolete suppressions, and resolved #6007.

Resolution: closed resolved

Reason: PR #6247 was merged as commit 534d7dce7 and explicitly states “Fixes #6007.” The merged change replaced mypy and pyright with ty and removed obsolete suppressions.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Fixes #6007 --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #6247 (commit 534d7dce7) replaced mypy and pyright with ty, removed obsolete suppressions, and resolved #6007.
stealth/space-bunny-alpha — closed resolved Merged PR #6247 replaced mypy and pyright with ty, removed obsolete suppressions, and fixed #6007 in commit 534d7dce7.
stealth/space-bunny-alpha — closed resolved Merged PR #6247 replaced mypy and pyright with ty, removing obsolete suppressions and resolving #6007.
qwen/qwen3.6-35b-a3b — — Merged after approval by two reviewers. The change adopts the ty linter for comprehensive typo detection, resolving issue #6007. It updated 47 files, reducing 370 lines and adding 139.
qwen3.6-35b-a3b-mtp-q6 — — Merged a style update to fully integrate the ty typo-checking tool, resolving issue #6007. The maintainer applied comprehensive typo fixes across the codebase and documentation, enforcing consistent linting standards.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: snapcraft#6007 (confidence 100%)

    PR #6247 explicitly says “Fixes #6007,” and issue #6007 records PR #6247/commit 534d7dce7 as its resolution.

Related issues

Issue Project State Summary Similarity
#6007 Remove mypy and pyright snapcraft closed Request to drop mypy and pyright for ty was resolved by merged PR #6247 ("style: go all-in on ty", commit 534d7dce7), which replaced both checkers with ty and removed the unused-ignore-comment suppression.
84%
#1706 style: drop mypy, pyright craft-parts merged Merged PR #1706 in commit 770e2130, replacing mypy and pyright with ty; redundant runtime type-check cleanup was deferred to #1707.
81%
#421 style: ty craft-cli merged Merged PR #421 as 5c6d127, updating ty to unblock snapcraft#5673; it opened #420 to remove mypy and pyright, later resolved by #479.
80%
#253 style: drop mypy, pyright craft-archives merged Merged PR #253 (commit 1949f53) drops mypy and pyright in favor of ty; lint and test CI checks passed.
80%
#215 style: drop mypy, pyright craft-grammar merged Merged #215 in commit 19a38b7, dropping mypy and pyright in favor of ty across six files (+4/-481).
80%
#1007 style: drop mypy, pyright craft-providers merged Merged into main as commit 232143d, replacing mypy and pyright with ty and removing obsolete type-checker tooling.
79%
#2961 style: suppress ty diagnostics that block CI charmcraft merged Merged PR #2961 adds ty-specific lint ignores to match existing pyright/mypy configurations and removes a redundant cast in _expand_base, resolving CI blocks.
78%
#479 style: drop mypy, pyright craft-cli merged Merged PR #479 (commit 0e49c01) dropped the mypy and pyright type checkers in favour of ty, removing ~340 lines of type-checker config and ignore directives across 8 files; all CI checks passed.
78%
#420 Remove mypy and pyright craft-cli closed Removed mypy and pyright in favor of ty through merged PR #479 (commit 0e49c01).
78%
#223 style: switch from mypy+pyright to ty craft-platforms merged Merged PR #223 by lengau replaced mypy and pyright with the ty type checker in craft-platforms, dropping ~274 lines across 3 files; approved by 2 reviewers with all lint/test CI green.
78%