Fixed new pyright issues.
Metadata
Current evaluation
Maintainer PR fixing newly surfaced Pyright type errors (2-line change in 1 file). Merged into main as commit bbf67e4 via merge commit 88a68ac; Pyright was later dropped from the repo (#327, #479).
Resolution: closed resolved
Reason: The PR itself was the fix and was approved and merged: commit bbf67e4 ("Fixed new pyright issues.") merged to main by merge commit 88a68ac from branch fix-pyright-details, resolving the type-check failures by a minimal two-line edit.
Evaluated by: mr-cal-bot
Issue body
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Maintainer PR fixing newly surfaced Pyright type errors (2-line change in 1 file). Merged into main as commit bbf67e4 via merge commit 88a68ac; Pyright was later dropped from the repo (#327, #479). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged into main via canonical/craft-cli#65 (fix bbf67e4, merge 88a68ac), correcting new Pyright issues with a two-line change. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a maintainer-submitted pull request resolving newly identified pyright type checking issues. The change modified two lines in a single file, received one reviewer approval, and was successfully integrated into the codebase. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-cli#327
(confidence 45%)
Commit 4c45c0e "build(deps): remove pyright" — pyright tooling later removed from the project, making this fix historical.
-
Related To:
canonical/craft-cli#479
(confidence 40%)
Commit 0e49c01 "style: drop mypy, pyright" — static type checking later removed entirely, so further pyright fixes were no longer needed.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #94 Fixed new pyright issues. | craft-providers | merged | PR #94 was merged, fixing new Pyright errors and making Makefile test targets explicit; merged in 432a4f2 with implementation commit 101df6c. | |
| #342 type: fix pyright possibly-unbound error | rockcraft | merged | Merged PR #342 fixed a Pyright possibly-unbound diagnostic with a small one-file change, landing as commit 06629929. | |
| #1703 build: update pyright to 1.1.366 | charmcraft | merged | Merged PR #1703 upgraded Pyright to 1.1.366 in two build files via commit d189a48e. | |
| #58 lint: fix typing issues with updated pyright | craft-archives | merged | Merged PR #58 as commit 7983916, fixing typing issues across seven files after Pyright was updated. | |
| #1528 Enable pyright and clear the typing issues | charmcraft | closed | Pyright was enabled by merged PR #1525 (6374ef9e), then tightened by #1574 and #1614; #1528 was later closed without a maintainer explanation. | |
| #172 build(deps): update dependency pyright to v1.1.402 (main) | craft-archives | closed | Renovate pyright 1.1.390->1.1.402 PR closed unmerged by maintainer (upils) as inconsistent; superseded by PR #181 (pyright 1.1.403), merged as d9c6967. | |
| #161 build(deps): update dependency pyright to v1.1.402 | imagecraft | merged | Renovate PR #161 bumping pyright 1.1.401 -> 1.1.402 was approved and merged into main as commit fbe8b05; pyright later removed from pyproject in #231. | |
| #100 build(deps): update dependency pyright to v1.1.393 | craft-platforms | merged | Renovate PR merging the pyright bump from 1.1.392.post0 to 1.1.393. Merged into main as commit c0551bc after 2 approvals; the Renovate edited/blocked warning comment was resolved by manual merge. | |
| #1525 build: enable pyright | charmcraft | merged | Merged PR #1525 as commit 6374ef9e, enabling Pyright with existing type errors downgraded to warnings for gradual adoption. | |
| #170 build(deps): update pyright | starbase | merged | Pyright updates were merged: mock complaints were disabled and types/pyright was grouped with Pyright in Renovate. PR #170 landed as commit 20eb129. |