← Back to issue list

style: enable ty as stable type checker

View original Github issue

Metadata

Project
craft-platforms
Number
#201
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged in craft-platforms#201 (commit 5407de0), enabling ty as the stable type checker in regular checks while retaining pyright and mypy for now.

Resolution: closed resolved

Reason: PR #201 was approved by two reviewers, passed all CI checks, and merged as commit 5407de0. It added ty to the regular process without removing pyright or mypy.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? --- This doesn't (yet) remove pyright or mypy, but ty is now stable and can be used as part of our regular process.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in craft-platforms#201 (commit 5407de0), enabling ty as the stable type checker in regular checks while retaining pyright and mypy for now.
stealth/space-bunny-alpha — closed resolved Merged in commit 5407de0, enabling ty as the stable type checker while retaining pyright and mypy.
qwen/qwen3.6-35b-a3b — closed resolved Merged to enable ty as the stable type checker in the project's regular linting process, alongside existing pyright and mypy.

Update history

Date Change
created

Related work

  • Related To: craft-platforms#207 (confidence 95%)

    Follow-up change disabled pyright in favor of ty.

  • Related To: craft-platforms#223 (confidence 95%)

    Later completed the migration by switching from mypy and pyright to ty.

Related issues

Issue Project State Summary Similarity
#200 style: enable ty as stable type checker craft-platforms closed Superseded by canonical/craft-platforms#201, which merged commit 5407de0 to add ty as the stable type checker while retaining mypy and pyright.
94%
#223 style: switch from mypy+pyright to ty craft-platforms merged Merged PR #223 by lengau replaced mypy and pyright with the ty type checker in craft-platforms, dropping ~274 lines across 3 files; approved by 2 reviewers with all lint/test CI green.
76%
#472 style: enable ty by default starbase merged Merged PR #472 as commit 7982765, making Astral ty a default type-checking option while retaining existing checkers.
75%
#740 style: update type checkers craft-providers merged Merged in craft-providers#740 via 9e4c518, updating mypy and switching type checking to the Pyright snap.
72%
#407 style(types): enable type checking with ty craft-cli merged Merged as d38e0f4: enabled Astral ty type checking, added it to the lint workflow, and included it in lint build dependencies.
72%
#152 style: remove mypy and pyright to go all-in on ty debcraft merged Merged canonical/debcraft#152, removing mypy and pyright and standardizing type checking on Astral ty after approval by two reviewers.
72%
#1084 style: replace mypy and pyright with ty craft-application merged Merged PR #1084 as squash commit 345bd5d9, replacing mypy and pyright with ty and updating lint configuration for craft-app 7.
72%
#885 style: enable type checking with ty craft-providers merged Merged as commit 28ccfe5, PR #885 enabled ty type checking and fixed resulting errors across 8 files; all CI checks passed.
72%
#6247 style: go all-in on ty snapcraft merged Merged PR #6247 (commit 534d7dce7) replaced mypy and pyright with ty, removed obsolete suppressions, and resolved #6007.
71%
#263 Migrate type checking to ty. imagecraft closed Type checking was migrated from mypy/pyright to ty by merged PR #328, commit fc21f39.
70%