Fixed new pyright issues.
Metadata
Current evaluation
PR #94 was merged, fixing new Pyright errors and making Makefile test targets explicit; merged in 432a4f2 with implementation commit 101df6c.
Resolution: closed resolved
Reason: The approved PR was merged as commit 432a4f2. Commit 101df6c fixed the Pyright findings and clarified which tests each Makefile target runs.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Also improved Makefile to be explicit about what to test in each case.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR #94 was merged, fixing new Pyright errors and making Makefile test targets explicit; merged in 432a4f2 with implementation commit 101df6c. | |
| qwen/qwen3.6-35b-a3b | — | closed resolved | Merged PR fixing new pyright type-checking issues and improving Makefile test targets for clarity |
Update history
| Date | Change |
|---|---|
| created |
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #65 Fixed new pyright issues. | craft-cli | merged | Maintainer PR fixing newly surfaced Pyright type errors (2-line change in 1 file). Merged into main as commit bbf67e4 via merge commit 88a68ac; Pyright was later dropped from the repo (#327, #479). | |
| #342 type: fix pyright possibly-unbound error | rockcraft | merged | Merged PR #342 fixed a Pyright possibly-unbound diagnostic with a small one-file change, landing as commit 06629929. | |
| #1703 build: update pyright to 1.1.366 | charmcraft | merged | Merged PR #1703 upgraded Pyright to 1.1.366 in two build files via commit d189a48e. | |
| #237 style: fix pyright config | craft-cli | merged | Merged #237 (commit 675d42a), updating two Pyright ignore patterns so they apply recursively. | |
| #58 lint: fix typing issues with updated pyright | craft-archives | merged | Merged PR #58 as commit 7983916, fixing typing issues across seven files after Pyright was updated. | |
| #613 build(deps): update pyright to 1.1.373 | craft-providers | merged | Merged PR #613 updated pyright to 1.1.373 in commit 0f8df4f. | |
| #639 style: update pyright | craft-parts | merged | Merged #639 in commit 162a3522, updating Pyright and including codespell autofixes across four files. | |
| #1528 Enable pyright and clear the typing issues | charmcraft | closed | Pyright was enabled by merged PR #1525 (6374ef9e), then tightened by #1574 and #1614; #1528 was later closed without a maintainer explanation. | |
| #4485 style(lint): fix pyright errors | snapcraft | merged | Merged PR #4485, fixing Pyright lint errors across nine files with three reviewer approvals. |