← Back to issue list

style: replace mypy and pyright with ty

View original Github issue

Metadata

Project
rockcraft
Number
#1207
Type
pull request
State
merged
Author
bepri
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1207 (commit 5d9356c1), replacing mypy and pyright type checking with Astral ty and updating lint configuration across 43 files.

Resolution: closed resolved

Reason: PR #1207 was approved and merged into main as commit 5d9356c1, completing Rockcraft's migration to ty as its sole Python type checker.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Move to only using ty for linting. The targets to stop setting up mypy and pyright will come in from Starbase once all of our repos are ready. Best for per-commit reviewing. --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/rockcraft/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1207 (commit 5d9356c1), replacing mypy and pyright type checking with Astral ty and updating lint configuration across 43 files.
stealth/space-bunny-alpha — closed resolved Merged PR canonical/rockcraft#1207 (commit 5d9356c1) by bepri: dropped mypy and pyright config and switched rockcraft's only type checker to ty, changing 43 files (+110/-248).
stealth/space-bunny-alpha — closed resolved Merged PR #1207 as commit 5d9356c1, replacing mypy and pyright with ty for linting across 43 files.
stealth/space-bunny-alpha — closed resolved Merged PR canonical/rockcraft#1207 (commit 5d9356c1, 'style: replace mypy and pyright with ty'): linting switched to ty, dropping mypy/pyright configs and type annotations across 43 files (+110/-248).
stealth/space-bunny-alpha — closed resolved Merged in canonical/rockcraft#1207 (commit 5d9356c1), replacing mypy and pyright linting with ty and updating 43 files.
stealth/space-bunny-alpha — closed resolved Merged PR #1207 as 5d9356c1, replacing mypy and pyright with ty; deferred Starbase target changes until other repositories were ready.
qwen/qwen3.6-35b-a3b — — Merged changes replacing mypy and pyright linting tools with ty. Approved by three reviewers and passed CI checks. Updates 43 files to streamline linting configuration and prepare for Starbase integration.
qwen3.6-35b-a3b-mtp-q6 — — Merged changes replacing mypy and pyright with ty for linting. The toolchain update streamlines configuration, with remaining CI targets to be migrated via Starbase once all repositories are ready.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#421 style: drop mypy, pyright craft-store merged Merged #421 to replace mypy and pyright with Astral ty; the lint pipeline now runs lint-ty.
87%
#1084 style: replace mypy and pyright with ty craft-application merged Merged PR #1084 as squash commit 345bd5d9, replacing mypy and pyright with ty and updating lint configuration for craft-app 7.
82%
#253 style: drop mypy, pyright craft-archives merged Merged PR #253 (commit 1949f53) drops mypy and pyright in favor of ty; lint and test CI checks passed.
81%
#223 style: switch from mypy+pyright to ty craft-platforms merged Merged PR #223 by lengau replaced mypy and pyright with the ty type checker in craft-platforms, dropping ~274 lines across 3 files; approved by 2 reviewers with all lint/test CI green.
81%
#152 style: remove mypy and pyright to go all-in on ty debcraft merged Merged canonical/debcraft#152, removing mypy and pyright and standardizing type checking on Astral ty after approval by two reviewers.
81%
#207 style: disable pyright in favour of ty craft-platforms merged Merged as f287a56, replacing the active Pyright configuration with Astral’s ty type checker.
80%
#479 style: drop mypy, pyright craft-cli merged Merged PR #479 (commit 0e49c01) dropped the mypy and pyright type checkers in favour of ty, removing ~340 lines of type-checker config and ignore directives across 8 files; all CI checks passed.
80%
#1706 style: drop mypy, pyright craft-parts merged Merged PR #1706 in commit 770e2130, replacing mypy and pyright with ty; redundant runtime type-check cleanup was deferred to #1707.
78%
#1007 style: drop mypy, pyright craft-providers merged Merged into main as commit 232143d, replacing mypy and pyright with ty and removing obsolete type-checker tooling.
78%
#215 style: drop mypy, pyright craft-grammar merged Merged #215 in commit 19a38b7, dropping mypy and pyright in favor of ty across six files (+4/-481).
78%