← Back to issue list

refactor: port code to latest craft-app update

View original Github issue

Metadata

Project
rockcraft
Number
#521
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #521 as de242431, migrating image and package services to craft-application 2.3.0's build plan without changing build semantics.

Resolution: closed resolved

Reason: The PR was approved and merged as commit de242431, replacing platform/build-for metadata access with the build-plan API.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The brunt of the update is updating usages of platform/build-for to the build plan. This largely affects the image and package services, but the semantics should be unchanged because it's the same data just delivered differently. A bit more context here is that the `feature/craft-application` branch already had a bunch of migration work done, so I just rebased that branch and created this one off it. That branch bumps craft-application to 2.3.0. - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #521 as de242431, migrating image and package services to craft-application 2.3.0's build plan without changing build semantics.
stealth/space-bunny-alpha — closed resolved Merged as commit de242431, updating image and package services to use the craft-application 2.3.0 build plan instead of platform/build-for while preserving semantics.
stealth/space-bunny-alpha — closed resolved Merged PR #521 as de242431: migrated Rockcraft's image and package services from platform/build-for to the craft-application 2.3.0 build plan, preserving build semantics.
qwen/qwen3.6-35b-a3b — — Merged following two approvals and passing CI. Refactored image and package services to replace platform/build-for with the build plan, aligning with craft-application 2.3.0. Updates span 14 files (+106/-71 lines).
qwen3.6-35b-a3b-mtp-q6 — — Merged refactor updating code to craft-application 2.3.0. Replaced platform/build-for with the build plan in image and package services. Changes were rebased from feature/craft-application with unchanged semantics.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4691 build(deps): update craft-application to 2.1.0 snapcraft merged Renovate-style dependency bump of craft-application to 2.1.0 merged via PR #4691 (commit 1293b463d), changing 4 files (+4/-4) after approval by 2 reviewers; later superseded by further craft-application bumps.
75%
#395 refactor: merge feature/craft-application rockcraft merged Merged PR #395 into main, completing the breaking migration to craft-application 1.0.0 and resolving seven linked migration and command issues.
75%
#4682 refactor(app): use more code from craft-app snapcraft merged Merged as c9b6941d4, replacing Snapcraft-specific application logic with craft-app functionality (36 additions and 49 deletions across three files).
74%
#1661 chore(deps): update dependency craft-application to v2.5.0 charmcraft merged Renovate PR #1661 was merged (commit 738a3ffe), bumping craft-application from ==2.4.0 to ==2.5.0 in two dependency files. Approved by 2 reviewers and auto-merged.
71%
#1596 build(deps): use craft-application 2.0.0 charmcraft merged Merged as commit 212b2005, updating Charmcraft to craft-application 2.0.0 and adapting affected code across 13 files.
71%
#1606 build(deps): use craft-application 2.0.0 charmcraft closed Closed unmerged as superseded; the same craft-application 2.0.0 update was merged via #1596 in commit 212b2005.
70%
#4659 fix: update to craft-application latest snapcraft merged Merged PR #4659 updated Snapcraft for the latest craft-application breaking changes, consolidating work from #4616, #4643, and #4651.
70%
#1520 refactor: remove old "init" command implementation charmcraft merged Merged PR #1520 in commit 97fa9229, removing 248 lines of obsolete init command code after the craft-application transition.
70%
#353 refactor(cli): add scaffolding for craft-application rockcraft merged PR #353 merged into feature/craft-application as 5cff2f1c, adding craft-application scaffolding with a legacy-runner fallback.
70%
#5205 refactor: use craft-platforms utilities snapcraft merged Merged PR #5205 as commit 3aacad74b, replacing local architecture helpers with craft-platforms utilities and closing #4993 (CRAFT-3278).
70%