← Back to issue list

Updated waf plugin to use get_build_properties()

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1650079
Type
issue
State
closed
Author
~matt-aguirre
Labels
—
Created
Updated
Closed

Current evaluation

⚠️ This summary may be outdated — the issue content or evaluation prompts have changed since this evaluation was made.

Closed as fixed. The waf.py plugin was updated to use get_build_properties() instead of modifying the schema.

Suggested action: —

No scores available.

Issue body

Updated the waf.py plugin to use the get_build_properties() method instead of modifying the schema.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Closed as fixed. The waf.py plugin was updated to use get_build_properties() instead of modifying the schema.
qwen/qwen3.6-35b-a3b — — Resolved by updating the waf.py plugin to use get_build_properties() instead of modifying the schema, closing the issue.
qwen3.6-35b-a3b-mtp-q6 — — Fixed by updating the waf plugin to use get_build_properties() instead of schema modification. Closed upon implementation.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1650078 Updated cmake plugin to use get_build_properties snapcraft (launchpad) closed The cmake.py plugin was updated to use get_build_properties() instead of modifying the schema. The change was implemented and the issue closed as fixed.
79%
#979 Updated waf plugin to use get_build_properties() snapcraft merged Merged an external contribution updating the waf plugin to use get_build_properties(). Approved by one reviewer with zero unresolved comments and passing CI checks. Code coverage increased by 0.01% upon merge.
77%
#1649986 update maven plugin to use get_build_properties snapcraft (launchpad) closed The maven plugin was updated to use get_build_properties() instead of modifying the schema. The issue was closed after implementation.
77%
#1650548 Update make plugin to use get_build_properties snapcraft (launchpad) closed The make plugin was updated to use get_build_properties() instead of schema modification, with tests added. The issue was closed after implementation.
77%
#1650606 Updated go plugin to use get_build_properties() snapcraft (launchpad) closed Merged update to the Go plugin replacing schema modification with get_build_properties(), including corresponding test additions.
73%
#975 Updated gradle plugin to use get_build_properties() snapcraft merged Merged following reviewer approval and passing CI. The update replaces direct schema modification in maven.py with the get_build_properties() method, resolving bug 1649988. The change modifies three files, adding 18 lines and removing 4.
72%
#974 Updated maven plugin to use get_build_properties() snapcraft merged Merged update to the maven plugin that replaces schema modification with get_build_properties(). Unit tests were added to verify the change, resolving deprecated property checks. CI passed and coverage increased by 0.02%.
72%