← Back to issue list

Updated waf plugin to use get_build_properties()

View original Github issue

Metadata

Project
snapcraft
Number
#979
Type
pull request
State
merged
Author
ZenHarbinger
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit f8359e3cc, updating the Waf plugin to the new get_build_properties() API (part of a wider plugin migration, LP bug #1650079).

Resolution: closed resolved

Reason: PR #979 was approved and merged into master as commit f8359e3cc ("waf plugin: implement get_build_properties()"), which replaced the Waf plugin's direct Part properties/source schema modification with the new get_build_properties() plumbing.

Evaluated by: mr-cal-bot

No scores available.

Issue body

https://bugs.launchpad.net/snapcraft/+bug/1650079

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit f8359e3cc, updating the Waf plugin to the new get_build_properties() API (part of a wider plugin migration, LP bug #1650079).
stealth/space-bunny-alpha — closed resolved Merged in snapcore/snapcraft#979 (commit f8359e3cc), updating the Waf plugin to use get_build_properties().
qwen/qwen3.6-35b-a3b — — Merged an external contribution updating the waf plugin to use get_build_properties(). Approved by one reviewer with zero unresolved comments and passing CI checks. Code coverage increased by 0.01% upon merge.
qwen3.6-35b-a3b-mtp-q6 — — Merged to master, updating the waf plugin to use get_build_properties() and resolving Launchpad bug #1650079. The change increased repository coverage by 0.01% and was authored by an external contributor.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft (launchpad)#1650079 (confidence 90%)

    Launchpad bug #1650079 cited in the PR body is the tracking issue for the plugin-wide get_build_properties() migration.

  • Related To: snapcraft#978 (confidence 78%)

    cmake plugin: implement get_build_properties() (989177ee3) is a sibling PR from the same migration campaign.

  • Related To: snapcraft#975 (confidence 74%)

    gradle plugin: implement get_build_properties() (536f18c6e) is a sibling PR from the same migration campaign.

  • Related To: snapcraft#1397 (confidence 60%)

    Later commit 5d5d8f2ca 'waf plugin: enable cross-compilation support' builds on the get_build_properties() work introduced here.

Related issues

Issue Project State Summary Similarity
#1650079 Updated waf plugin to use get_build_properties() snapcraft (launchpad) closed Waf plugin was updated to use get_build_properties() instead of modifying the schema in snapcore/snapcraft PR #979 (commit f8359e3cc).
86%
#1022 plugins: update copy plugin to use get_build_properties(). snapcraft merged Merged as commit e9e05f959: copy plugin migrated from deprecated properties to get_build_properties(), the final plugin in the LP #1647899 migration series.
76%
#991 Updated ant plugin to use get_build_properties() snapcraft merged Merged PR #991 in commit 65efd4678, updating the Ant plugin to use get_build_properties() and register build-properties so warnings are emitted correctly.
76%
#992 plugins: update make plugin to use get_build_properties() snapcraft merged Merged #992, updating the make plugin and its tests to use get_build_properties(); landed as commit 65a1dd09c.
76%
#975 Updated gradle plugin to use get_build_properties() snapcraft merged External contributor PR merged as commit 536f18c6e, switching the Gradle plugin from schema mutation to get_build_properties(); closes Launchpad bug 1649988. Part of a wider plugin cleanup series.
75%
#994 Updated kbuild plugin to use get_build_properties() snapcraft closed Superseded by #995, which merged the get_build_properties() update in commit fbd8887ac.
75%
#978 Updated cmake plugin to use get_build_properties() snapcraft merged Merged PR #978 updated the CMake plugin to implement get_build_properties(), addressing Launchpad bug #1650078 in commit 989177ee3.
75%
#999 Updated autotools plugin to use get_build_properties() snapcraft merged Merged as commit 026fcfdf6: autotools plugin migrated to get_build_properties(), with schema unit test and get_pull_properties() tests updated. Resolves Launchpad bug #1650608.
73%
#974 Updated maven plugin to use get_build_properties() snapcraft merged Merged into snapcraft master as commit 9a1482d41: the Maven plugin now implements get_build_properties() (plus unit tests) instead of injecting build attrs into the schema, fixing LP bug #1649986.
72%
#998 plugins: update gulp plugin to use get_build_properties() and get_pull_properties() snapcraft merged Merged as acf95e174, updating the Gulp plugin to use build/pull property hooks and adding schema and unit tests for Launchpad bug #1650603.
71%