← Back to issue list

Updated waf plugin to use get_build_properties()

View original Github issue

Metadata

Project
snapcraft
Number
#979
Type
pull request
State
merged
Author
ZenHarbinger
Labels
Created
Updated
Closed

Current evaluation

Merged an external contribution updating the waf plugin to use get_build_properties(). Approved by one reviewer with zero unresolved comments and passing CI checks. Code coverage increased by 0.01% upon merge.

Suggested action:

No scores available.

Issue body

https://bugs.launchpad.net/snapcraft/+bug/1650079

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged an external contribution updating the waf plugin to use get_build_properties(). Approved by one reviewer with zero unresolved comments and passing CI checks. Code coverage increased by 0.01% upon merge.
qwen3.6-35b-a3b-mtp-q6 Merged to master, updating the waf plugin to use get_build_properties() and resolving Launchpad bug #1650079. The change increased repository coverage by 0.01% and was authored by an external contributor.
qwen3.6-35b-a3b-mtp-q6 Merged into master, updating the waf plugin to use get_build_properties() to resolve Launchpad bug 1650079. The change increased code coverage by 0.01 percent and passed automated checks.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1650079 Updated waf plugin to use get_build_properties() snapcraft (launchpad) closed Closed as fixed. The waf.py plugin was updated to use get_build_properties() instead of modifying the schema.
77%
#978 Updated cmake plugin to use get_build_properties() snapcraft merged Merged after reviewer approval and passing CI checks. Updated the cmake plugin to use get_build_properties(), modifying two files and slightly increasing overall test coverage.
76%
#983 Updated scons plugin to use get_build_properties() snapcraft merged Merged into master following reviewer approval and successful CI checks. The update refactored the scons plugin to use get_build_properties(), added demo and test files, and increased code coverage by 0.08%.
74%
#974 Updated maven plugin to use get_build_properties() snapcraft merged Merged update to the maven plugin that replaces schema modification with get_build_properties(). Unit tests were added to verify the change, resolving deprecated property checks. CI passed and coverage increased by 0.02%.
72%
#991 Updated ant plugin to use get_build_properties() snapcraft merged Merged after approval, the ant plugin was updated to properly use get_build_properties() and register with the build-properties list, resolving a warning issue. The change added 18 lines across 3 files and passed all checks.
72%
#996 Updated nodejs plugin to use get_build_properties() snapcraft merged Merged into master following reviewer approval and passing CI. The nodejs plugin now uses get_build_properties() and get_pull_properties(), with updated unit and schema tests. Code coverage increased slightly to 96.34%.
72%
#975 Updated gradle plugin to use get_build_properties() snapcraft merged Merged following reviewer approval and passing CI. The update replaces direct schema modification in maven.py with the get_build_properties() method, resolving bug 1649988. The change modifies three files, adding 18 lines and removing 4.
71%
#999 Updated autotools plugin to use get_build_properties() snapcraft merged Merged into master. The autotools plugin was updated to use get_build_properties(), with corresponding schema test revisions and new tests for get_pull_properties(). Approved, passed CI, and maintained code coverage.
71%
#992 plugins: update make plugin to use get_build_properties() snapcraft merged Merged into master. Updated the make plugin to use get_build_properties() and added corresponding tests. Approved by a reviewer, passed CI checks, and resolved Launchpad bug 1650548.
70%