← Back to issue list

Updated cmake plugin to use get_build_properties

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1650078
Type
issue
State
closed
Author
~matt-aguirre
Labels
Created
Updated
Closed

Current evaluation

⚠️ This summary may be outdated — the issue content or evaluation prompts have changed since this evaluation was made.

The cmake.py plugin was updated to use get_build_properties() instead of modifying the schema. The change was implemented and the issue closed as fixed.

Suggested action:

No scores available.

Issue body

Updated the cmake.py plugin to use the get_build_properties() method instead of modifying the schema.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b The cmake.py plugin was updated to use get_build_properties() instead of modifying the schema. The change was implemented and the issue closed as fixed.
qwen/qwen3.6-35b-a3b Closed after the cmake plugin was updated to use get_build_properties() instead of modifying the schema.
qwen3.6-35b-a3b-mtp-q6 Fixed by updating the cmake.py plugin to use get_build_properties() instead of modifying the schema. The issue was closed after implementation.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#978 Updated cmake plugin to use get_build_properties() snapcraft merged Merged after reviewer approval and passing CI checks. Updated the cmake plugin to use get_build_properties(), modifying two files and slightly increasing overall test coverage.
85%
#1649986 update maven plugin to use get_build_properties snapcraft (launchpad) closed The maven plugin was updated to use get_build_properties() instead of modifying the schema. The issue was closed after implementation.
84%
#1650548 Update make plugin to use get_build_properties snapcraft (launchpad) closed The make plugin was updated to use get_build_properties() instead of schema modification, with tests added. The issue was closed after implementation.
82%
#975 Updated gradle plugin to use get_build_properties() snapcraft merged Merged following reviewer approval and passing CI. The update replaces direct schema modification in maven.py with the get_build_properties() method, resolving bug 1649988. The change modifies three files, adding 18 lines and removing 4.
80%
#1650553 Update qmake plugin to use get_build_properties snapcraft (launchpad) closed Updated the qmake plugin to use get_build_properties() and get_pull_properties() instead of schema modifications, with new tests added. The associated pull request was merged, closing the issue.
80%
#1650079 Updated waf plugin to use get_build_properties() snapcraft (launchpad) closed Closed as fixed. The waf.py plugin was updated to use get_build_properties() instead of modifying the schema.
79%
#974 Updated maven plugin to use get_build_properties() snapcraft merged Merged update to the maven plugin that replaces schema modification with get_build_properties(). Unit tests were added to verify the change, resolving deprecated property checks. CI passed and coverage increased by 0.02%.
78%
#994 Updated kbuild plugin to use get_build_properties() snapcraft closed Updated the kbuild plugin to use get_build_properties(). The change was merged and consolidated with PR #995, closing the request without additional review.
76%
#1650608 Update autotools plugin to use get_build_properties snapcraft (launchpad) closed Merged changes from pull request 999 update the autotools plugin to use get_build_properties() instead of modifying the schema. Tests were added to test_plugin_autotools.py, and the implementation was integrated into the codebase.
74%
#999 Updated autotools plugin to use get_build_properties() snapcraft merged Merged into master. The autotools plugin was updated to use get_build_properties(), with corresponding schema test revisions and new tests for get_pull_properties(). Approved, passed CI, and maintained code coverage.
74%