← Back to issue list

Update make plugin to use get_build_properties

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1650548
Type
issue
State
closed
Author
~matt-aguirre
Labels
Created
Updated
Closed

Current evaluation

⚠️ This summary may be outdated — the issue content or evaluation prompts have changed since this evaluation was made.

The make plugin was updated to use get_build_properties() instead of schema modification, with tests added. The issue was closed after implementation.

Suggested action:

No scores available.

Issue body

Updated the make.py plugin to use the get_build_properties() method instead of modifying the schema. Updated the test_plugin_make.py file to add test.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b The make plugin was updated to use get_build_properties() instead of schema modification, with tests added. The issue was closed after implementation.
qwen/qwen3.6-35b-a3b The make plugin was updated to use get_build_properties() instead of schema modification, with tests added to test_plugin_make.py. Changes were merged and the item closed.
qwen3.6-35b-a3b-mtp-q6 The make plugin was updated to use get_build_properties() instead of schema modification, with tests added. The change was implemented and the issue closed.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1650553 Update qmake plugin to use get_build_properties snapcraft (launchpad) closed Updated the qmake plugin to use get_build_properties() and get_pull_properties() instead of schema modifications, with new tests added. The associated pull request was merged, closing the issue.
84%
#1649986 update maven plugin to use get_build_properties snapcraft (launchpad) closed The maven plugin was updated to use get_build_properties() instead of modifying the schema. The issue was closed after implementation.
84%
#1650078 Updated cmake plugin to use get_build_properties snapcraft (launchpad) closed The cmake.py plugin was updated to use get_build_properties() instead of modifying the schema. The change was implemented and the issue closed as fixed.
82%
#974 Updated maven plugin to use get_build_properties() snapcraft merged Merged update to the maven plugin that replaces schema modification with get_build_properties(). Unit tests were added to verify the change, resolving deprecated property checks. CI passed and coverage increased by 0.02%.
80%
#1650606 Updated go plugin to use get_build_properties() snapcraft (launchpad) closed Merged update to the Go plugin replacing schema modification with get_build_properties(), including corresponding test additions.
80%
#992 plugins: update make plugin to use get_build_properties() snapcraft merged Merged into master. Updated the make plugin to use get_build_properties() and added corresponding tests. Approved by a reviewer, passed CI checks, and resolved Launchpad bug 1650548.
79%
#1650608 Update autotools plugin to use get_build_properties snapcraft (launchpad) closed Merged changes from pull request 999 update the autotools plugin to use get_build_properties() instead of modifying the schema. Tests were added to test_plugin_autotools.py, and the implementation was integrated into the codebase.
78%
#1650603 Update gulp plugin to use get_build_properties and get_pull_properties snapcraft (launchpad) closed Merged updates to the gulp plugin that replace schema modification with get_build_properties() and get_pull_properties(). Added corresponding plugin and schema tests.
78%
#1650079 Updated waf plugin to use get_build_properties() snapcraft (launchpad) closed Closed as fixed. The waf.py plugin was updated to use get_build_properties() instead of modifying the schema.
77%
#975 Updated gradle plugin to use get_build_properties() snapcraft merged Merged following reviewer approval and passing CI. The update replaces direct schema modification in maven.py with the get_build_properties() method, resolving bug 1649988. The change modifies three files, adding 18 lines and removing 4.
76%