← Back to issue list

ci: always discard spread workers in build-rock tests (core22-8)

View original Github issue

Metadata

Project
snapcraft-rocks
Number
#115
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged changes adding a cleanup step to discard spread workers in the build-rock CI workflow. This prevents leaked Google Cloud VM instances on cancellation or crash, resolving SNAPCRAFT-1368. Approved by two reviewers.

Suggested action:

No scores available.

Issue body

This PR adds the 'Discard spread workers' cleanup step to the 'spread-tests' job in the 'build-rock.yaml' workflow. Without this step, if the job is cancelled or crashes, the remote Google Cloud VM instances allocated by 'spread' are leaked and remain active until the halt timeout (2h). SNAPCRAFT-1368

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged changes adding a cleanup step to discard spread workers in the build-rock CI workflow. This prevents leaked Google Cloud VM instances on cancellation or crash, resolving SNAPCRAFT-1368. Approved by two reviewers.
qwen3.6-35b-a3b-mtp-q6
Staleness: 5
Complexity: 15
Confidence: 90
needs review Adds a cleanup step to discard spread workers in the build-rock CI workflow to prevent leaking Google Cloud VM instances on job cancellation or crash. Currently awaiting review.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#117 ci: always discard spread workers in build-rock tests (core24-8) snapcraft-rocks merged Merged changes add a cleanup step to discard spread workers in the build-rock workflow, preventing leaked Google Cloud VM instances on cancellation or crash. Resolves SNAPCRAFT-1368.
97%
#116 ci: always discard spread workers in build-rock tests (core22-7) snapcraft-rocks open Adds spread worker cleanup step to build-rock.yaml workflow to prevent leaked GCP VM instances. Inactive 56 days with unresolved review comment and failing CI checks.
89%
#6335 ci: always discard spread workers in manual tests (main) snapcraft merged Merged. Adds a cleanup step to discard spread workers in manual CI tests, preventing leaked Google Cloud VM instances upon cancellation or crash. Approved by one reviewer and merged with 56 lines added across one file.
82%
#2771 ci: always discard spread workers in snap-store-tests (main) charmcraft merged Merged CI fix adding cleanup to discard spread workers in snap-store-tests. Prevents Google Cloud VM leaks on cancellation or crash, aligning with other jobs. Approved and merged despite minor CI failures.
81%
#482 ci: always discard spread workers rockcraft merged Merged a CI workflow update to always discard spread workers, ensuring cleanup even on workflow cancellation. This change mirrors snapcraft's spread configuration.
76%
#1519 ci: always discard spread runners charmcraft merged Merged a CI workflow update that permanently discards spread runners by mirroring the snapcraft repository configuration. Approved by three reviewers, the change adds 16 lines to a single workflow file.
75%
#82 ci(core24-8): don't use a spread runner for publishing the rock snapcraft-rocks merged Merged a one-line CI fix restricting rock publishing to the amd64 runner. This prevents resource contention from accidentally triggering jobs on the spread runner. Approved by one reviewer and passed all CI checks.
74%
#81 ci(core22-8): don't use a spread runner for publishing the rock snapcraft-rocks merged Merged a CI configuration update assigning the rock publishing job to an amd64 runner. This prevents resource contention from routing the task to the spread runner. Approved by one reviewer and passed all continuous integration checks.
73%
#2770 ci: always discard spread workers in snap-store-tests charmcraft closed Abandoned without merge. The change to add a cleanup step preventing CI VM leaks in snap-store-tests received no reviews and was closed.
72%
#83 ci(core22-7): don't use a spread runner for publishing the rock snapcraft-rocks merged Merged a one-line CI configuration change to use the amd64 runner label for rock publishing, resolving resource contention issues on spread runners. Approved by one reviewer with all CI checks passing.
71%