← Back to issue list

ci: always discard spread workers in build-rock tests (core22-8)

View original Github issue

Metadata

Project
snapcraft-rocks
Number
#115
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

PR #115 merged (+8/-0): adds an always-run 'Discard spread workers' step to the spread-tests job in .github/workflows/build-rock.yaml for core22-8, so cancelled/crashed jobs no longer leak spread GCP VMs (SNAPCRAFT-1368).

Resolution: closed resolved

Reason: The PR was approved by 2 reviewers and merged into the default branch, landing the always-run 'Discard spread workers' cleanup step in the core22-8 build-rock spread-tests job; spread-tests, lint and CLA checks passed. The failing build-rock self-hosted checks are unrelated runner-environment failures and did not block the merge.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This PR adds the 'Discard spread workers' cleanup step to the 'spread-tests' job in the 'build-rock.yaml' workflow. Without this step, if the job is cancelled or crashes, the remote Google Cloud VM instances allocated by 'spread' are leaked and remain active until the halt timeout (2h). SNAPCRAFT-1368

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #115 merged (+8/-0): adds an always-run 'Discard spread workers' step to the spread-tests job in .github/workflows/build-rock.yaml for core22-8, so cancelled/crashed jobs no longer leak spread GCP VMs (SNAPCRAFT-1368).
stealth/space-bunny-alpha — closed resolved Merged #115, adding always-run spread-worker cleanup to core22-8 build-rock tests to prevent GCP VM leaks after cancellation or crashes.
qwen/qwen3.6-35b-a3b — — Merged changes adding a cleanup step to discard spread workers in the build-rock CI workflow. This prevents leaked Google Cloud VM instances on cancellation or crash, resolving SNAPCRAFT-1368. Approved by two reviewers.
qwen3.6-35b-a3b-mtp-q6
Staleness: 5
Complexity: 15
Confidence: 90
needs review Adds a cleanup step to discard spread workers in the build-rock CI workflow to prevent leaking Google Cloud VM instances on job cancellation or crash. Currently awaiting review.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft-rocks#117 (confidence 90%)

    Sibling PR applying the identical always-run spread-worker cleanup to core24-8 build-rock tests under the same SNAPCRAFT-1368 ticket; also merged.

  • Related To: snapcraft-rocks#116 (confidence 90%)

    Sibling PR applying the same cleanup to core22-7 build-rock tests (SNAPCRAFT-1368); still open, so part of the leak fix may remain unlanded for core22-7.

Related issues

Issue Project State Summary Similarity
#117 ci: always discard spread workers in build-rock tests (core24-8) snapcraft-rocks merged Merged PR #117 (core24-8) adds an always-run 'Discard spread workers' cleanup step to the spread-tests job in build-rock.yaml, so cancelled/crashed jobs don't leak GCP VMs for 2h (SNAPCRAFT-1368). Approved; +8/-0.
97%
#116 ci: always discard spread workers in build-rock tests (core22-7) snapcraft-rocks open Adds an always-run 'Discard spread workers' cleanup step to the spread-tests job in .github/workflows/build-rock.yaml (core22-7) so GCP VMs aren't leaked on cancellation (SNAPCRAFT-1368). +8/-0, spread-tests green, build-rock amd64/arm64 failing.
96%
#6335 ci: always discard spread workers in manual tests (main) snapcraft merged Merged #6335 in commit b36b3c325, adding always-run Spread worker cleanup to manual CI jobs so cancelled or crashed tests do not leak GCP VMs.
80%
#482 ci: always discard spread workers rockcraft merged PR #482 by lengau merged: added an always-run "Discard spread workers" cleanup step (spread -discard -reuse-pid) to .github/workflows/spread.yaml, copied from snapcraft's spread.yml.
80%
#2771 ci: always discard spread workers in snap-store-tests (main) charmcraft merged Merged PR #2771 (main) adds an always-run "Discard spread workers" cleanup step to the snap-store-tests job in spread.yaml, so cancelled/crashed CI runs no longer leak GCE VMs until the 2h halt timeout.
79%
#1519 ci: always discard spread runners charmcraft merged Merged #1519 (commit fdf24383), adding post-job cleanup to the Spread workflow so temporary runners are always discarded after CI jobs.
71%
#83 ci(core22-7): don't use a spread runner for publishing the rock snapcraft-rocks merged Merged PR #83 restricted core22-7 rock publishing to amd64 runners, preventing scheduling on resource-constrained Spread runners; all CI checks passed.
70%