← Back to issue list

ci: always discard spread workers in build-rock tests (core24-8)

View original Github issue

Metadata

Project
snapcraft-rocks
Number
#117
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #117 (core24-8) adds an always-run 'Discard spread workers' cleanup step to the spread-tests job in build-rock.yaml, so cancelled/crashed jobs don't leak GCP VMs for 2h (SNAPCRAFT-1368). Approved; +8/-0.

Resolution: closed resolved

Reason: PR #117 was approved and merged into main by maintainer lengau, adding the `if: always()` spread-halt cleanup step to the core24-8 spread-tests job in .github/workflows/build-rock.yaml, resolving the leaked-worker problem tracked under SNAPCRAFT-1368.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This PR adds the 'Discard spread workers' cleanup step to the 'spread-tests' job in the 'build-rock.yaml' workflow. Without this step, if the job is cancelled or crashes, the remote Google Cloud VM instances allocated by 'spread' are leaked and remain active until the halt timeout (2h). SNAPCRAFT-1368

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #117 (core24-8) adds an always-run 'Discard spread workers' cleanup step to the spread-tests job in build-rock.yaml, so cancelled/crashed jobs don't leak GCP VMs for 2h (SNAPCRAFT-1368). Approved; +8/-0.
stealth/space-bunny-alpha — closed resolved Merged PR #117 adds always-run spread-worker cleanup to core24-8 build-rock tests, preventing leaked GCP VMs after cancellation or crashes (SNAPCRAFT-1368).
qwen3.6-35b-a3b-mtp-q6 — — Merged changes add a cleanup step to discard spread workers in the build-rock workflow, preventing leaked Google Cloud VM instances on cancellation or crash. Resolves SNAPCRAFT-1368.
qwen/qwen3.6-35b-a3b
Staleness: 20
Complexity: 5
Confidence: 85
needs review Adds a cleanup step to discard spread workers in build-rock tests to prevent leaked Google Cloud VM instances. Currently pending maintainer review with 0 comments, CI passing except for two self-hosted build-rock jobs.
qwen/qwen3.6-35b-a3b
Staleness: 25
Complexity: 10
Confidence: 85
needs review Adds cleanup step to discard spread workers in build-rock tests to prevent GCP VM leaks on cancellation. Currently pending maintainer review with 0 comments. CI passes spread-tests but fails self-hosted build-rock jobs.
qwen3.6-35b-a3b-mtp-q6
Staleness: 5
Complexity: 10
Confidence: 90
needs review Adds a cleanup step to discard spread workers in the build-rock workflow to prevent leaked Google Cloud VM instances after job cancellation or crashes. Currently awaiting review.

Update history

Date Change
updated
updated

Related work

Related issues

Issue Project State Summary Similarity
#115 ci: always discard spread workers in build-rock tests (core22-8) snapcraft-rocks merged PR #115 merged (+8/-0): adds an always-run 'Discard spread workers' step to the spread-tests job in .github/workflows/build-rock.yaml for core22-8, so cancelled/crashed jobs no longer leak spread GCP VMs (SNAPCRAFT-1368).
97%
#116 ci: always discard spread workers in build-rock tests (core22-7) snapcraft-rocks open Adds an always-run 'Discard spread workers' cleanup step to the spread-tests job in .github/workflows/build-rock.yaml (core22-7) so GCP VMs aren't leaked on cancellation (SNAPCRAFT-1368). +8/-0, spread-tests green, build-rock amd64/arm64 failing.
95%
#2771 ci: always discard spread workers in snap-store-tests (main) charmcraft merged Merged PR #2771 (main) adds an always-run "Discard spread workers" cleanup step to the snap-store-tests job in spread.yaml, so cancelled/crashed CI runs no longer leak GCE VMs until the 2h halt timeout.
80%
#6335 ci: always discard spread workers in manual tests (main) snapcraft merged Merged #6335 in commit b36b3c325, adding always-run Spread worker cleanup to manual CI jobs so cancelled or crashed tests do not leak GCP VMs.
80%
#482 ci: always discard spread workers rockcraft merged PR #482 by lengau merged: added an always-run "Discard spread workers" cleanup step (spread -discard -reuse-pid) to .github/workflows/spread.yaml, copied from snapcraft's spread.yml.
76%