← Back to issue list

ci: always discard spread workers in build-rock tests (core22-7)

View original Github issue

Metadata

Project
snapcraft-rocks
Number
#116
Type
pull request
State
open
Author
lengau
Labels
—
Created
Updated
Closed
—

Current evaluation

Adds spread worker cleanup step to build-rock.yaml workflow to prevent leaked GCP VM instances. Inactive 56 days with unresolved review comment and failing CI checks.

Suggested action: close stale

Reason: Similar cleanup changes have been merged in related PRs #115 (core22-8) and #117 (core24-8), indicating this pattern has been implemented elsewhere. This PR has been inactive for 56 days with an unresolved review comment and failing CI checks on build-rock jobs, suggesting it is no longer actively maintained.

Impact: 40 Quick Win: 34.0 Staleness: 75 Complexity: 15 Confidence: 70

Issue body

This PR adds the 'Discard spread workers' cleanup step to the 'spread-tests' job in the 'build-rock.yaml' workflow. Without this step, if the job is cancelled or crashes, the remote Google Cloud VM instances allocated by 'spread' are leaked and remain active until the halt timeout (2h). SNAPCRAFT-1368

Evaluation history

Date Model Scores Action Summary
qwen3.6-35b-a3b-mtp-q6
Impact: 40
Quick Win: 34.0
Staleness: 75
Complexity: 15
Confidence: 70
close stale Adds spread worker cleanup step to build-rock.yaml workflow to prevent leaked GCP VM instances. Inactive 56 days with unresolved review comment and failing CI checks.
qwen/qwen3.6-35b-a3b
Staleness: 15
Complexity: 10
Confidence: 85
needs review Adds a cleanup step to discard spread workers in build-rock tests to prevent leaked Google Cloud VM instances. Currently pending review with 1 unresolved comment and failing self-hosted CI checks.
qwen3.6-35b-a3b-mtp-q6
Staleness: 5
Complexity: 15
Confidence: 90
needs review Adds a cleanup step to discard spread workers in build-rock CI tests to prevent leaked Google Cloud VM instances upon cancellation or crash. Currently awaiting review.

Update history

No update history recorded yet.

Related work

  • Duplicate Of: snapcraft-rocks#115 (confidence 80%)

    Merged PR implementing the same spread worker cleanup for core22-8 branch

  • Duplicate Of: snapcraft-rocks#117 (confidence 80%)

    Merged PR implementing the same spread worker cleanup for core24-8 branch

Related issues

Issue Project State Summary Similarity
#115 ci: always discard spread workers in build-rock tests (core22-8) snapcraft-rocks merged Merged changes adding a cleanup step to discard spread workers in the build-rock CI workflow. This prevents leaked Google Cloud VM instances on cancellation or crash, resolving SNAPCRAFT-1368. Approved by two reviewers.
89%
#117 ci: always discard spread workers in build-rock tests (core24-8) snapcraft-rocks merged Merged changes add a cleanup step to discard spread workers in the build-rock workflow, preventing leaked Google Cloud VM instances on cancellation or crash. Resolves SNAPCRAFT-1368.
87%
#6335 ci: always discard spread workers in manual tests (main) snapcraft merged Merged. Adds a cleanup step to discard spread workers in manual CI tests, preventing leaked Google Cloud VM instances upon cancellation or crash. Approved by one reviewer and merged with 56 lines added across one file.
73%
#81 ci(core22-8): don't use a spread runner for publishing the rock snapcraft-rocks merged Merged a CI configuration update assigning the rock publishing job to an amd64 runner. This prevents resource contention from routing the task to the spread runner. Approved by one reviewer and passed all continuous integration checks.
73%
#82 ci(core24-8): don't use a spread runner for publishing the rock snapcraft-rocks merged Merged a one-line CI fix restricting rock publishing to the amd64 runner. This prevents resource contention from accidentally triggering jobs on the spread runner. Approved by one reviewer and passed all CI checks.
73%
#83 ci(core22-7): don't use a spread runner for publishing the rock snapcraft-rocks merged Merged a one-line CI configuration change to use the amd64 runner label for rock publishing, resolving resource contention issues on spread runners. Approved by one reviewer with all CI checks passing.
71%