← Back to issue list

scons plugin: add support for bases

View original Github issue

Metadata

Project
snapcraft
Number
#2357
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged #2357, making the Scons plugin base-aware for core16/core18; landed as commit 883c308c9 and resolved LP #1794801.

Resolution: closed resolved

Reason: PR canonical/snapcraft#2357 was merged as commit 883c308c9, adding base-aware Scons plugin support for core16 and core18. The change resolved Launchpad #1794801.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Update the Scons plugin to be base-aware, only supporting core16 and core18. LP: #1794801 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #2357, making the Scons plugin base-aware for core16/core18; landed as commit 883c308c9 and resolved LP #1794801.
stealth/space-bunny-alpha — closed resolved Merged #2357 in commit 883c308c9, making the SCons plugin base-aware with support for core16 and core18.
stealth/space-bunny-alpha — closed resolved Merged PR #2357 in commit 883c308c9 made the SCons plugin base-aware, supporting core16 and core18.
stealth/space-bunny-alpha — closed resolved Merged #2357, making the Scons plugin base-aware and supporting core16 and core18; commit 883c308c9.
qwen/qwen3.6-35b-a3b — — Merged. Updated the Scons plugin to support core16 and core18 bases. Approved by reviewer, passed CI, and modified 105 additions and 18 deletions across five files.
qwen3.6-35b-a3b-mtp-q6 — — Merged update to the Scons plugin making it base-aware, restricting support to core16 and core18. Resolves Launchpad bug #1794801. Codecov reported 100% diff coverage.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#2370 ant plugin: add support for bases snapcraft merged Merged via commit eab7fcf15: made the ant plugin base-aware, supporting only core16 and core18, and updated its tests/spread coverage. Closes Launchpad bug #1794776.
77%
#1794801 Update the scons plugin to be base aware snapcraft (launchpad) closed Updated the SCons plugin with base awareness in snapcore/snapcraft#2357, merged as commit 883c308c9.
76%
#2363 {make,cmake,autotools} plugin: add support for bases snapcraft merged Merged #2363, adding base-aware support for the Make plugin and inherited CMake and Autotools plugins for core16/core18; commit 2f3879d93.
76%
#2373 rust plugin: add support for bases snapcraft merged Merged PR #2373 in commit eafd6d641, making the Rust plugin base-aware for core16 and core18 and resolving LP #1798681.
76%
#2368 {kbuild,kernel} plugin: add support for bases snapcraft merged Merged #2368 as ddbda36b5, adding core16/core18 base support to the KBuild and inherited Kernel plugins and resolving LP bugs #1794790/#1794791.
74%
#2362 python plugin: add support for bases snapcraft merged Merged in snapcraft#2362 via commit 669eebe19, making the Python plugin base-aware for core16/core18 and moving its tests to spread.
74%
#1500758 scons plugin snapcraft (launchpad) closed SCons plugin support was implemented in commit 25fb86397 after approval in 38a68cd78; later enhancements included options and build-properties support (#983).
74%
#2358 dotnet plugin: add support for bases snapcraft merged Merged PR #2358 as commit 58a06ef40, making the .NET plugin base-aware and limiting support to core16.
73%
#2364 maven plugin: add support for bases snapcraft merged PR snapcraft#2364 merged as commit b4aebc678, making the Maven plugin base-aware with support for core16 and core18, resolving Launchpad bug #1794793 (18 files, +778/-345).
73%
#2372 gradle plugin: add support for bases snapcraft merged Merged in snapcraft#2372 (58bbbda02), making the Gradle plugin base-aware with support limited to core16 and core18.
73%