test: delete unused tests
Metadata
Current evaluation
Merged as commit 3d1554584, removing 55 lines of obsolete, long-unused v1-plugin spread tests while retaining core20 coverage for external plugins.
Resolution: closed resolved
Reason: PR #5791 was approved and merged into main as commit 3d1554584, completing the planned test cleanup.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [ ] Have you successfully run `make test`?
---
This deletes some spread tests that haven't been run in a long, long time. v1 plugins were removed. New ruff formatter rules unearthed these artifacts.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit 3d1554584, removing 55 lines of obsolete, long-unused v1-plugin spread tests while retaining core20 coverage for external plugins. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in #5791 as commit 3d1554584, removing 55 lines of obsolete v1-plugin spread tests; related core20 support was retained pending future removal. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged removal of unused spread tests for deprecated v1 plugins. Approved by two reviewers and passed most CI checks despite one failing integration test. Cleanup of a related file deferred pending core20 support removal. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged deletion of unused spread tests left after v1 plugin removal. New ruff formatter rules identified the dead code. One related file was retained pending core20 support deprecation. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#6009
(confidence 98%)
Later removed the remaining core20 spread tests, enabling core20 lifecycle removal.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3432 spread tests: remove legacy plugin tests | snapcraft | merged | PR #3432 (commit 950fa2508, f2c9caa04) merged: deleted 665 lines of legacy plugin spread tests across 29 files, removing outdated plugin coverage without affecting code coverage (90.83%). | |
| #2421 tests: remove obsolete snap and external tests | snapcraft | merged | Merged PR #2421 in commit 707395546, deleting 77 obsolete snap/external-test files and 2,959 lines despite a negligible coverage decrease. | |
| #486 test(spread): clean up plugin prep/restore | imagecraft | merged | Merged PR #486 refactors spread tests by moving plugin preparation and restoration logic into common prepare-each and restore-each scripts, reducing task file size and improving maintainability. | |
| #1287 tests: minor cleanups on the spread tests | snapcraft | merged | Merged into master as commit 1cf0f8c9f "tests: minor cleanups on the spread tests (#1287)" — a test-only tidy-up touching 4 spread test files (+16/-6), reviewed and approved by fgimenez, with coverage unchanged at 95.27%. |