test: delete unused tests
Metadata
Current evaluation
Merged removal of unused spread tests for deprecated v1 plugins. Approved by two reviewers and passed most CI checks despite one failing integration test. Cleanup of a related file deferred pending core20 support removal.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [ ] Have you successfully run `make test`?
---
This deletes some spread tests that haven't been run in a long, long time. v1 plugins were removed. New ruff formatter rules unearthed these artifacts.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged removal of unused spread tests for deprecated v1 plugins. Approved by two reviewers and passed most CI checks despite one failing integration test. Cleanup of a related file deferred pending core20 support removal. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged deletion of unused spread tests left after v1 plugin removal. New ruff formatter rules identified the dead code. One related file was retained pending core20 support deprecation. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes that remove unused spread tests left over from v1 plugin removal. One test file was retained temporarily to support external plugins until core20 deprecation. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3432 spread tests: remove legacy plugin tests | snapcraft | merged | Merged removal of legacy plugin tests from the spread test suite. Deleted 665 lines across 29 files. Approved by reviewer, passed CI, and maintained coverage. Unrelated test failures were addressed in a separate PR. | |
| #3540 spread tests: remove 16.04 and core (CRAFT-210) | snapcraft | merged | Merged cleanup removing legacy 16.04 and core references from spread tests. Approved with passing CI. Author noted necessary legacy tests will be reintroduced in future iterations. | |
| #1287 tests: minor cleanups on the spread tests | snapcraft | merged | Merged minor spread test cleanups into master. Modified four files with 16 additions and 6 deletions. Approved by one reviewer with zero unresolved comments, maintaining 95.27% coverage upon integration. | |
| #6009 test: remove core20 spread tests | snapcraft | merged | Merged removal of core20 spread tests and migration of related cases to core22 and core24. This update unblocks core20 deprecation for Snapcraft 9 and improves modern test coverage. | |
| #6202 test(spread): create core26 spread test suite | snapcraft | merged | Merged the core26 spread test suite, adding CI jobs and generalizing tests for core22, 24, and 26 across 419 files. Approved by two reviewers and passed most CI checks prior to integration. | |
| #3269 spread tests: remove references of core16 | snapcraft | merged | Merged after single reviewer approval. The change removes all core16 references from the spread test suite, updating three files with a net reduction of eight lines. Changes were integrated into the main branch. | |
| #5209 tests: enable core24 plugin tests | snapcraft | merged | Merged after four reviewers approved. The changes enable core24 plugin tests across 132 files, adding 2,795 lines. CI checks passed and the code was successfully integrated into the main branch. | |
| #4177 core18: removal | snapcraft | merged | Merged after two approvals and passing CI. Removes core18 support, resolving issue #4165. Changes span 528 files, deleting over 37,000 lines. Temporary core20 test fixes ensured CI passed prior to merge. | |
| #1290 test(spread): clean up store tests | charmcraft | merged | Merged cleanup of spread store tests, removing 28 lines across four files. The underlying library test failure is fixed in PR #1292. Approved by two reviewers. | |
| #5290 fix(core20): use importlib for local plugins | snapcraft | merged | Merged updates to core20 local plugin loading, replacing legacy imports with importlib and removing a deprecated warning. Approved by three reviewers with passing CI. Maintainers confirmed existing test coverage is sufficient. |