spread tests: remove 16.04 and core (CRAFT-210)
Metadata
Current evaluation
Merged cleanup removing legacy 16.04 and core references from spread tests. Approved with passing CI. Author noted necessary legacy tests will be reintroduced in future iterations.
Suggested action: —
No scores available.
Issue body
Cleaned up use of systems within existing tests where possible.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged cleanup removing legacy 16.04 and core references from spread tests. Approved with passing CI. Author noted necessary legacy tests will be reintroduced in future iterations. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged cleanup removing Ubuntu 16.04 and core references from spread tests. Code coverage remained unchanged. Legacy tests may be reintroduced later via separate tasks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged cleanup removing Ubuntu 16.04 and core from spread tests. Code coverage remained unchanged. Legacy integration tests were removed, with plans to reintroduce necessary ones in a future iteration. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3269 spread tests: remove references of core16 | snapcraft | merged | Merged after single reviewer approval. The change removes all core16 references from the spread test suite, updating three files with a net reduction of eight lines. Changes were integrated into the main branch. | |
| #3432 spread tests: remove legacy plugin tests | snapcraft | merged | Merged removal of legacy plugin tests from the spread test suite. Deleted 665 lines across 29 files. Approved by reviewer, passed CI, and maintained coverage. Unrelated test failures were addressed in a separate PR. | |
| #6202 test(spread): create core26 spread test suite | snapcraft | merged | Merged the core26 spread test suite, adding CI jobs and generalizing tests for core22, 24, and 26 across 419 files. Approved by two reviewers and passed most CI checks prior to integration. | |
| #1325 test(spread): consolidate basic init/build tests | charmcraft | merged | Merged after approval by two reviewers. Consolidates basic init and build spread tests across four files, reducing 80 lines and adding 28. Resolves CRAFT-2127. | |
| #6009 test: remove core20 spread tests | snapcraft | merged | Merged removal of core20 spread tests and migration of related cases to core22 and core24. This update unblocks core20 deprecation for Snapcraft 9 and improves modern test coverage. | |
| #4761 tests: remove core24 snap workarounds | snapcraft | merged | Merged after two approvals and passing CI. Removed core24 snap workarounds from spread tests, deleting 22 lines. Branch retargeted to hotfix/8.2 for release. | |
| #2276 spread: move legacy wiki tests to spread | snapcraft | merged | Merged following reviewer approval and passing CI. Relocated legacy wiki tests from integration tests to spread, updating 12 files with a net reduction of 42 lines. Addresses LP: #1792717. | |
| #386 tests: update testing to use craft-test | fetch-service | merged | Merged. Replaced direct spread calls with snapcraft test in workflows and spread.yaml, requiring a core24 base update. Approved by two reviewers and modified 10 files (+56/-125 lines). | |
| #16 tests: add spread support | rockcraft | merged | Merged after approval and passing CI, adding spread support to tests per CRAFT-865. | |
| #3026 spread tests: add core20 and cleanup systems | snapcraft | merged | Merged. Added core20 support to spread tests, cleaned up system selection logic to exclusively install snaps, and introduced a dedicated environment for unit tests. A reported test failure was promptly fixed by the author before approval and merge. |