Revert "ros: remove linter warnings from spread tests (#4202)"
Metadata
Current evaluation
Merged #4212 (13071d7a0), reverting d48db220 from #4202 and restoring seven ROS linter-warning expectations in spread tests.
Resolution: closed resolved
Reason: PR #4212 merged at commit 13071d7a0, restoring the warning expectations removed by #4202 after its change proved incorrect.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This reverts commit d48db2202fa9e124750406a736aeb831f30429a3.
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint`?
- [ ] Have you successfully run `pytest tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #4212 (13071d7a0), reverting d48db220 from #4202 and restoring seven ROS linter-warning expectations in spread tests. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #4212 (13071d7a0), restoring ROS spread-test linter warnings by reverting d48db220 from #4202. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to restore linter warnings to spread tests by reverting commit d48db22. Approved by one reviewer, passed CI, and modified one file (+7/-0) without impacting code coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a revert of commit d48db2202fa9e124750406a736aeb831f30429a3, restoring linter warnings in spread tests. Maintainer cmatsuoka approved the change, which merged without impacting code coverage. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcore/snapcraft#4202
(confidence 100%)
Its commit d48db220 was directly reverted by merged PR #4212.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4203 ros: remove linter warnings from spread tests | snapcraft | merged | Merged #4203 into hotfix/7.4, cherry-picking #4202 to remove seven lines of ROS spread-test linter-warning expectations. | |
| #4369 test(spread): make ros linter test less strict | snapcraft | merged | Merged in #4369 as commit 8d0c451a4, relaxing the ROS spread linter test while retaining libpng and ros2-humble warning checks; fixes #4256. | |
| #4202 ros: remove generator warnings from linter spread tests | snapcraft | merged | Merged PR #4202 removed seven generator-warning expectation lines from ROS linter spread tests, aligning fixtures with changed upstream ROS dependency output; Snapcraft's linter was unchanged. | |
| #4113 tests: update linter-ros2-humble-mixed spread test | snapcraft | merged | Merged #4113 as commit 2735e2c3c, removing seven outdated ROS 2 Humble mixed spread-test expectations after extension libraries were removed. | |
| #4595 tests(spread): remove core24 ros2 extension linter tests | snapcraft | merged | Merged PR #4595 (commit 043584583) removing Core 24 ROS 2 extension linter spread tests from five files, since ROS for 24.04 and its extension do not exist. Approved by 2 reviewers. |