ros: remove generator warnings from linter spread tests
Metadata
Current evaluation
Merged PR #4202 removed seven generator-warning expectation lines from ROS linter spread tests, aligning fixtures with changed upstream ROS dependency output; Snapcraft's linter was unchanged.
Resolution: closed resolved
Reason: PR #4202 was merged, removing seven obsolete warning lines from the ROS linter spread-test expectations. Review discussion confirmed that Snapcraft's linter was unchanged and the mismatch came from ROS library or dependency updates.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint`?
- [ ] Have you successfully run `pytest tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4202 removed seven generator-warning expectation lines from ROS linter spread tests, aligning fixtures with changed upstream ROS dependency output; Snapcraft's linter was unchanged. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #4202 at ea38379, removing seven obsolete generator-warning expectations from ROS linter spread tests after upstream dependency changes. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4202 as ea38379, removing seven generator-warning expectations from ROS linter spread tests after upstream ROS/Python dependency changes. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4202 (cmatsuoka) dropped 7 expected generator-warning lines from ROS linter spread tests; ROS libs changed upstream, not snapcraft's linters. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in snapcore/snapcraft#4202, removing seven lines of generator-warning expectations from ROS linter spread tests due to upstream ROS dependency changes. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged removal of generator warnings from ROS linter spread tests. Contributors traced warnings to upstream ROS library updates, not linter changes. The update deletes seven lines, passed CI, and merged with no coverage impact. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to remove generator warnings from ROS linter spread tests. Investigation confirmed the warnings resulted from ROS library or dependency updates, not linter changes. Code coverage remained unchanged. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcore/snapcraft#4184
(confidence 93%)
Merged PR updating the same ROS 2 Humble linter expected output after a Python library change; it was explicitly discussed as context for #4202.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4203 ros: remove linter warnings from spread tests | snapcraft | merged | Merged #4203 into hotfix/7.4, cherry-picking #4202 to remove seven lines of ROS spread-test linter-warning expectations. | |
| #4369 test(spread): make ros linter test less strict | snapcraft | merged | Merged in #4369 as commit 8d0c451a4, relaxing the ROS spread linter test while retaining libpng and ros2-humble warning checks; fixes #4256. | |
| #4212 Revert "ros: remove linter warnings from spread tests (#4202)" | snapcraft | merged | Merged #4212 (13071d7a0), reverting d48db220 from #4202 and restoring seven ROS linter-warning expectations in spread tests. | |
| #4223 ros: make linter tests more flexible | snapcraft | merged | Merged #4223 as commit 64c8f1e87, making the ROS2 Humble mixed linter spread test tolerate changing unused-library lists and prevent flaky failures. | |
| #4113 tests: update linter-ros2-humble-mixed spread test | snapcraft | merged | Merged #4113 as commit 2735e2c3c, removing seven outdated ROS 2 Humble mixed spread-test expectations after extension libraries were removed. | |
| #4256 Improve check for library linter in the ROS tests | snapcraft | closed | Resolved by PR #4369 (commit 8d0c451a4), which made ROS linter tests validate warning patterns instead of exact output. |